new compilerplugin returnbyref

Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7

1 files changed, 4 insertions, 4 deletions

diff --git a/lotuswordpro/source/filter/lwptaboverride.hxx b/lotuswordpro/source/filter/lwptaboverride.hxx
index b9c28e21e5c2..8abcb540b38a 100644
--- a/lotuswordpro/source/filter/lwptaboverride.hxx
+++ b/lotuswordpro/source/filter/lwptaboverride.hxx
@@ -87,7 +87,7 @@ public:
         pStrm->SkipExtra();
     }
 
-    inline LwpObjectID* GetTabRackID();
+    inline LwpObjectID& GetTabRackID();
     inline bool IsTabRackOverridden();
     inline void Override(LwpTabOverride* pOther);
     inline void OverrideTabRack(LwpObjectID* pTabRackID);
@@ -106,9 +106,9 @@ private:
     };
 };
 
-inline LwpObjectID* LwpTabOverride::GetTabRackID()
+inline LwpObjectID& LwpTabOverride::GetTabRackID()
 {
-    return &m_aTabRackID;
+    return m_aTabRackID;
 }
 
 inline void LwpTabOverride::Override(LwpTabOverride* pOther)
@@ -117,7 +117,7 @@ inline void LwpTabOverride::Override(LwpTabOverride* pOther)
     {
         if (IsTabRackOverridden())
             //m_aTabRackID = *(pOther->GetTabRackID());
-            pOther->OverrideTabRack(GetTabRackID());
+            pOther->OverrideTabRack(&GetTabRackID());
     }
 }