diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-02-25 10:24:55 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-02-27 07:34:52 +0100 |
commit | 19240f625f8bd7b772481abc8e678d7b0fadd921 (patch) | |
tree | df98eb1d1d2bf11179aea13de58aa38548458b9d /lotuswordpro/source | |
parent | 60c7725a20ff0d77e3025ed60608f57d46e50b58 (diff) |
loplugin:unusedfields look for classes where we can make all the..
fields private
Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27
Reviewed-on: https://gerrit.libreoffice.org/68302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'lotuswordpro/source')
-rw-r--r-- | lotuswordpro/source/filter/explode.hxx | 3 | ||||
-rw-r--r-- | lotuswordpro/source/filter/lwpcontent.hxx | 2 | ||||
-rw-r--r-- | lotuswordpro/source/filter/lwpdlvlist.hxx | 21 | ||||
-rw-r--r-- | lotuswordpro/source/filter/lwpholder.hxx | 2 | ||||
-rw-r--r-- | lotuswordpro/source/filter/lwprowlayout.hxx | 1 | ||||
-rw-r--r-- | lotuswordpro/source/filter/lwpsection.hxx | 2 | ||||
-rw-r--r-- | lotuswordpro/source/filter/lwptable.hxx | 1 | ||||
-rw-r--r-- | lotuswordpro/source/filter/lwptablelayout.hxx | 2 | ||||
-rw-r--r-- | lotuswordpro/source/filter/lwptabrack.hxx | 2 |
9 files changed, 18 insertions, 18 deletions
diff --git a/lotuswordpro/source/filter/explode.hxx b/lotuswordpro/source/filter/explode.hxx index 01e5ec97b8de..a313c55dd2bd 100644 --- a/lotuswordpro/source/filter/explode.hxx +++ b/lotuswordpro/source/filter/explode.hxx @@ -63,11 +63,10 @@ class SvStream; class HuffmanTreeNode { -public: std::unique_ptr<HuffmanTreeNode> left; std::unique_ptr<HuffmanTreeNode> right; sal_uInt32 value; - +public: explicit HuffmanTreeNode(sal_uInt32 value = 0xffffffff) ; ~HuffmanTreeNode() ; HuffmanTreeNode * InsertNode(sal_uInt32 nValue, const sal_Char * pInCode); diff --git a/lotuswordpro/source/filter/lwpcontent.hxx b/lotuswordpro/source/filter/lwpcontent.hxx index a9e15f05a89e..c29bb6e99029 100644 --- a/lotuswordpro/source/filter/lwpcontent.hxx +++ b/lotuswordpro/source/filter/lwpcontent.hxx @@ -74,7 +74,7 @@ class LwpContent : public LwpDLNFVList { public: LwpContent(LwpObjectHeader const &objHdr, LwpSvStream* pStrm); -protected: +private: LwpAssociatedLayouts m_LayoutsWithMe; sal_uInt16 m_nFlags; LwpAtomHolder m_ClassName; diff --git a/lotuswordpro/source/filter/lwpdlvlist.hxx b/lotuswordpro/source/filter/lwpdlvlist.hxx index f84e74a7c64b..19f8ff7a5253 100644 --- a/lotuswordpro/source/filter/lwpdlvlist.hxx +++ b/lotuswordpro/source/filter/lwpdlvlist.hxx @@ -72,16 +72,14 @@ class LwpDLVList : public LwpObject { public: LwpDLVList(LwpObjectHeader const &objHdr, LwpSvStream* pStrm); + LwpObjectID& GetNext() { return m_ListNext; } + LwpObjectID& GetPrevious() { return m_ListPrevious; } protected: virtual ~LwpDLVList() override {} - + void Read() override; +private: LwpObjectID m_ListPrevious; LwpObjectID m_ListNext; -protected: - void Read() override; -public: - LwpObjectID& GetNext() { return m_ListNext; } - LwpObjectID& GetPrevious() { return m_ListPrevious; } }; /** @@ -118,14 +116,13 @@ class LwpDLNFPVList : public LwpDLNFVList public: LwpDLNFPVList(LwpObjectHeader const &objHdr, LwpSvStream* pStrm); virtual ~LwpDLNFPVList() override; -protected: - bool m_bHasProperties; - std::unique_ptr<LwpPropList> m_pPropList; + LwpPropList* GetPropList() { return m_pPropList.get(); } protected: void Read() override; void ReadPropertyList(LwpObjectStream* pObjStrm); -public: - LwpPropList* GetPropList() { return m_pPropList.get(); } +private: + bool m_bHasProperties; + std::unique_ptr<LwpPropList> m_pPropList; }; /** @@ -153,7 +150,7 @@ public: LwpDLVListHead(){} void Read(LwpObjectStream* pObjStrm); LwpObjectID& GetFirst() { return m_objHead; } -protected: +private: LwpObjectID m_objHead;//LwpDLVList }; diff --git a/lotuswordpro/source/filter/lwpholder.hxx b/lotuswordpro/source/filter/lwpholder.hxx index 1c84bc185d1c..2b5bbc2acb01 100644 --- a/lotuswordpro/source/filter/lwpholder.hxx +++ b/lotuswordpro/source/filter/lwpholder.hxx @@ -106,7 +106,7 @@ public: LwpObjectID& GetObject() { return m_Object; } protected: virtual ~LwpObjectHolder() override {} - +private: LwpObjectID m_Object; }; diff --git a/lotuswordpro/source/filter/lwprowlayout.hxx b/lotuswordpro/source/filter/lwprowlayout.hxx index 6b6aadbe8351..e393c6908779 100644 --- a/lotuswordpro/source/filter/lwprowlayout.hxx +++ b/lotuswordpro/source/filter/lwprowlayout.hxx @@ -122,6 +122,7 @@ public: virtual LWP_LAYOUT_TYPE GetLayoutType () override { return LWP_ROW_HEADING_LAYOUT;} protected: void Read() override; +private: LwpObjectID cRowLayout; }; diff --git a/lotuswordpro/source/filter/lwpsection.hxx b/lotuswordpro/source/filter/lwpsection.hxx index 73de821fab72..7ba45ceba32e 100644 --- a/lotuswordpro/source/filter/lwpsection.hxx +++ b/lotuswordpro/source/filter/lwpsection.hxx @@ -74,7 +74,7 @@ public: void Read() override; LwpObjectID& GetPosition(){ return m_Para;} LwpObjectID& GetListList(){ return m_ListList;} -protected: +private: LwpObjectID m_ListList;//lwplistlist object, LwpObjectID m_Para; }; diff --git a/lotuswordpro/source/filter/lwptable.hxx b/lotuswordpro/source/filter/lwptable.hxx index 435e9e559bba..9a6ffb39b372 100644 --- a/lotuswordpro/source/filter/lwptable.hxx +++ b/lotuswordpro/source/filter/lwptable.hxx @@ -167,6 +167,7 @@ public: virtual ~LwpParallelColumns() override; protected: void Read() override; +private: LwpObjectID cDefaultLeftColumnStyle; LwpObjectID cDefaultRightColumnStyle; }; diff --git a/lotuswordpro/source/filter/lwptablelayout.hxx b/lotuswordpro/source/filter/lwptablelayout.hxx index 700c16647472..29d462359be8 100644 --- a/lotuswordpro/source/filter/lwptablelayout.hxx +++ b/lotuswordpro/source/filter/lwptablelayout.hxx @@ -203,6 +203,7 @@ public: bool IsJustifiable(){return (( m_nAttributes2 & STYLE2_JUSTIFIABLE) != 0);} protected: void Read() override; +private: sal_uInt8 ccolid; sal_Int32 cwidth; @@ -220,6 +221,7 @@ public: void GetStartEndRow(sal_uInt16& nStartRow, sal_uInt16& nEndRow); protected: void Read() override; +private: sal_uInt16 cStartRow; sal_uInt16 cEndRow; }; diff --git a/lotuswordpro/source/filter/lwptabrack.hxx b/lotuswordpro/source/filter/lwptabrack.hxx index dbe058bbc747..0e837547a585 100644 --- a/lotuswordpro/source/filter/lwptabrack.hxx +++ b/lotuswordpro/source/filter/lwptabrack.hxx @@ -100,7 +100,7 @@ public: inline LeaderType GetLeaderType(); inline sal_uInt16 GetAlignChar(); -protected: +private: sal_uInt32 m_nX; sal_uInt8 m_nType; sal_uInt8 m_nLeader; |