diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-28 10:35:49 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-28 12:07:54 +0100 |
| commit | bc539bd3c04964471af6b5ca54264215c8995696 (patch) | |
| tree | c37af5b9fb3dc0b8677fc8dd535fb8e93ad6039d /lotuswordpro/source | |
| parent | 9f78a4174e5099ad3af65a23e158a51c1afca54d (diff) | |
loplugin:stringadd improve detection
if one side of the expression is a compile-time-constant, we don't need
to worry about side-effects on the other side
Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b
Reviewed-on: https://gerrit.libreoffice.org/81589
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'lotuswordpro/source')
4 files changed, 12 insertions, 12 deletions
diff --git a/lotuswordpro/source/filter/lwptblformula.cxx b/lotuswordpro/source/filter/lwptblformula.cxx index c6af01f6e34f..fa8f39fa0bb4 100644 --- a/lotuswordpro/source/filter/lwptblformula.cxx +++ b/lotuswordpro/source/filter/lwptblformula.cxx @@ -101,9 +101,9 @@ void LwpFormulaInfo::ReadText() std::vector<char> aBuf(nStrLen + 1); m_pObjStrm->QuickRead(aBuf.data(), nStrLen); aBuf[nStrLen]= '\0'; - OUString aText = "\""; - aText += OUString(aBuf.data(), nStrLen, osl_getThreadTextEncoding()); - aText += "\""; + OUString aText = "\"" + + OUString(aBuf.data(), nStrLen, osl_getThreadTextEncoding()) + + "\""; m_aStack.push_back(std::make_unique<LwpFormulaText>(aText)); } diff --git a/lotuswordpro/source/filter/xfilter/xfdrawpath.cxx b/lotuswordpro/source/filter/xfilter/xfdrawpath.cxx index e9ae753773a4..9061f583f152 100644 --- a/lotuswordpro/source/filter/xfilter/xfdrawpath.cxx +++ b/lotuswordpro/source/filter/xfilter/xfdrawpath.cxx @@ -128,9 +128,9 @@ void XFDrawPath::ToXml(IXFStream *pStrm) //view-box: XFRect rect = m_aRect; - OUString strViewBox = "0 0 "; - strViewBox += OUString::number(rect.GetWidth()*1000) + " "; - strViewBox += OUString::number(rect.GetHeight()*1000); + OUString strViewBox = "0 0 " + + OUString::number(rect.GetWidth()*1000) + " " + + OUString::number(rect.GetHeight()*1000); pAttrList->AddAttribute( "svg:viewBox", strViewBox); //points diff --git a/lotuswordpro/source/filter/xfilter/xfdrawpolygon.cxx b/lotuswordpro/source/filter/xfilter/xfdrawpolygon.cxx index 6b50db7c56ed..dcc12c2dadb8 100644 --- a/lotuswordpro/source/filter/xfilter/xfdrawpolygon.cxx +++ b/lotuswordpro/source/filter/xfilter/xfdrawpolygon.cxx @@ -71,9 +71,9 @@ void XFDrawPolygon::ToXml(IXFStream *pStrm) pAttrList->Clear(); //view-box: XFRect rect = CalcViewBox(); - OUString strViewBox = "0 0 "; - strViewBox += OUString::number(rect.GetWidth()*1000) + " "; - strViewBox += OUString::number(rect.GetHeight()*1000); + OUString strViewBox = "0 0 " + + OUString::number(rect.GetWidth()*1000) + " " + + OUString::number(rect.GetHeight()*1000); pAttrList->AddAttribute( "svg:viewBox", strViewBox); //points diff --git a/lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx b/lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx index 2ddeca7f0c58..4cad76ebb3c4 100644 --- a/lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx +++ b/lotuswordpro/source/filter/xfilter/xfdrawpolyline.cxx @@ -71,9 +71,9 @@ void XFDrawPolyline::ToXml(IXFStream *pStrm) pAttrList->Clear(); //view-box: XFRect rect = CalcViewBox(); - OUString strViewBox = "0 0 "; - strViewBox += OUString::number(rect.GetWidth()*1000) + " "; - strViewBox += OUString::number(rect.GetHeight()*1000); + OUString strViewBox = "0 0 " + + OUString::number(rect.GetWidth()*1000) + " " + + OUString::number(rect.GetHeight()*1000); pAttrList->AddAttribute( "svg:viewBox", strViewBox); //points |