clang-tidy: Silence warnings from WIP unhandled-self-assignment check

Where it can be done by removing useless / duplicate code.
For XFListStyle I removed the copy operator entirely, because it
was bugous and it seems not to be used anyway.

Change-Id: Iba0eb0d5c45b42f0e78be466c617acdc1216eb22
Reviewed-on: https://gerrit.libreoffice.org/70482
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

2 files changed, 1 insertions, 22 deletions

diff --git a/lotuswordpro/inc/xfilter/xfliststyle.hxx b/lotuswordpro/inc/xfilter/xfliststyle.hxx
index f4abb93a5b10..3cde9644a612 100644
--- a/lotuswordpro/inc/xfilter/xfliststyle.hxx
+++ b/lotuswordpro/inc/xfilter/xfliststyle.hxx
@@ -190,7 +190,7 @@ public:
 
     XFListStyle(const XFListStyle& other);
 
-    XFListStyle& operator=(const XFListStyle& other);
+    XFListStyle& operator=(const XFListStyle& other) = delete;
 
     virtual ~XFListStyle() override;
 
diff --git a/lotuswordpro/source/filter/xfilter/xfliststyle.cxx b/lotuswordpro/source/filter/xfilter/xfliststyle.cxx
index 85db3c77a973..5205020784d4 100644
--- a/lotuswordpro/source/filter/xfilter/xfliststyle.cxx
+++ b/lotuswordpro/source/filter/xfilter/xfliststyle.cxx
@@ -185,27 +185,6 @@ XFListStyle::XFListStyle(const XFListStyle& other):XFStyle(other)
     }
 }
 
-XFListStyle& XFListStyle::operator=(const XFListStyle& other)
-{
-    for( int i=0; i<10; i++ )
-    {
-        const enumXFListLevel type = other.m_pListLevels[i]->m_eListType;
-        if( type == enumXFListLevelNumber )
-        {
-            XFListlevelNumber *pNum = static_cast<XFListlevelNumber*>(m_pListLevels[i].get());
-            m_pListLevels[i].reset(new XFListlevelNumber(*pNum));
-        }
-        else if( type == enumXFListLevelBullet )
-        {
-            XFListLevelBullet *pBullet = static_cast<XFListLevelBullet*>(m_pListLevels[i].get());
-            m_pListLevels[i].reset(new XFListLevelBullet(*pBullet));
-        }
-        else
-            m_pListLevels[i].reset();
-    }
-    return *this;
-}
-
 XFListStyle::~XFListStyle()
 {
 }