diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2016-04-11 16:50:02 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2016-04-11 16:58:48 +0200 |
commit | 5183dad60e5a5ce04f1f606a09d5ef3e850a464d (patch) | |
tree | 8089f69c147aaafb0eddffc523f79cee215d4262 /mysqlc | |
parent | cd43b8cf32f749a5c65ec13998ae491311f58d1a (diff) |
Lock member access in Frame::disposing
What a mess. Ideally, Frame would use its own rBHelper.rMutex, not SolarMutex.
But much of the framework code it calls into uses SolarMutex, too, making it
difficult to change that without running into the risk of deadlock. And then,
some member variables are cleared early in Frame::disposing, while others are
only cleared en bloc at the end. Be conservative and keep it that way (as other
Frame functions recursively called from within Frame::disposing could observe
the difference and rely on the current behavior), even if that means creating
lots of small, independent locked regions within Frame::disposing (which can be
detrimental to both performance and correctness).
Change-Id: I28f9a379ce03ed661e96c7deb8eb73cb58fb2cf7
Diffstat (limited to 'mysqlc')
0 files changed, 0 insertions, 0 deletions