diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2021-08-06 12:22:43 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2021-08-06 15:22:37 +0200 |
| commit | 5c299f0112441ca095276376a9973cb4ff0fda02 (patch) | |
| tree | b22242431a80c3a189f0905c0e651bb04c6a6cd0 /nlpsolver/src | |
| parent | 8d8450f0c14db26fb8eb44677c2887e619200904 (diff) | |
cid#1489772 UR: Uninitialized read of field in constructor
pass in SearchPoint to initialize pbest_t before it is then
passed to setMemPoints
setMemPoints sets the pbest_t variable of AbsGTBehavior so
calling setPbest on AbsGTBehavior subclasses after calling
that doesn't do anything so drop it, and then DEPSAgent.setPbest
isn't needed anymore
Change-Id: Id4fdc770cefc0f801218dc9bf51a6dc5b1e25d5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120115
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'nlpsolver/src')
| -rw-r--r-- | nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java index 7a4c552d9e60..2b6c1ce36c73 100644 --- a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java +++ b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java @@ -141,8 +141,9 @@ public final class DEPSSolverImpl extends BaseEvolutionarySolver psGTBehavior.weight = m_weight.getValue(); psGTBehavior.setLibrary(m_library); - agents[i] = new DEPSAgent(m_problemEncoder, deGTBehavior, psGTBehavior, m_agentSwitchRate.getValue(), m_specCompareEngine); - agents[i].setPbest(m_library.getSelectedPoint(i)); + agents[i] = new DEPSAgent(m_problemEncoder, deGTBehavior, psGTBehavior, + m_agentSwitchRate.getValue(), m_specCompareEngine, + m_library.getSelectedPoint(i)); } //Learn: |