summaryrefslogtreecommitdiff
path: root/odk
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2013-02-26 10:58:48 +0100
committerStephan Bergmann <sbergman@redhat.com>2013-02-26 10:59:22 +0100
commitde471513bb012839e6c5d1640ed22b6c24bd8ec0 (patch)
treec6d6217b88314f20b6b0734c9c83677194ec7c2d /odk
parent5d9cf23fd3956d5165ced2dab119f0dce0173f49 (diff)
CustomTarget_include had apparently been forgotten
Change-Id: If61617ae3d18ef4f15f2d150af76f0b1b64a3fa6
Diffstat (limited to 'odk')
-rw-r--r--odk/CustomTarget_include.mk6
-rw-r--r--odk/CustomTarget_odkcommon.mk1
-rw-r--r--odk/Module_odk.mk1
3 files changed, 6 insertions, 2 deletions
diff --git a/odk/CustomTarget_include.mk b/odk/CustomTarget_include.mk
index 7f4ec62caf94..08f10c4a2f71 100644
--- a/odk/CustomTarget_include.mk
+++ b/odk/CustomTarget_include.mk
@@ -7,6 +7,8 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
#
+$(eval $(call gb_CustomTarget_CustomTarget,odk/odkcommon/include))
+
include $(SRCDIR)/solenv/inc/udkversion.mk
odk_INCDIRLIST := sal salhelper rtl osl store typelib uno cppu cppuhelper \
@@ -27,7 +29,7 @@ odk_INCLIST := $(subst $(OUTDIR)/inc/,,$(shell find \
define odk_inc
odkcommon_ZIPLIST += include/$(1)
-$(call gb_CustomTarget_get_target,odk/odkcommon): $(odk_WORKDIR)/include/$(1)
+$(call gb_CustomTarget_get_target,odk/odkcommon/include): $(odk_WORKDIR)/include/$(1)
$(odk_WORKDIR)/include/$(1): $(foreach dir,$(odk_INCDIRLIST),$(call gb_Package_get_target,$(dir)_inc))
mkdir -p $$(dir $$@)
$$(call gb_Output_announce,$$(subst $$(WORKDIR)/,,$$@),build,CPY,1)
@@ -37,7 +39,7 @@ endef
$(foreach inc,$(odk_INCLIST),$(eval $(call odk_inc,$(inc))))
odkcommon_ZIPLIST += include/udkversion.mk
-$(eval $(call gb_CustomTarget_register_target,odk/odkcommon,include/udkversion.mk))
+$(eval $(call gb_CustomTarget_register_target,odk/odkcommon/include,include/udkversion.mk))
$(odk_WORKDIR)/include/udkversion.mk:
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),ECH,1)
echo "#UDK version number" > $@
diff --git a/odk/CustomTarget_odkcommon.mk b/odk/CustomTarget_odkcommon.mk
index 11a775ab9542..03c44abf0ca3 100644
--- a/odk/CustomTarget_odkcommon.mk
+++ b/odk/CustomTarget_odkcommon.mk
@@ -21,6 +21,7 @@ $(call gb_CustomTarget_get_target,odk/odkcommon): \
$(call gb_CustomTarget_get_target,odk/odkcommon/bin) \
$(call gb_CustomTarget_get_target,odk/odkcommon/lib) \
$(call gb_CustomTarget_get_target,odk/odkcommon/idl) \
+ $(call gb_CustomTarget_get_target,odk/odkcommon/include) \
$(if $(filter MSC,$(COM)),$(call gb_CustomTarget_get_target,odk/odkcommon/cli))
ifeq ($(OS),WNT)
diff --git a/odk/Module_odk.mk b/odk/Module_odk.mk
index c66e1dd65a14..f93a6c6570f5 100644
--- a/odk/Module_odk.mk
+++ b/odk/Module_odk.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_Module_add_targets,odk,\
CustomTarget_settings \
CustomTarget_autodoc \
CustomTarget_idl \
+ CustomTarget_include \
Executable_unoapploader \
Zip_odkexamples \
))
and Makefiles) into configure.ac, because otherwise these must replicate the "same" branching, often resulting in diversions. Better to keep the logic in one place (configure.ac) and set additional variables to be used directly by source code and Makefiles. Notably this introduce the "using_*" platform flags, which should be considered constants. There is USING_X11, which actually tells, if the build uses the platform's X11 (and I opted for the removal of HAVE_FEATURE_X11). I also consider variables constant, after they have been exported by AC_SUBST, which should never be conditional, or some AC_DEFINE set them for a config header. A large block of defaults depends on $using_x11, so we set them to the same value, but just if the platform doesn't set it. The other important flag is $using_freetype_fontconfig, if the platform uses freetype and fontconfig. The headless plugin uses cairo for its drawing operations and freetype+fontconfig for text, so $test_cairo = $using_freetype_fontconfig. This is independent from a the cairo canvas! The OpenGL X11 code now depends on USING_X11, but it doesn't yet reflect the filter in Library_vcl.mk protecting glx. I don't know how correct this glx filter is, seeing that the source code just checked for "UNX - some non-X11 targets". Change-Id: Id1ba1a967a5d8d10ee217458be879ed00459f7e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116440 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> 2021-05-28Select svl crypto backend in configure.acJan-Marek Glogowski And define USE_CRYPTO_* macros to select it in code. This way we can get rid of all the HAVE_FEATURE_NSS and _WIN32 variations. This also reverts 1f6b98f21495f0ecc5ded493cb3273da03852191. Change-Id: I101e4ae2f49cdb127d59bd49a4f1c86304ca2238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116338 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> 2021-04-15vcl PDFiumLibraryTest: clean up not needed HAVE_FEATURE_PDFIUM ifdefsMiklos Vajna This was already conditional in Module_vcl, so no need to have a duplicated check here. Which allows finally removing the HAVE_FEATURE_PDFIUM ifdef completely. New code can just call vcl::pdf::PDFiumLibrary::get() at runtime and see if the result is nullptr or not. Change-Id: I36508181865a31618e48cf7c2680d75465130dd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114108 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> 2021-01-14Resolves tdf#139343 and tdf#139335 - Community/Enterprise flavorHeiko Tietze * Switch CE/EE per --disable-community-flavor internally use HAVE_FEATURE_COMMUNITY_FLAVOR * Version info in about dialog shows text depending on this flavor * Start center also shows the brand image now * TDF builds use a brand image with TDF tagline in the about dialog * Brand images with just "Community" (no Edition) Change-Id: I363dd2b39df9aad951c9d79addf9bdedfc4a3495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108980 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>