summaryrefslogtreecommitdiff
path: root/offapi
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.com>2023-05-25 08:15:10 +0200
committerMiklos Vajna <vmiklos@collabora.com>2023-05-25 10:35:41 +0200
commit98a87f015800cd2e81e43732d7effe723b61e02a (patch)
treef590a9b0e8e6f22fe8a38a5cc4e5bf3dbe66e7a4 /offapi
parentf5dc52dc9a068fec3323c3089929a81675b0d1ba (diff)
[API CHANGE] remove XModuleUIConfigurationManager3 and XUIConfigurationManager3
The motivation was to not modify XModuleUIConfigurationManager / XUIConfigurationManager, but as pointed out at <https://gerrit.libreoffice.org/c/core/+/151798/10#message-31d00a775989b981a5f50639623cc773d6ea930d>, it may be fine to modify XModuleUIConfigurationManager2 and XUIConfigurationManager2 instead of adding XModuleUIConfigurationManager3 and XUIConfigurationManager3. Indeed, searching for usage in <https://github.com/libreoffice/wollmux>, only the published interfaces are used, so let's fold XModuleUIConfigurationManager3 into XModuleUIConfigurationManager2 and XUIConfigurationManager3 into XUIConfigurationManager2. This is a reasonable middle ground between 0 API change and breaking known users of the public API. Change-Id: I2dedee7e255f9dda9c9057961e6c829f83b2b709 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152254 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'offapi')
-rw-r--r--offapi/UnoApi_offapi.mk2
-rw-r--r--offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl2
-rw-r--r--offapi/com/sun/star/ui/UIConfigurationManager.idl2
-rw-r--r--offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl8
-rw-r--r--offapi/com/sun/star/ui/XModuleUIConfigurationManager3.idl41
-rw-r--r--offapi/com/sun/star/ui/XUIConfigurationManager2.idl8
-rw-r--r--offapi/com/sun/star/ui/XUIConfigurationManager3.idl39
7 files changed, 18 insertions, 84 deletions
diff --git a/offapi/UnoApi_offapi.mk b/offapi/UnoApi_offapi.mk
index 4a42279b2c54..7ee71bb984c1 100644
--- a/offapi/UnoApi_offapi.mk
+++ b/offapi/UnoApi_offapi.mk
@@ -4058,7 +4058,6 @@ $(eval $(call gb_UnoApi_add_idlfiles,offapi,com/sun/star/ui,\
XImageManager \
XModuleUIConfigurationManager \
XModuleUIConfigurationManager2 \
- XModuleUIConfigurationManager3 \
XModuleUIConfigurationManagerSupplier \
XPanel \
XPanels \
@@ -4071,7 +4070,6 @@ $(eval $(call gb_UnoApi_add_idlfiles,offapi,com/sun/star/ui,\
XUIConfigurationListener \
XUIConfigurationManager \
XUIConfigurationManager2 \
- XUIConfigurationManager3 \
XUIConfigurationManagerSupplier \
XUIConfigurationPersistence \
XUIConfigurationStorage \
diff --git a/offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl b/offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl
index 56fd37bcbfef..6fe18b254fc6 100644
--- a/offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl
+++ b/offapi/com/sun/star/ui/ModuleUIConfigurationManager.idl
@@ -36,7 +36,7 @@ module com { module sun { module star { module ui {
@since OOo 2.0
*/
-service ModuleUIConfigurationManager : XModuleUIConfigurationManager3
+service ModuleUIConfigurationManager : XModuleUIConfigurationManager2
{
/** provides a function to initialize a module user interface configuration manager instance.
diff --git a/offapi/com/sun/star/ui/UIConfigurationManager.idl b/offapi/com/sun/star/ui/UIConfigurationManager.idl
index c0ae1683f106..bff584dcdb83 100644
--- a/offapi/com/sun/star/ui/UIConfigurationManager.idl
+++ b/offapi/com/sun/star/ui/UIConfigurationManager.idl
@@ -25,7 +25,7 @@ module com { module sun { module star { module ui {
@since OOo 2.0
*/
-service UIConfigurationManager : XUIConfigurationManager3;
+service UIConfigurationManager : XUIConfigurationManager2;
}; }; }; };
diff --git a/offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl b/offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl
index 301304aa4901..c97c05738e09 100644
--- a/offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl
+++ b/offapi/com/sun/star/ui/XModuleUIConfigurationManager2.idl
@@ -45,6 +45,14 @@ interface XModuleUIConfigurationManager2
interface configuration manager.
*/
interface com::sun::star::ui::XUIConfiguration;
+
+ /**
+ Creates a new configuration manager in case there are different views with different languages.
+ This function enables those views to have short cut keys specific to the languages.
+
+ @since LibreOffice 7.6
+ */
+ com::sun::star::ui::XAcceleratorConfiguration createShortCutManager();
};
diff --git a/offapi/com/sun/star/ui/XModuleUIConfigurationManager3.idl b/offapi/com/sun/star/ui/XModuleUIConfigurationManager3.idl
deleted file mode 100644
index 494de200b2e9..000000000000
--- a/offapi/com/sun/star/ui/XModuleUIConfigurationManager3.idl
+++ /dev/null
@@ -1,41 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-module com { module sun { module star { module ui {
-
-/**
- Provides a unified interface for the ModuleUIConfigurationManager service.
-
- @since LibreOffice 7.6
-*/
-interface XModuleUIConfigurationManager3
-{
- interface com::sun::star::ui::XModuleUIConfigurationManager2;
-
- /**
- Creates a new configuration manager in case there are different views with different languages.
- This function enables those views to have short cut keys specific to the languages.
- */
- com::sun::star::ui::XAcceleratorConfiguration createShortCutManager();
-};
-
-
-}; }; }; };
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/offapi/com/sun/star/ui/XUIConfigurationManager2.idl b/offapi/com/sun/star/ui/XUIConfigurationManager2.idl
index fd165b3422be..f9bcf8c57d5f 100644
--- a/offapi/com/sun/star/ui/XUIConfigurationManager2.idl
+++ b/offapi/com/sun/star/ui/XUIConfigurationManager2.idl
@@ -52,6 +52,14 @@ interface XUIConfigurationManager2
</p>
*/
interface ::com::sun::star::lang::XComponent;
+
+ /**
+ Creates a new configuration manager in case there are different views with different languages.
+ This function enables those views to have short cut keys specific to the languages.
+
+ @since LibreOffice 7.6
+ */
+ com::sun::star::ui::XAcceleratorConfiguration createShortCutManager();
};
diff --git a/offapi/com/sun/star/ui/XUIConfigurationManager3.idl b/offapi/com/sun/star/ui/XUIConfigurationManager3.idl
deleted file mode 100644
index 73652fc6c8ef..000000000000
--- a/offapi/com/sun/star/ui/XUIConfigurationManager3.idl
+++ /dev/null
@@ -1,39 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-module com { module sun { module star { module ui {
-
-/**
- @since LibreOffice 7.6
-*/
-interface XUIConfigurationManager3
-{
- interface com::sun::star::ui::XUIConfigurationManager2;
-
- /**
- Creates a new configuration manager in case there are different views with different languages.
- This function enables those views to have short cut keys specific to the languages.
- */
- com::sun::star::ui::XAcceleratorConfiguration createShortCutManager();
-};
-
-
-}; }; }; };
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */