summaryrefslogtreecommitdiff
path: root/oox/source/drawingml/connectorhelper.cxx
diff options
context:
space:
mode:
authorRegina Henschel <rb.henschel@t-online.de>2023-09-06 23:03:39 +0200
committerMiklos Vajna <vmiklos@collabora.com>2023-11-15 11:13:31 +0100
commit0430adb42bc38f037b907984e71c144d863796cb (patch)
treecb2104e03b5f35f8eebfa0eecc142918e3522861 /oox/source/drawingml/connectorhelper.cxx
parentc0df28f957b43f0ecbffdc994ee0702dbe5bc33f (diff)
Import Wordprocessing Canvas, wpc:wpc element
Currently LibreOffice uses the VML fallback, when a docx document has a wpc:wpc element. This patch implements to use the choice part with the wpc:wpc element. That is often called 'drawing canvas'. The patch uses a similar approach as for SmartArt. The drawing canvas is imported as group shape and for the background an additional rectangular shape is inserted as first in the children vector. Not using VML has the advantage, that the custom shape import is used for preset shapes. VML import produces problems because some properties are not available in VML or the current VML import has deficits. The test suite shows examples, what is better without using the VML fallback. Affected bug reports are e.g. tdf#104671 or tdf#154828. A drawing canvas must be used in Word for connector shapes. A connector in Word on the drawing canvas is not written as cxnSp element, but as ordinary wsp element with additional wps:cNvCnPr child element. The patch generates a connector in such case. Unsolved problems: The path of a curved connector in OOXML is basically incompatible to the path which LibreOffice generates. This patch uses the default path for a curved connector. Same is done in import in Impress. Using the VML fallback had generated a custom shape with the current path and handles, but the connections to the target shapes were lost. Export to docx is missing. The drawing canvas is not recreated, instead a group with the additional background shape is exported. That is no regression, using VML has produced a group too on export. I don't know whether XML_graphicFrame can occur in WordprocessingCanvasContext. At least charts and math equations are not possible on the drawing canvas in Word. Import of WordArt shapes does not work. That is not regression. It works neither in the VML import. Change-Id: I04bf8407efd1939cdf3137775f8afad420b74014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156629 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'oox/source/drawingml/connectorhelper.cxx')
-rw-r--r--oox/source/drawingml/connectorhelper.cxx368
1 files changed, 368 insertions, 0 deletions
diff --git a/oox/source/drawingml/connectorhelper.cxx b/oox/source/drawingml/connectorhelper.cxx
new file mode 100644
index 000000000000..82bd92a568b1
--- /dev/null
+++ b/oox/source/drawingml/connectorhelper.cxx
@@ -0,0 +1,368 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include <drawingml/connectorhelper.hxx>
+
+#include <sal/config.h>
+
+#include <com/sun/star/beans/XPropertySet.hpp>
+#include <com/sun/star/container/XIdentifierContainer.hpp>
+#include <com/sun/star/drawing/XGluePointsSupplier.hpp>
+
+#include <basegfx/curve/b2dcubicbezier.hxx>
+#include <basegfx/matrix/b2dhommatrix.hxx>
+#include <basegfx/point/b2dpoint.hxx>
+#include <basegfx/polygon/b2dpolypolygontools.hxx>
+#include <basegfx/vector/b2dvector.hxx>
+#include <drawingml/customshapeproperties.hxx>
+#include <oox/drawingml/drawingmltypes.hxx>
+#include <oox/drawingml/shape.hxx>
+#include <rtl/ustring.hxx>
+#include <svl/itempool.hxx>
+#include <svx/svdmodel.hxx>
+#include <svx/svdoedge.hxx>
+#include <svx/svdobj.hxx>
+#include <tools/mapunit.hxx>
+#include <tools/UnitConversion.hxx>
+
+#include <map>
+#include <set>
+#include <string_view>
+#include <vector>
+
+using namespace ::com::sun::star;
+
+OUString ConnectorHelper::getShapePresetTypeNameOUString(
+ const oox::drawingml::CustomShapePropertiesPtr& pCustomShapePropertiesPtr)
+{
+ return rtl::OUString(reinterpret_cast<const char*>(
+ pCustomShapePropertiesPtr->getShapePresetTypeName().getConstArray()),
+ pCustomShapePropertiesPtr->getShapePresetTypeName().getLength(),
+ RTL_TEXTENCODING_UTF8);
+}
+
+// These shapes have no gluepoints defined in their mso_CustomShape struct, thus the gluepoint
+// adaption to default gluepoints will be done. Other shapes having no gluepoint defined in the
+// mso_CustomShape struct, have gluepoints in order top-left-bottom-right in OOXML. But the shapes
+// below have order right-bottom-left-top. Adding gluepoints to mso_CustomShape structs does not
+// solve the problem because MS binary gluepoints and OOXML gluepoints are different.
+
+bool ConnectorHelper::hasClockwiseCxn(const OUString& rShapeType)
+{
+ static const std::set<OUString> aWithClockwiseCxnSet({ u"accentBorderCallout1"_ustr,
+ u"accentBorderCallout2"_ustr,
+ u"accentBorderCallout3"_ustr,
+ u"accentCallout1"_ustr,
+ u"accentCallout2"_ustr,
+ u"accentCallout3"_ustr,
+ u"actionButtonBackPrevious"_ustr,
+ u"actionButtonBeginning"_ustr,
+ u"actionButtonBlank"_ustr,
+ u"actionButtonDocument"_ustr,
+ u"actionButtonEnd"_ustr,
+ u"actionButtonForwardNext"_ustr,
+ u"actionButtonHelp"_ustr,
+ u"actionButtonHome"_ustr,
+ u"actionButtonInformation"_ustr,
+ u"actionButtonMovie"_ustr,
+ u"actionButtonReturn"_ustr,
+ u"actionButtonSound"_ustr,
+ u"borderCallout1"_ustr,
+ u"borderCallout2"_ustr,
+ u"borderCallout3"_ustr,
+ u"callout1"_ustr,
+ u"callout2"_ustr,
+ u"callout3"_ustr,
+ u"cloud"_ustr,
+ u"corner"_ustr,
+ u"diagStripe"_ustr,
+ u"flowChartOfflineStorage"_ustr,
+ u"halfFrame"_ustr,
+ u"mathDivide"_ustr,
+ u"mathMinus"_ustr,
+ u"mathPlus"_ustr,
+ u"nonIsoscelesTrapezoid"_ustr,
+ u"pie"_ustr,
+ u"round2DiagRect"_ustr,
+ u"round2SameRect"_ustr,
+ u"snip1Rect"_ustr,
+ u"snip2DiagRect"_ustr,
+ u"snip2SameRect"_ustr,
+ u"snipRoundRect"_ustr });
+ return aWithClockwiseCxnSet.contains(rShapeType);
+}
+
+basegfx::B2DHomMatrix
+ConnectorHelper::getConnectorTransformMatrix(const oox::drawingml::ShapePtr& pConnector)
+{
+ basegfx::B2DHomMatrix aTransform; // ctor generates unit matrix
+ if (!pConnector)
+ return aTransform;
+ if (pConnector->getFlipH())
+ aTransform.scale(-1.0, 1.0);
+ if (pConnector->getFlipV())
+ aTransform.scale(1.0, -1.0);
+ if (pConnector->getRotation() == 0)
+ return aTransform;
+ if (pConnector->getRotation() == 5400000)
+ aTransform *= basegfx::B2DHomMatrix(0, -1, 0, 1, 0, 0);
+ else if (pConnector->getRotation() == 10800000)
+ aTransform *= basegfx::B2DHomMatrix(-1, 0, 0, 0, -1, 0);
+ else if (pConnector->getRotation() == 16200000)
+ aTransform *= basegfx::B2DHomMatrix(0, 1, 0, -1, 0, 0);
+ else
+ SAL_WARN("oox", "tdf#157888 LibreOffice cannot handle such connector rotation");
+ return aTransform;
+}
+
+void ConnectorHelper::getOOXHandlePositionsHmm(const oox::drawingml::ShapePtr& pConnector,
+ std::vector<basegfx::B2DPoint>& rHandlePositions)
+{
+ rHandlePositions.clear();
+
+ if (!pConnector)
+ return;
+
+ if (pConnector->getConnectorName() == u"bentConnector2"_ustr
+ || pConnector->getConnectorName() == u"curvedConnector2"_ustr)
+ return; // These have no handles.
+
+ // Convert string attribute to number. Set default 50000 if missing.
+ std::vector<sal_Int32> aAdjustmentOOXVec; // 1/100000 of shape size
+ for (size_t i = 0; i < 3; i++)
+ {
+ if (i < pConnector->getConnectorAdjustments().size())
+ aAdjustmentOOXVec.push_back(pConnector->getConnectorAdjustments()[i].toInt32());
+ else
+ aAdjustmentOOXVec.push_back(50000);
+ }
+
+ // Handle positions depend on EdgeKind and ShapeSize. bendConnector and curvedConnector use the
+ // same handle positions. The formulas here correspond to guides in the bendConnector in
+ // presetShapeDefinitions.xml.
+ const double fWidth = pConnector->getSize().Width; // EMU
+ const double fHeight = pConnector->getSize().Height; // EMU
+ const double fPosX = pConnector->getPosition().X; // EMU
+ const double fPosY = pConnector->getPosition().Y; // EMU
+
+ if (pConnector->getConnectorName() == u"bentConnector3"_ustr
+ || pConnector->getConnectorName() == u"curvedConnector3"_ustr)
+ {
+ double fAdj1 = aAdjustmentOOXVec[0];
+ double fX1 = fAdj1 / 100000.0 * fWidth;
+ double fY1 = fHeight / 2.0;
+ rHandlePositions.push_back({ fX1, fY1 });
+ }
+ else if (pConnector->getConnectorName() == u"bentConnector4"_ustr
+ || pConnector->getConnectorName() == u"curvedConnector4"_ustr)
+ {
+ double fAdj1 = aAdjustmentOOXVec[0];
+ double fAdj2 = aAdjustmentOOXVec[1];
+ double fX1 = fAdj1 / 100000.0 * fWidth;
+ double fX2 = (fX1 + fWidth) / 2.0;
+ double fY2 = fAdj2 / 100000.0 * fHeight;
+ double fY1 = fY2 / 2.0;
+ rHandlePositions.push_back({ fX1, fY1 });
+ rHandlePositions.push_back({ fX2, fY2 });
+ }
+ else if (pConnector->getConnectorName() == u"bentConnector5"_ustr
+ || pConnector->getConnectorName() == u"curvedConnector5"_ustr)
+ {
+ double fAdj1 = aAdjustmentOOXVec[0];
+ double fAdj2 = aAdjustmentOOXVec[1];
+ double fAdj3 = aAdjustmentOOXVec[2];
+ double fX1 = fAdj1 / 100000.0 * fWidth;
+ double fX3 = fAdj3 / 100000.0 * fWidth;
+ double fX2 = (fX1 + fX3) / 2.0;
+ double fY2 = fAdj2 / 100000.0 * fHeight;
+ double fY1 = fY2 / 2.0;
+ double fY3 = (fHeight + fY2) / 2.0;
+ rHandlePositions.push_back({ fX1, fY1 });
+ rHandlePositions.push_back({ fX2, fY2 });
+ rHandlePositions.push_back({ fX3, fY3 });
+ }
+
+ // The presetGeometry has the first segment horizontal and start point left/top with
+ // coordinates (0|0). Other layouts are done by flipping and rotating.
+ basegfx::B2DHomMatrix aTransform;
+ const basegfx::B2DPoint aB2DCenter(fWidth / 2.0, fHeight / 2.0);
+ aTransform.translate(-aB2DCenter);
+ aTransform *= getConnectorTransformMatrix(pConnector);
+ aTransform.translate(aB2DCenter);
+
+ // Make coordinates absolute
+ aTransform.translate(fPosX, fPosY);
+
+ // Actually transform the handle coordinates
+ for (auto& rElem : rHandlePositions)
+ rElem *= aTransform;
+
+ // Convert EMU -> Hmm
+ for (auto& rElem : rHandlePositions)
+ rElem /= 360.0;
+}
+
+void ConnectorHelper::getLOBentHandlePositionsHmm(const oox::drawingml::ShapePtr& pConnector,
+ std::vector<basegfx::B2DPoint>& rHandlePositions)
+{
+ // This method is intended for Edgekind css::drawing::ConnectorType_STANDARD. Those connectors
+ // correspond to OOX bentConnector, aka "ElbowConnector".
+ rHandlePositions.clear();
+
+ if (!pConnector)
+ return;
+ uno::Reference<drawing::XShape> xConnector(pConnector->getXShape());
+ if (!xConnector.is())
+ return;
+
+ // Get the EdgeTrack polygon. We cannot use UNO "PolyPolygonBezier" because that includes
+ // the yet not known anchor position in Writer. Thus get the polygon directly from the object.
+ SdrEdgeObj* pEdgeObj = dynamic_cast<SdrEdgeObj*>(SdrObject::getSdrObjectFromXShape(xConnector));
+ if (!pEdgeObj)
+ return;
+ basegfx::B2DPolyPolygon aB2DPolyPolygon(pEdgeObj->GetEdgeTrackPath());
+ if (aB2DPolyPolygon.count() == 0)
+ return;
+
+ basegfx::B2DPolygon aEdgePolygon = aB2DPolyPolygon.getB2DPolygon(0);
+ if (aEdgePolygon.count() < 4 || aEdgePolygon.areControlPointsUsed())
+ return;
+
+ // We need Hmm, the polygon might be e.g. in Twips, in Writer for example
+ MapUnit eMapUnit = pEdgeObj->getSdrModelFromSdrObject().GetItemPool().GetMetric(0);
+ if (eMapUnit != MapUnit::Map100thMM)
+ {
+ const auto eFrom = MapToO3tlLength(eMapUnit);
+ if (eFrom == o3tl::Length::invalid)
+ return;
+ const double fConvert(o3tl::convert(1.0, eFrom, o3tl::Length::mm100));
+ aEdgePolygon.transform(basegfx::B2DHomMatrix(fConvert, 0.0, 0.0, 0.0, fConvert, 0.0));
+ }
+
+ // LO has the handle in the middle of a segment, but not for first and last segment.
+ for (sal_uInt32 i = 1; i < aEdgePolygon.count() - 2; i++)
+ {
+ const basegfx::B2DPoint aBeforePt(aEdgePolygon.getB2DPoint(i));
+ const basegfx::B2DPoint aAfterPt(aEdgePolygon.getB2DPoint(i + 1));
+ rHandlePositions.push_back((aBeforePt + aAfterPt) / 2.0);
+ }
+}
+
+// This is similar to SlidePersist::createConnectorShapeConnection()
+void ConnectorHelper::applyConnections(oox::drawingml::ShapePtr& rConnector,
+ oox::drawingml::ShapeIdMap& rShapeMap)
+{
+ uno::Reference<drawing::XShape> xConnector(rConnector->getXShape());
+ if (!xConnector.is())
+ return;
+ uno::Reference<beans::XPropertySet> xPropSet(xConnector, uno::UNO_QUERY);
+ if (!xPropSet.is())
+ return;
+
+ // MS Office allows route between shapes with small distance. LO default is 5mm.
+ xPropSet->setPropertyValue("EdgeNode1HorzDist", uno::Any(sal_Int32(0)));
+ xPropSet->setPropertyValue("EdgeNode1VertDist", uno::Any(sal_Int32(0)));
+ xPropSet->setPropertyValue("EdgeNode2HorzDist", uno::Any(sal_Int32(0)));
+ xPropSet->setPropertyValue("EdgeNode2VertDist", uno::Any(sal_Int32(0)));
+
+ oox::drawingml::ConnectorShapePropertiesList aConnectorShapeProperties
+ = rConnector->getConnectorShapeProperties();
+ // It contains maximal two items, each a struct with mbStartShape, maDestShapeId, mnDestGlueId
+ for (const auto& aIt : aConnectorShapeProperties)
+ {
+ const auto& pItem = rShapeMap.find(aIt.maDestShapeId);
+ if (pItem == rShapeMap.end())
+ continue;
+
+ uno::Reference<drawing::XShape> xShape(pItem->second->getXShape(), uno::UNO_QUERY);
+ if (xShape.is())
+ {
+ // Connect to the found shape.
+ if (aIt.mbStartShape)
+ xPropSet->setPropertyValue("StartShape", uno::Any(xShape));
+ else
+ xPropSet->setPropertyValue("EndShape", uno::Any(xShape));
+
+ // The first four glue points are the default glue points, which are set by LibreOffice.
+ // They do not belong to the preset geometry of the shape.
+ // Adapt gluepoint index to LibreOffice
+ uno::Reference<drawing::XGluePointsSupplier> xSupplier(xShape, uno::UNO_QUERY);
+ css::uno::Reference<css::container::XIdentifierContainer> xGluePoints(
+ xSupplier->getGluePoints(), uno::UNO_QUERY);
+ sal_Int32 nCountGluePoints = xGluePoints->getIdentifiers().getLength();
+ sal_Int32 nGlueId = aIt.mnDestGlueId;
+
+ if (nCountGluePoints > 4)
+ nGlueId += 4;
+ else
+ {
+ // In these cases the mso_CustomShape struct defines no gluepoints (Why not?), thus
+ // our default gluepoints are used. The order of the default gluepoints might differ
+ // from the order of the OOXML gluepoints. We try to change nGlueId so, that the
+ // connector attaches to a default gluepoint at the same side as it attaches in OOXML.
+ const OUString sShapeType = ConnectorHelper::getShapePresetTypeNameOUString(
+ pItem->second->getCustomShapeProperties());
+ if (ConnectorHelper::hasClockwiseCxn(sShapeType))
+ nGlueId = (nGlueId + 1) % 4;
+ else
+ {
+ bool bFlipH = pItem->second->getFlipH();
+ bool bFlipV = pItem->second->getFlipV();
+ if (bFlipH == bFlipV)
+ {
+ // change id of the left and right glue points of the bounding box (1 <-> 3)
+ if (nGlueId == 1)
+ nGlueId = 3; // Right
+ else if (nGlueId == 3)
+ nGlueId = 1; // Left
+ }
+ }
+ }
+
+ if (aIt.mbStartShape)
+ xPropSet->setPropertyValue("StartGluePointIndex", uno::Any(nGlueId));
+ else
+ xPropSet->setPropertyValue("EndGluePointIndex", uno::Any(nGlueId));
+ }
+ }
+}
+
+void ConnectorHelper::applyBentHandleAdjustments(oox::drawingml::ShapePtr pConnector)
+{
+ uno::Reference<drawing::XShape> xConnector(pConnector->getXShape(), uno::UNO_QUERY);
+ if (!xConnector.is())
+ return;
+ uno::Reference<beans::XPropertySet> xPropSet(xConnector, uno::UNO_QUERY);
+ if (!xPropSet.is())
+ return;
+
+ std::vector<basegfx::B2DPoint> aOOXMLHandles;
+ ConnectorHelper::getOOXHandlePositionsHmm(pConnector, aOOXMLHandles);
+ std::vector<basegfx::B2DPoint> aLODefaultHandles;
+ ConnectorHelper::getLOBentHandlePositionsHmm(pConnector, aLODefaultHandles);
+
+ if (aOOXMLHandles.size() == aLODefaultHandles.size())
+ {
+ bool bUseYforHori
+ = basegfx::fTools::equalZero(getConnectorTransformMatrix(pConnector).get(0, 0));
+ for (size_t i = 0; i < aOOXMLHandles.size(); i++)
+ {
+ basegfx::B2DVector aDiff(aOOXMLHandles[i] - aLODefaultHandles[i]);
+ sal_Int32 nDiff;
+ if ((i == 1 && !bUseYforHori) || (i != 1 && bUseYforHori))
+ nDiff = basegfx::fround(aDiff.getY());
+ else
+ nDiff = basegfx::fround(aDiff.getX());
+ xPropSet->setPropertyValue("EdgeLine" + OUString::number(i + 1) + "Delta",
+ uno::Any(nDiff));
+ }
+ }
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */