diff options
author | Tor Lillqvist <tml@iki.fi> | 2021-01-20 12:16:09 +0200 |
---|---|---|
committer | Tor Lillqvist <tml@collabora.com> | 2021-01-20 17:28:32 +0100 |
commit | e2fcbac50549ca96b092d64bd14a37cee6b12e0a (patch) | |
tree | 6811dea3e85e8a08c139f0544ba722f8cf83b086 /oox/source/drawingml/diagram | |
parent | 3d2a431da1126f4924f6cd7e5abac6488cd480e7 (diff) |
Simplify error handling
There were a couple of weird things in this script. Firstly, the
script redirected stdout and stderr from each invocation of codesign
separately into a log file. (Several differently named log files.) But
those log files were never displayed.
Secondly, the script did "set -e" at the start. Thus, if a codesign
invocation returned non-zero (error) exit status, any code to check
the exit status and possibly display the log file would not be
executed anyway.
Simplify thusly:
Don't pass --verbose to codesign. Then if nothing goes wrong, it is
silent. That is The Unix Philosophy, right?
Don't redirect codesign stdout and stderr to a log file (that would be
removed if codesign didn't fail). Just let any error message of
warning from codesign go to the script's stderr or stdout.
If codesign fails, just exit. Error messages will have been written to
stderr already. No log files to display or remove.
Don't use set -e. Instead if a codesign invocation fails, just exit.
The intent is that in the normal case, this script will be totally
silent.
Change-Id: Ic6081c418e4c564be768e30bf52b8196ee59f061
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109696
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Diffstat (limited to 'oox/source/drawingml/diagram')
0 files changed, 0 insertions, 0 deletions