diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-06 08:50:58 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-06 09:54:25 +0200 |
| commit | 24eae7bd702f3f6dd790be7ac38ac16e9fe6a375 (patch) | |
| tree | 56398264184709e84517c2e843aa3a0894cc1c51 /oox/source/drawingml | |
| parent | fad919eb0d30b2303193e1c00ba765514957652c (diff) | |
clang-tidy performance-unnecessary-value-param
Change-Id: I69247498e13331f6ef84afeb242479f8fb1178a8
Reviewed-on: https://gerrit.libreoffice.org/60068
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'oox/source/drawingml')
| -rw-r--r-- | oox/source/drawingml/shape.cxx | 11 | ||||
| -rw-r--r-- | oox/source/drawingml/textbodycontext.cxx | 4 | ||||
| -rw-r--r-- | oox/source/drawingml/textbodypropertiescontext.cxx | 7 |
3 files changed, 11 insertions, 11 deletions
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx index 2f7cd0722938..6b5f9ac79b0e 100644 --- a/oox/source/drawingml/shape.cxx +++ b/oox/source/drawingml/shape.cxx @@ -429,12 +429,11 @@ static inline SdrTextHorzAdjust lcl_convertAdjust( ParagraphAdjust eAdjust ) return SDRTEXTHORZADJUST_LEFT; } -static inline void lcl_createPresetShape( uno::Reference<drawing::XShape>& xShape, - const OUString& rClass, - const OUString& rPresetType, - const CustomShapePropertiesPtr pCustomShapePropertiesPtr, - const TextBodyPtr pTextBody, - const GraphicHelper& rGraphicHelper ) +static inline void lcl_createPresetShape(uno::Reference<drawing::XShape>& xShape, + const OUString& rClass, const OUString& rPresetType, + const CustomShapePropertiesPtr& pCustomShapePropertiesPtr, + const TextBodyPtr& pTextBody, + const GraphicHelper& rGraphicHelper) { if (!xShape.is() || !pCustomShapePropertiesPtr || !pTextBody) return; diff --git a/oox/source/drawingml/textbodycontext.cxx b/oox/source/drawingml/textbodycontext.cxx index 6279b129cf02..cbd1e420ee5a 100644 --- a/oox/source/drawingml/textbodycontext.cxx +++ b/oox/source/drawingml/textbodycontext.cxx @@ -164,8 +164,8 @@ TextBodyContext::TextBodyContext( ContextHandler2Helper const & rParent, TextBod { } -TextBodyContext::TextBodyContext( ContextHandler2Helper const & rParent, ShapePtr pShapePtr ) -: TextBodyContext( rParent, *pShapePtr->getTextBody() ) +TextBodyContext::TextBodyContext(ContextHandler2Helper const& rParent, const ShapePtr& pShapePtr) + : TextBodyContext(rParent, *pShapePtr->getTextBody()) { mpShapePtr = pShapePtr; } diff --git a/oox/source/drawingml/textbodypropertiescontext.cxx b/oox/source/drawingml/textbodypropertiescontext.cxx index 6de4a0764cbd..9f1549c87126 100644 --- a/oox/source/drawingml/textbodypropertiescontext.cxx +++ b/oox/source/drawingml/textbodypropertiescontext.cxx @@ -49,9 +49,10 @@ using namespace ::com::sun::star::xml::sax; namespace oox { namespace drawingml { // CT_TextBodyProperties -TextBodyPropertiesContext::TextBodyPropertiesContext( ContextHandler2Helper const & rParent, - const AttributeList& rAttribs, ShapePtr pShapePtr ) -: TextBodyPropertiesContext( rParent, rAttribs, pShapePtr->getTextBody()->getTextProperties() ) +TextBodyPropertiesContext::TextBodyPropertiesContext(ContextHandler2Helper const& rParent, + const AttributeList& rAttribs, + const ShapePtr& pShapePtr) + : TextBodyPropertiesContext(rParent, rAttribs, pShapePtr->getTextBody()->getTextProperties()) { mpShapePtr = pShapePtr; } |