diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2024-11-01 12:05:18 +0500 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2024-11-01 09:54:03 +0100 |
| commit | 9732a89b6bfff019ca0ac816cd821f049ab6ebbf (patch) | |
| tree | d7f1a312223e52d416294a979bd83ff888c17b27 /oox/source/drawingml | |
| parent | 5c2778037f16784482088aa4008a7bf27aa7bd50 (diff) | |
Drop GraphicFilter's bUseConfig
It controlled how the FilterConfigCache initialized, and also how
the unused aFilterPath was initialized. The FilterConfigCache is
reused, when there are other instances of GraphicFilter - so that
means, that the "bUseConfig" flag doesn't necessarily mean that
the initialization will happen as intended: the existing instance
could have been initialized using the other value.
Avoid this indeterministic behavior, and always use the config,
except in fuzzing. The VCL tests, that could possibly once depend
on that, now use config, so this is not an issue - and that means
testing the same thing as used in the working code, not something
different.
Change-Id: I6555dc47328b362e020138cf454f5ede7f39d063
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175894
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'oox/source/drawingml')
| -rw-r--r-- | oox/source/drawingml/shape.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx index 991a37c99be0..68a1bea9ddc2 100644 --- a/oox/source/drawingml/shape.cxx +++ b/oox/source/drawingml/shape.cxx @@ -2426,7 +2426,7 @@ Reference < XShape > Shape::renderDiagramToGraphic( XmlFilterBase const & rFilte aTempStream.Seek( STREAM_SEEK_TO_BEGIN ); Graphic aGraphic; - GraphicFilter aFilter( false ); + GraphicFilter aFilter; if ( aFilter.ImportGraphic( aGraphic, u"", aTempStream, GRFILTER_FORMAT_NOTFOUND, nullptr, GraphicFilterImportFlags::NONE ) != ERRCODE_NONE ) { SAL_WARN( "oox.drawingml", "Shape::renderDiagramToGraphic: Unable to import rendered stream into graphic object" ); |