diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-25 08:14:07 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-30 12:32:14 +0100 |
| commit | 8332d6d8200e8ca1f22dd98d9373efd5a431d09c (patch) | |
| tree | dd45d452202998297b8562743ea6345462304d04 /oox/source/dump | |
| parent | d05a4cfbdcece491f7385dbeaa7eca03f2fdc1d5 (diff) | |
loplugin:stringviewparam include comparisons with string literals
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'oox/source/dump')
| -rw-r--r-- | oox/source/dump/dumperbase.cxx | 36 |
1 files changed, 18 insertions, 18 deletions
diff --git a/oox/source/dump/dumperbase.cxx b/oox/source/dump/dumperbase.cxx index d553dd092ff7..df18516a0aef 100644 --- a/oox/source/dump/dumperbase.cxx +++ b/oox/source/dump/dumperbase.cxx @@ -622,46 +622,46 @@ OString StringHelper::convertToUtf8( const OUString& rStr ) return OUStringToOString( rStr, RTL_TEXTENCODING_UTF8 ); } -DataType StringHelper::convertToDataType( const OUString& rStr ) +DataType StringHelper::convertToDataType( std::u16string_view rStr ) { DataType eType = DATATYPE_VOID; - if ( rStr == "int8" ) + if ( rStr == u"int8" ) eType = DATATYPE_INT8; - else if ( rStr == "uint8" ) + else if ( rStr == u"uint8" ) eType = DATATYPE_UINT8; - else if ( rStr == "int16" ) + else if ( rStr == u"int16" ) eType = DATATYPE_INT16; - else if ( rStr == "uint16" ) + else if ( rStr == u"uint16" ) eType = DATATYPE_UINT16; - else if ( rStr == "int32" ) + else if ( rStr == u"int32" ) eType = DATATYPE_INT32; - else if ( rStr == "uint32" ) + else if ( rStr == u"uint32" ) eType = DATATYPE_UINT32; - else if ( rStr == "int64" ) + else if ( rStr == u"int64" ) eType = DATATYPE_INT64; - else if ( rStr == "uint64" ) + else if ( rStr == u"uint64" ) eType = DATATYPE_UINT64; - else if ( rStr == "float" ) + else if ( rStr == u"float" ) eType = DATATYPE_FLOAT; - else if ( rStr == "double" ) + else if ( rStr == u"double" ) eType = DATATYPE_DOUBLE; return eType; } -FormatType StringHelper::convertToFormatType( const OUString& rStr ) +FormatType StringHelper::convertToFormatType( std::u16string_view rStr ) { FormatType eType = FORMATTYPE_NONE; - if ( rStr == "dec" ) + if ( rStr == u"dec" ) eType = FORMATTYPE_DEC; - else if ( rStr == "hex" ) + else if ( rStr == u"hex" ) eType = FORMATTYPE_HEX; - else if ( rStr == "shorthex" ) + else if ( rStr == u"shorthex" ) eType = FORMATTYPE_SHORTHEX; - else if ( rStr == "bin" ) + else if ( rStr == u"bin" ) eType = FORMATTYPE_BIN; - else if ( rStr == "fix" ) + else if ( rStr == u"fix" ) eType = FORMATTYPE_FIX; - else if ( rStr == "bool" ) + else if ( rStr == u"bool" ) eType = FORMATTYPE_BOOL; return eType; } |