diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-03-11 13:43:39 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-03-12 07:31:08 +0100 |
| commit | 31bf558349d9ab2634e9a866edf79bc115d649ce (patch) | |
| tree | 5bf9c60d40144bb4454ba7f1179a973383f1ba3c /oox/source/export | |
| parent | 469aea3b3b76926112d7b6fce212be2906842dc9 (diff) | |
Revert "loplugin:constfields in oox"
This reverts commit a84e3df74eecc8778e3d5be5dd80ad4ddb511edf.
Now that we know that making fields has negative side effects
like disabling assignment operator generation.
Change-Id: I7b45b7ead281cf3a9202ca6aabc55ee5033e5331
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90332
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'oox/source/export')
| -rw-r--r-- | oox/source/export/ColorPropertySet.cxx | 2 | ||||
| -rw-r--r-- | oox/source/export/ColorPropertySet.hxx | 6 | ||||
| -rw-r--r-- | oox/source/export/chartexport.cxx | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/oox/source/export/ColorPropertySet.cxx b/oox/source/export/ColorPropertySet.cxx index 5b3d71a6d422..84f7da6a72f8 100644 --- a/oox/source/export/ColorPropertySet.cxx +++ b/oox/source/export/ColorPropertySet.cxx @@ -47,7 +47,7 @@ protected: virtual sal_Bool SAL_CALL hasPropertyByName( const OUString& Name ) override; private: - OUString const m_aColorPropName; + OUString m_aColorPropName; Property m_aColorProp; }; diff --git a/oox/source/export/ColorPropertySet.hxx b/oox/source/export/ColorPropertySet.hxx index 1ac05f5cf823..e1734422ac8c 100644 --- a/oox/source/export/ColorPropertySet.hxx +++ b/oox/source/export/ColorPropertySet.hxx @@ -75,10 +75,10 @@ protected: private: css::uno::Reference< css::beans::XPropertySetInfo > m_xInfo; - OUString const m_aColorPropName; + OUString m_aColorPropName; ::Color m_nColor; - bool const m_bIsFillColor; - ::Color const m_nDefaultColor; + bool m_bIsFillColor; + ::Color m_nDefaultColor; }; } // namespace chart diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx index aecfe3948d33..1d0aed9ef442 100644 --- a/oox/source/export/chartexport.cxx +++ b/oox/source/export/chartexport.cxx @@ -157,7 +157,7 @@ public: } private: - OUString const m_aRole; + OUString m_aRole; }; } |