diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2017-01-26 12:28:58 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2017-01-26 12:54:43 +0000 |
commit | e57ca02849c3d87142ff5ff9099a212e72b8139c (patch) | |
tree | bcce66b27261553c308779f3e8663a269ed3a671 /oox/source/ole | |
parent | 8802ebd5172ec4bc412a59d136c82b77ab452281 (diff) |
Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'oox/source/ole')
-rw-r--r-- | oox/source/ole/olestorage.cxx | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/oox/source/ole/olestorage.cxx b/oox/source/ole/olestorage.cxx index 4e20a9dda1c7..7d282bfdf6f1 100644 --- a/oox/source/ole/olestorage.cxx +++ b/oox/source/ole/olestorage.cxx @@ -59,19 +59,19 @@ public: const Reference< XNameContainer >& rxStorage, const OUString& rElementName ); - virtual void SAL_CALL seek( sal_Int64 nPos ) throw( IllegalArgumentException, IOException, RuntimeException, std::exception ) override; - virtual sal_Int64 SAL_CALL getPosition() throw( IOException, RuntimeException, std::exception ) override; - virtual sal_Int64 SAL_CALL getLength() throw( IOException, RuntimeException, std::exception ) override; + virtual void SAL_CALL seek( sal_Int64 nPos ) override; + virtual sal_Int64 SAL_CALL getPosition() override; + virtual sal_Int64 SAL_CALL getLength() override; - virtual void SAL_CALL writeBytes( const Sequence< sal_Int8 >& rData ) throw( NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception ) override; - virtual void SAL_CALL flush() throw( NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception ) override; - virtual void SAL_CALL closeOutput() throw( NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception ) override; + virtual void SAL_CALL writeBytes( const Sequence< sal_Int8 >& rData ) override; + virtual void SAL_CALL flush() override; + virtual void SAL_CALL closeOutput() override; private: /// @throws IOException - void ensureSeekable() const throw( IOException ); + void ensureSeekable() const; /// @throws NotConnectedException - void ensureConnected() const throw( NotConnectedException ); + void ensureConnected() const; private: Reference< XNameContainer > mxStorage; @@ -97,37 +97,37 @@ OleOutputStream::OleOutputStream( const Reference< XComponentContext >& rxContex } } -void SAL_CALL OleOutputStream::seek( sal_Int64 nPos ) throw( IllegalArgumentException, IOException, RuntimeException, std::exception ) +void SAL_CALL OleOutputStream::seek( sal_Int64 nPos ) { ensureSeekable(); mxSeekable->seek( nPos ); } -sal_Int64 SAL_CALL OleOutputStream::getPosition() throw( IOException, RuntimeException, std::exception ) +sal_Int64 SAL_CALL OleOutputStream::getPosition() { ensureSeekable(); return mxSeekable->getPosition(); } -sal_Int64 SAL_CALL OleOutputStream::getLength() throw( IOException, RuntimeException, std::exception ) +sal_Int64 SAL_CALL OleOutputStream::getLength() { ensureSeekable(); return mxSeekable->getLength(); } -void SAL_CALL OleOutputStream::writeBytes( const Sequence< sal_Int8 >& rData ) throw( NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception ) +void SAL_CALL OleOutputStream::writeBytes( const Sequence< sal_Int8 >& rData ) { ensureConnected(); mxOutStrm->writeBytes( rData ); } -void SAL_CALL OleOutputStream::flush() throw( NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception ) +void SAL_CALL OleOutputStream::flush() { ensureConnected(); mxOutStrm->flush(); } -void SAL_CALL OleOutputStream::closeOutput() throw( NotConnectedException, BufferSizeExceededException, IOException, RuntimeException, std::exception ) +void SAL_CALL OleOutputStream::closeOutput() { ensureConnected(); ensureSeekable(); @@ -145,13 +145,13 @@ void SAL_CALL OleOutputStream::closeOutput() throw( NotConnectedException, Buffe throw IOException(); } -void OleOutputStream::ensureSeekable() const throw( IOException ) +void OleOutputStream::ensureSeekable() const { if( !mxSeekable.is() ) throw IOException(); } -void OleOutputStream::ensureConnected() const throw( NotConnectedException ) +void OleOutputStream::ensureConnected() const { if( !mxOutStrm.is() ) throw NotConnectedException(); |