diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:09:01 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-13 13:19:22 +0200 |
commit | 91dd2db17bd6cb9b357d1d69b187174e31eabef0 (patch) | |
tree | d634de3a1a6820904b5699c2136b79b1a5a807c7 /oox/source/shape | |
parent | 6f8ea7e89ea190b9462c945d55a3ad8777b2f3ef (diff) |
loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
Diffstat (limited to 'oox/source/shape')
-rw-r--r-- | oox/source/shape/LockedCanvasContext.hxx | 2 | ||||
-rw-r--r-- | oox/source/shape/ShapeContextHandler.hxx | 2 | ||||
-rw-r--r-- | oox/source/shape/ShapeDrawingFragmentHandler.hxx | 2 | ||||
-rw-r--r-- | oox/source/shape/ShapeFilterBase.hxx | 2 | ||||
-rw-r--r-- | oox/source/shape/WpgContext.hxx | 2 | ||||
-rw-r--r-- | oox/source/shape/WpsContext.hxx | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/oox/source/shape/LockedCanvasContext.hxx b/oox/source/shape/LockedCanvasContext.hxx index 21dc10f3f804..ca7ac4ade8d1 100644 --- a/oox/source/shape/LockedCanvasContext.hxx +++ b/oox/source/shape/LockedCanvasContext.hxx @@ -23,7 +23,7 @@ class LockedCanvasContext : public oox::core::ContextHandler2 { public: explicit LockedCanvasContext(oox::core::ContextHandler2Helper& rParent); - virtual ~LockedCanvasContext(); + virtual ~LockedCanvasContext() override; virtual ::oox::core::ContextHandlerRef onCreateContext(sal_Int32 Element, const ::oox::AttributeList& rAttribs) override; diff --git a/oox/source/shape/ShapeContextHandler.hxx b/oox/source/shape/ShapeContextHandler.hxx index 103a8106bd08..c594288d4d80 100644 --- a/oox/source/shape/ShapeContextHandler.hxx +++ b/oox/source/shape/ShapeContextHandler.hxx @@ -54,7 +54,7 @@ public: explicit ShapeContextHandler (css::uno::Reference< css::uno::XComponentContext > const & context); - virtual ~ShapeContextHandler(); + virtual ~ShapeContextHandler() override; // css::lang::XServiceInfo: virtual OUString SAL_CALL getImplementationName() diff --git a/oox/source/shape/ShapeDrawingFragmentHandler.hxx b/oox/source/shape/ShapeDrawingFragmentHandler.hxx index a14dcac6f40a..b4e202b15694 100644 --- a/oox/source/shape/ShapeDrawingFragmentHandler.hxx +++ b/oox/source/shape/ShapeDrawingFragmentHandler.hxx @@ -20,7 +20,7 @@ class ShapeDrawingFragmentHandler : public oox::core::FragmentHandler2 { public: ShapeDrawingFragmentHandler( oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, oox::drawingml::ShapePtr const & pGroupShapePtr ) throw(); - virtual ~ShapeDrawingFragmentHandler() throw(); + virtual ~ShapeDrawingFragmentHandler() throw() override; virtual void SAL_CALL endDocument() throw (css::xml::sax::SAXException, css::uno::RuntimeException, std::exception) override; virtual ::oox::core::ContextHandlerRef onCreateContext(sal_Int32 Element, const AttributeList& rAttribs ) override; diff --git a/oox/source/shape/ShapeFilterBase.hxx b/oox/source/shape/ShapeFilterBase.hxx index a99c90c239ba..94d760992661 100644 --- a/oox/source/shape/ShapeFilterBase.hxx +++ b/oox/source/shape/ShapeFilterBase.hxx @@ -39,7 +39,7 @@ public: const css::uno::Reference< css::uno::XComponentContext >& rxContext ) throw( css::uno::RuntimeException ); - virtual ~ShapeFilterBase(); + virtual ~ShapeFilterBase() override; /** Has to be implemented by each filter, returns the current theme. */ virtual const ::oox::drawingml::Theme* getCurrentTheme() const override; diff --git a/oox/source/shape/WpgContext.hxx b/oox/source/shape/WpgContext.hxx index a212bef255cd..6144ce427755 100644 --- a/oox/source/shape/WpgContext.hxx +++ b/oox/source/shape/WpgContext.hxx @@ -23,7 +23,7 @@ class WpgContext : public oox::core::ContextHandler2 { public: explicit WpgContext(oox::core::ContextHandler2Helper& rParent); - virtual ~WpgContext(); + virtual ~WpgContext() override; virtual oox::core::ContextHandlerRef onCreateContext(sal_Int32 nElementToken, const oox::AttributeList& rAttribs) override; diff --git a/oox/source/shape/WpsContext.hxx b/oox/source/shape/WpsContext.hxx index 799b2117e972..03091c738132 100644 --- a/oox/source/shape/WpsContext.hxx +++ b/oox/source/shape/WpsContext.hxx @@ -23,7 +23,7 @@ class WpsContext : public oox::core::ContextHandler2 { public: WpsContext(oox::core::ContextHandler2Helper& rParent, css::uno::Reference<css::drawing::XShape> const& xShape); - virtual ~WpsContext(); + virtual ~WpsContext() override; virtual oox::core::ContextHandlerRef onCreateContext(sal_Int32 nElementToken, const oox::AttributeList& rAttribs) override; |