summaryrefslogtreecommitdiff
path: root/oox/source
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-12-29 14:15:54 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-12-29 18:19:37 +0100
commit4b030651a0ad5e0eedd6d08b6cd1459ca514d818 (patch)
tree5a02580a42d8593c3afc9f39816128562a9cfc6b /oox/source
parentd460842616d467dfaf7b51ac2db94adb1ff5cbb0 (diff)
loplugin:passstuffbyref improved return in various
Change-Id: I0a8282d8e0d9575b055243073fc89a7d6b67b560 Reviewed-on: https://gerrit.libreoffice.org/47173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'oox/source')
-rw-r--r--oox/source/core/filterbase.cxx4
-rw-r--r--oox/source/drawingml/chart/converterbase.cxx4
-rw-r--r--oox/source/drawingml/diagram/layoutatomvisitors.hxx2
-rw-r--r--oox/source/export/vmlexport.cxx4
4 files changed, 7 insertions, 7 deletions
diff --git a/oox/source/core/filterbase.cxx b/oox/source/core/filterbase.cxx
index 2808134857d0..aee15b3995a8 100644
--- a/oox/source/core/filterbase.cxx
+++ b/oox/source/core/filterbase.cxx
@@ -329,7 +329,7 @@ OUString FilterBase::getAbsoluteUrl( const OUString& rUrl ) const
return aUrl;
}
-StorageRef FilterBase::getStorage() const
+StorageRef const & FilterBase::getStorage() const
{
return mxImpl->mxStorage;
}
@@ -522,7 +522,7 @@ bool FilterBase::implFinalizeExport( MediaDescriptor& /*rMediaDescriptor*/ )
return true;
}
-Reference< XStream > FilterBase::getMainDocumentStream( ) const
+Reference< XStream > const & FilterBase::getMainDocumentStream( ) const
{
return mxImpl->mxOutStream;
}
diff --git a/oox/source/drawingml/chart/converterbase.cxx b/oox/source/drawingml/chart/converterbase.cxx
index cf2bd687053c..35ed591936f5 100644
--- a/oox/source/drawingml/chart/converterbase.cxx
+++ b/oox/source/drawingml/chart/converterbase.cxx
@@ -229,7 +229,7 @@ Reference< XInterface > ConverterRoot::createInstance( const OUString& rServiceN
return xInt;
}
-Reference< XComponentContext > ConverterRoot::getComponentContext() const
+Reference< XComponentContext > const & ConverterRoot::getComponentContext() const
{
return mxData->mrFilter.getComponentContext();
}
@@ -244,7 +244,7 @@ ChartConverter& ConverterRoot::getChartConverter() const
return mxData->mrConverter;
}
-Reference< XChartDocument > ConverterRoot::getChartDocument() const
+Reference< XChartDocument > const & ConverterRoot::getChartDocument() const
{
return mxData->mxDoc;
}
diff --git a/oox/source/drawingml/diagram/layoutatomvisitors.hxx b/oox/source/drawingml/diagram/layoutatomvisitors.hxx
index 18effc18be92..299739186315 100644
--- a/oox/source/drawingml/diagram/layoutatomvisitors.hxx
+++ b/oox/source/drawingml/diagram/layoutatomvisitors.hxx
@@ -68,7 +68,7 @@ class ShapeTemplateVisitor : public LayoutAtomVisitor
public:
void defaultVisit(LayoutAtom const & rAtom);
- ShapePtr getShapeCopy() const
+ ShapePtr const & getShapeCopy() const
{ return mpShape; }
};
diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx
index 498552b01c8a..0e3de4a20dda 100644
--- a/oox/source/export/vmlexport.cxx
+++ b/oox/source/export/vmlexport.cxx
@@ -1397,7 +1397,7 @@ void VMLExport::EndShape( sal_Int32 nShapeElement )
}
}
-OString VMLExport::AddSdrObject( const SdrObject& rObj, sal_Int16 eHOri, sal_Int16 eVOri, sal_Int16 eHRel, sal_Int16 eVRel, const bool bOOxmlExport )
+OString const & VMLExport::AddSdrObject( const SdrObject& rObj, sal_Int16 eHOri, sal_Int16 eVOri, sal_Int16 eHRel, sal_Int16 eVRel, const bool bOOxmlExport )
{
m_pSdrObject = &rObj;
m_eHOri = eHOri;
@@ -1409,7 +1409,7 @@ OString VMLExport::AddSdrObject( const SdrObject& rObj, sal_Int16 eHOri, sal_Int
return m_sShapeId;
}
-OString VMLExport::AddInlineSdrObject( const SdrObject& rObj, const bool bOOxmlExport )
+OString const & VMLExport::AddInlineSdrObject( const SdrObject& rObj, const bool bOOxmlExport )
{
m_pSdrObject = &rObj;
m_eHOri = -1;