diff options
| author | Vinit Agarwal <agarwalvinit5678@gmail.com> | 2023-03-06 13:22:10 +0530 |
|---|---|---|
| committer | Xisco Fauli <xiscofauli@libreoffice.org> | 2023-03-08 08:34:49 +0000 |
| commit | df28c5ac2d4883706556772462933f70151fa379 (patch) | |
| tree | 76c3c2c5efa1d81e7bebcd6da7397ae88b81742b /oox | |
| parent | 65dd1525e826006f78f86688032459dbd7ab4bb4 (diff) | |
tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors
modified: oox/qa/unit/drawingml.cxx
Line number 168
Changed from sal_Int32 to Color which was declared on Line 162
Line number 290
Changed from sal_Int32 to Color which was declared on Line 288
Change-Id: If19b31c54639f1796d5e6375350bec91ec3f79d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148296
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'oox')
| -rw-r--r-- | oox/qa/unit/drawingml.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/oox/qa/unit/drawingml.cxx b/oox/qa/unit/drawingml.cxx index 3355b66e79f6..994006e76113 100644 --- a/oox/qa/unit/drawingml.cxx +++ b/oox/qa/unit/drawingml.cxx @@ -159,13 +159,13 @@ CPPUNIT_TEST_FIXTURE(OoxDrawingmlTest, testChartDataLabelCharColor) xDataPoint->getPropertyValue("CustomLabelFields") >>= aLabels; uno::Reference<beans::XPropertySet> xLabel = aLabels[0]; - sal_Int32 nCharColor = 0; + Color nCharColor; xLabel->getPropertyValue("CharColor") >>= nCharColor; // Without the accompanying fix in place, this test would have failed with: // - Expected: 16777215 // - Actual : -1 // i.e. the data label had no explicit (white) color. - CPPUNIT_ASSERT_EQUAL(static_cast<sal_Int32>(0xffffff), nCharColor); + CPPUNIT_ASSERT_EQUAL(COL_WHITE, nCharColor); } CPPUNIT_TEST_FIXTURE(OoxDrawingmlTest, testGradientMultiStepTransparency) @@ -285,9 +285,9 @@ CPPUNIT_TEST_FIXTURE(OoxDrawingmlTest, testTableShadow) CPPUNIT_ASSERT(xShape->getPropertyValue("Shadow") >>= bShadow); CPPUNIT_ASSERT(bShadow); - sal_Int32 nColor = 0; + Color nColor; CPPUNIT_ASSERT(xShape->getPropertyValue("ShadowColor") >>= nColor); - CPPUNIT_ASSERT_EQUAL(static_cast<sal_Int32>(0xff0000), nColor); + CPPUNIT_ASSERT_EQUAL(Color(0xff0000), nColor); }; loadFromURL(u"table-shadow.pptx"); // Without the accompanying fix in place, this test would have failed, because shadow on a table |