summaryrefslogtreecommitdiff
path: root/oox
diff options
context:
space:
mode:
authorCaolán McNamara <caolan.mcnamara@collabora.com>2024-01-24 20:24:12 +0000
committerAndras Timar <andras.timar@collabora.com>2024-01-29 10:30:25 +0100
commit29a02c146ce22855c83c4e601b58bb6ae17aaea9 (patch)
treedbe3a5d9fbee79588fa534d454aa8c9ce28c6a91 /oox
parent631e5b18b33cb861f161b505bbebdfd90b2181cc (diff)
crashtesting: crash seen on import of forum-mso-en4-278652.xlsx
probably an issue since: commit 135ce256ce9e879663d828ec6e699de521fad867 Date: Mon Aug 14 15:59:18 2023 +0200 tdf#146487 Don't show generic diagram title when there is an empty title given Change-Id: I12d8d6e78a8435b998084221402b6bdfc4a1a433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162539 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Diffstat (limited to 'oox')
-rw-r--r--oox/source/drawingml/chart/chartspaceconverter.cxx3
1 files changed, 2 insertions, 1 deletions
diff --git a/oox/source/drawingml/chart/chartspaceconverter.cxx b/oox/source/drawingml/chart/chartspaceconverter.cxx
index f9b370e04d8f..9280d42ff25c 100644
--- a/oox/source/drawingml/chart/chartspaceconverter.cxx
+++ b/oox/source/drawingml/chart/chartspaceconverter.cxx
@@ -191,7 +191,8 @@ void ChartSpaceConverter::convertFromModel( const Reference< XShapes >& rxExtern
&& mrModel.mxTitle->mxTextProp.is()
&& mrModel.mxTitle->mxTextProp->isEmpty();
// Also for tdf#146487
- bool bEmptyRichText = mrModel.mxTitle->mxText.is()
+ bool bEmptyRichText = mrModel.mxTitle
+ && mrModel.mxTitle->mxText.is()
&& mrModel.mxTitle->mxText->mxTextBody.is()
&& mrModel.mxTitle->mxText->mxTextBody->isEmpty();