diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 07:54:15 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 10:29:38 +0200 |
| commit | edc85fb55f8adc30a1416c6c854c89097060fb21 (patch) | |
| tree | daf9701247beee33cdb6af9d0486d1ba9a0932f7 /oox | |
| parent | 86cce1343ca5ed85eece1c9d065f9f861d57f9d9 (diff) | |
clang-tidy performance-unnecessary-copy-init in idl..reportdesign
Change-Id: I4b2eda375bbfe1ba35a45168515d885935adcb76
Reviewed-on: https://gerrit.libreoffice.org/62217
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'oox')
| -rw-r--r-- | oox/source/drawingml/diagram/layoutatomvisitors.cxx | 2 | ||||
| -rw-r--r-- | oox/source/export/vmlexport.cxx | 2 | ||||
| -rw-r--r-- | oox/source/ppt/presentationfragmenthandler.cxx | 2 | ||||
| -rw-r--r-- | oox/source/vml/vmlshapecontext.cxx | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/oox/source/drawingml/diagram/layoutatomvisitors.cxx b/oox/source/drawingml/diagram/layoutatomvisitors.cxx index bf8747f0995d..b85b5228407d 100644 --- a/oox/source/drawingml/diagram/layoutatomvisitors.cxx +++ b/oox/source/drawingml/diagram/layoutatomvisitors.cxx @@ -220,7 +220,7 @@ void ShapeTemplateVisitor::visit(ShapeAtom& rAtom) return; } - ShapePtr pCurrShape(rAtom.getShapeTemplate()); + const ShapePtr& pCurrShape(rAtom.getShapeTemplate()); // TODO(F3): cloned shape shares all properties by reference, // don't change them! diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx index ed7b6fb11d3a..0ec745e69d45 100644 --- a/oox/source/export/vmlexport.cxx +++ b/oox/source/export/vmlexport.cxx @@ -666,7 +666,7 @@ void VMLExport::Commit( EscherPropertyContainer& rProps, const tools::Rectangle& XFastAttributeListRef(pAttrListSignatureLine)); // Get signature line graphic - const uno::Reference<graphic::XGraphic> xGraphic + const uno::Reference<graphic::XGraphic>& xGraphic = pSdrGrafObj->getSignatureLineUnsignedGraphic(); Graphic aGraphic(xGraphic); diff --git a/oox/source/ppt/presentationfragmenthandler.cxx b/oox/source/ppt/presentationfragmenthandler.cxx index bbf725620b76..f2477b2cef6e 100644 --- a/oox/source/ppt/presentationfragmenthandler.cxx +++ b/oox/source/ppt/presentationfragmenthandler.cxx @@ -105,7 +105,7 @@ static void ResolveTextFields( XmlFilterBase const & rFilter ) const oox::core::TextFieldStack& rTextFields = rFilter.getTextFieldStack(); if ( !rTextFields.empty() ) { - Reference< frame::XModel > xModel( rFilter.getModel() ); + const Reference< frame::XModel >& xModel( rFilter.getModel() ); for (auto const& textField : rTextFields) { const OUString sURL = "URL"; diff --git a/oox/source/vml/vmlshapecontext.cxx b/oox/source/vml/vmlshapecontext.cxx index eb78598274c5..f5f4bf884e31 100644 --- a/oox/source/vml/vmlshapecontext.cxx +++ b/oox/source/vml/vmlshapecontext.cxx @@ -71,7 +71,7 @@ OptValue< double > lclDecodeOpacity( const AttributeList& rAttribs, sal_Int32 nT if( oValue.has() ) { - const OUString aString(oValue.get()); + const OUString& aString(oValue.get()); const sal_Int32 nLength(aString.getLength()); if(nLength > 0) |