summaryrefslogtreecommitdiff
path: root/oox
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2016-03-10 11:06:29 +0100
committerStephan Bergmann <sbergman@redhat.com>2016-03-10 11:06:29 +0100
commit3d82b08bcea45408b1998934558e2e28721125df (patch)
tree447ccf69a9248f41ec0ea323d018f3ac9f83f6e7 /oox
parent68d200f490a7a21c365bf43c710c46a87f84483d (diff)
These tests can just derive from plain CppUnit::TestFixture
...and then no longer need to override any base class setUp/tearDown Change-Id: Iaea19dfb341325bb45062d0ac0b5fa1eed0d34e0
Diffstat (limited to 'oox')
-rw-r--r--oox/qa/unit/vba_compression.cxx18
-rw-r--r--oox/qa/unit/vba_encryption.cxx17
2 files changed, 4 insertions, 31 deletions
diff --git a/oox/qa/unit/vba_compression.cxx b/oox/qa/unit/vba_compression.cxx
index 5302c165fc31..6541c8517411 100644
--- a/oox/qa/unit/vba_compression.cxx
+++ b/oox/qa/unit/vba_compression.cxx
@@ -7,17 +7,16 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include <unotest/bootstrapfixturebase.hxx>
-
#include <cppunit/plugin/TestPlugIn.h>
#include <cppunit/extensions/HelperMacros.h>
#include <cppunit/TestFixture.h>
#include <oox/ole/vbaexport.hxx>
#include <tools/stream.hxx>
+#include <unotest/directories.hxx>
#include <algorithm>
-class TestVbaCompression : public test::BootstrapFixtureBase
+class TestVbaCompression : public CppUnit::TestFixture
{
public:
@@ -42,10 +41,6 @@ public:
// section 3.2.3
void testSpec323();
- // avoid the BootstrapFixtureBase::setUp and tearDown
- virtual void setUp() override;
- virtual void tearDown() override;
-
CPPUNIT_TEST_SUITE(TestVbaCompression);
CPPUNIT_TEST(testSimple1);
CPPUNIT_TEST(testSimple2);
@@ -57,6 +52,7 @@ public:
CPPUNIT_TEST_SUITE_END();
private:
+ test::Directories m_directories;
};
namespace {
@@ -237,14 +233,6 @@ void TestVbaCompression::testSpec323()
}
}
-void TestVbaCompression::setUp()
-{
-}
-
-void TestVbaCompression::tearDown()
-{
-}
-
CPPUNIT_TEST_SUITE_REGISTRATION(TestVbaCompression);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/oox/qa/unit/vba_encryption.cxx b/oox/qa/unit/vba_encryption.cxx
index 0e3c5abd806d..37dfeff636f4 100644
--- a/oox/qa/unit/vba_encryption.cxx
+++ b/oox/qa/unit/vba_encryption.cxx
@@ -7,8 +7,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include <unotest/bootstrapfixturebase.hxx>
-
#include <cppunit/plugin/TestPlugIn.h>
#include <cppunit/extensions/HelperMacros.h>
#include <cppunit/TestFixture.h>
@@ -16,7 +14,7 @@
#include <oox/ole/vbaexport.hxx>
#include <algorithm>
-class TestVbaEncryption : public test::BootstrapFixtureBase
+class TestVbaEncryption : public CppUnit::TestFixture
{
public:
@@ -29,17 +27,11 @@ public:
void testProjKey1();
- // avoid the BootstrapFixtureBase::setUp and tearDown
- virtual void setUp() override;
- virtual void tearDown() override;
-
CPPUNIT_TEST_SUITE(TestVbaEncryption);
// CPPUNIT_TEST(testSimple1);
// CPPUNIT_TEST(testSimple2);
CPPUNIT_TEST(testProjKey1);
CPPUNIT_TEST_SUITE_END();
-
-private:
};
#if 0
@@ -86,13 +78,6 @@ void TestVbaEncryption::testProjKey1()
CPPUNIT_ASSERT_EQUAL((int)0xdf, (int)nProjKey);
}
-void TestVbaEncryption::setUp()
-{
-}
-void TestVbaEncryption::tearDown()
-{
-}
-
CPPUNIT_TEST_SUITE_REGISTRATION(TestVbaEncryption);
CPPUNIT_PLUGIN_IMPLEMENT();