diff options
| author | Aron Budea <aron.budea@collabora.com> | 2018-09-03 02:42:44 +0200 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2018-09-10 22:57:59 +0200 |
| commit | ff1500df0ff350caa091d042a9db4ab8696d4918 (patch) | |
| tree | c6b5f5ee30e0c38f6531b0aff1ce48293a73d520 /oox | |
| parent | 3f2def73c4e7884fb008aeef81573931c79a7eb6 (diff) | |
tdf#108691, tdf#119639 Don't print hidden objects in XLS(X)
In Excel hidden drawing objects aren't printed. When not
hidden, printing is controlled by a separate 'Print object'
setting.
Only rely visibility setting for now, but properly:
visible means also printed, hidden means not printed.
Ie. import visible property also as printable, and only
output visible property in XLS(X) formats.
For the future, in XLSX format printability is controlled by
attribute 'fPrintsWithSheet' of element 'clientData', don't
know about XLS, there fUsefPrint/fPrint bits don't appear to
be used anymore (see note in tdf#119639).
Reviewed-on: https://gerrit.libreoffice.org/59915
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit b38065ea941375bf4f78f13314e84f4a875545d9)
Change-Id: I728107b30056f7bf073f2fefddece1bef1eb2e7a
Reviewed-on: https://gerrit.libreoffice.org/60275
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Diffstat (limited to 'oox')
| -rw-r--r-- | oox/source/drawingml/shape.cxx | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx index 1d73cdaa38f6..92aa4ce059b9 100644 --- a/oox/source/drawingml/shape.cxx +++ b/oox/source/drawingml/shape.cxx @@ -855,6 +855,9 @@ Reference< XShape > const & Shape::createAndInsert( SAL_INFO("oox.drawingml", "Shape::createAndInsert: invisible shape with id='" << msId << "'"); const OUString sVisible( "Visible" ); xSet->setPropertyValue( sVisible, Any( false ) ); + // In Excel hidden means not printed, let's use visibility for now until that's handled separately + const OUString sPrintable( "Printable" ); + xSet->setPropertyValue( sPrintable, Any( false ) ); } ActionLockGuard const alg(mxShape); |