diff options
author | Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> | 2024-07-01 23:38:59 +0200 |
---|---|---|
committer | Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> | 2024-07-04 07:32:54 +0200 |
commit | 2dfcc67fbc80892d136a11322e68d24ed0511171 (patch) | |
tree | 2a919cc151b8525eb3741802db2d8246a4ee6fb1 /oox | |
parent | 9df3294ed8d3224910dc182eca1650ff637b9e22 (diff) |
Fix TODO
Change-Id: I77b4609d796978fefab1c60034310f890e3b973e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169845
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Tested-by: Jenkins
Diffstat (limited to 'oox')
-rw-r--r-- | oox/source/ppt/comments.cxx | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/oox/source/ppt/comments.cxx b/oox/source/ppt/comments.cxx index b85d95b4a692..7082649dd9a7 100644 --- a/oox/source/ppt/comments.cxx +++ b/oox/source/ppt/comments.cxx @@ -20,14 +20,13 @@ void CommentAuthorList::setValues(const CommentAuthorList& list) { for (auto const& author : list.cmAuthorLst) { - CommentAuthor temp; - // TODO JNA : why not doing push_back at the end instead of using back()? - cmAuthorLst.push_back(temp); - cmAuthorLst.back().clrIdx = author.clrIdx; - cmAuthorLst.back().id = author.id; - cmAuthorLst.back().initials = author.initials; - cmAuthorLst.back().lastIdx = author.lastIdx; - cmAuthorLst.back().name = author.name; + CommentAuthor commentAuthor; + commentAuthor.clrIdx = author.clrIdx; + commentAuthor.id = author.id; + commentAuthor.initials = author.initials; + commentAuthor.lastIdx = author.lastIdx; + commentAuthor.name = author.name; + cmAuthorLst.push_back(commentAuthor); } } |