summaryrefslogtreecommitdiff
path: root/package/source
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-10-31 14:15:25 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-11-01 07:14:39 +0100
commitee1d6af9b73256e13975ec4e95aff6d69a00fed9 (patch)
tree3cbc356963562fe04829d49c37c38e8aeab84314 /package/source
parent5d618d73ed8669a75b7b01774f6ea51e99e5b740 (diff)
loplugin:finalclasses in package
Change-Id: I020ea1f3bea5c3deab05b9a2154102548c7622cf Reviewed-on: https://gerrit.libreoffice.org/44132 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'package/source')
-rw-r--r--package/source/manifest/ManifestImport.hxx4
-rw-r--r--package/source/xstor/oseekinstream.hxx3
-rw-r--r--package/source/xstor/selfterminatefilestream.hxx3
-rw-r--r--package/source/zipapi/MemoryByteGrabber.hxx3
-rw-r--r--package/source/zipapi/XUnbufferedStream.hxx3
-rw-r--r--package/source/zippackage/ZipPackageFolderEnumeration.hxx3
-rw-r--r--package/source/zippackage/ZipPackageSink.hxx3
-rw-r--r--package/source/zippackage/wrapstreamforshare.hxx3
8 files changed, 9 insertions, 16 deletions
diff --git a/package/source/manifest/ManifestImport.hxx b/package/source/manifest/ManifestImport.hxx
index 9eac12e61a43..86cafa4ef1d7 100644
--- a/package/source/manifest/ManifestImport.hxx
+++ b/package/source/manifest/ManifestImport.hxx
@@ -48,9 +48,8 @@ struct ManifestScopeEntry
typedef ::std::vector< ManifestScopeEntry > ManifestStack;
-class ManifestImport : public cppu::WeakImplHelper < css::xml::sax::XDocumentHandler >
+class ManifestImport final : public cppu::WeakImplHelper < css::xml::sax::XDocumentHandler >
{
-protected:
std::vector< css::beans::PropertyValue > aSequence;
ManifestStack aStack;
bool bIgnoreEncryptData;
@@ -125,6 +124,7 @@ public:
virtual void SAL_CALL ignorableWhitespace( const OUString& aWhitespaces ) override;
virtual void SAL_CALL processingInstruction( const OUString& aTarget, const OUString& aData ) override;
virtual void SAL_CALL setDocumentLocator( const css::uno::Reference< css::xml::sax::XLocator >& xLocator ) override;
+
private:
/// @throws css::uno::RuntimeException
void doFileEntry(StringHashMap &rConvertedAttribs);
diff --git a/package/source/xstor/oseekinstream.hxx b/package/source/xstor/oseekinstream.hxx
index b8de87c29579..673e3a04742c 100644
--- a/package/source/xstor/oseekinstream.hxx
+++ b/package/source/xstor/oseekinstream.hxx
@@ -24,10 +24,9 @@
#include "ocompinstream.hxx"
-class OInputSeekStream : public OInputCompStream
+class OInputSeekStream final : public OInputCompStream
, public css::io::XSeekable
{
-protected:
css::uno::Reference < css::io::XSeekable > m_xSeekable;
public:
diff --git a/package/source/xstor/selfterminatefilestream.hxx b/package/source/xstor/selfterminatefilestream.hxx
index 661cbcf2fc68..4aecd337d9eb 100644
--- a/package/source/xstor/selfterminatefilestream.hxx
+++ b/package/source/xstor/selfterminatefilestream.hxx
@@ -27,10 +27,9 @@
struct OWriteStream_Impl;
-class OSelfTerminateFileStream : public cppu::WeakImplHelper< css::io::XInputStream,
+class OSelfTerminateFileStream final : public cppu::WeakImplHelper< css::io::XInputStream,
css::io::XSeekable >
{
-protected:
css::uno::Reference< css::ucb::XSimpleFileAccess3 > m_xFileAccess;
OUString m_aURL;
diff --git a/package/source/zipapi/MemoryByteGrabber.hxx b/package/source/zipapi/MemoryByteGrabber.hxx
index c5436c2a34f0..c09b4cfb20b0 100644
--- a/package/source/zipapi/MemoryByteGrabber.hxx
+++ b/package/source/zipapi/MemoryByteGrabber.hxx
@@ -23,9 +23,8 @@
#include <com/sun/star/io/XSeekable.hpp>
#include <string.h>
-class MemoryByteGrabber
+class MemoryByteGrabber final
{
-protected:
const css::uno::Sequence < sal_Int8 > maBuffer;
const sal_Int8 *mpBuffer;
sal_Int32 mnCurrent, mnEnd;
diff --git a/package/source/zipapi/XUnbufferedStream.hxx b/package/source/zipapi/XUnbufferedStream.hxx
index c9d44ebde07e..47bb3ce583be 100644
--- a/package/source/zipapi/XUnbufferedStream.hxx
+++ b/package/source/zipapi/XUnbufferedStream.hxx
@@ -41,12 +41,11 @@ namespace com { namespace sun { namespace star { namespace uno {
#define UNBUFF_STREAM_WRAPPEDRAW 2
class EncryptionData;
-class XUnbufferedStream : public cppu::WeakImplHelper
+class XUnbufferedStream final : public cppu::WeakImplHelper
<
css::io::XInputStream
>
{
-protected:
rtl::Reference<comphelper::RefCountedMutex> maMutexHolder;
css::uno::Reference < css::io::XInputStream > mxZipStream;
diff --git a/package/source/zippackage/ZipPackageFolderEnumeration.hxx b/package/source/zippackage/ZipPackageFolderEnumeration.hxx
index d4f8b8b1cdba..e5d33b1d5ce5 100644
--- a/package/source/zippackage/ZipPackageFolderEnumeration.hxx
+++ b/package/source/zippackage/ZipPackageFolderEnumeration.hxx
@@ -24,13 +24,12 @@
#include <com/sun/star/lang/XServiceInfo.hpp>
#include <HashMaps.hxx>
-class ZipPackageFolderEnumeration : public cppu::WeakImplHelper
+class ZipPackageFolderEnumeration final : public cppu::WeakImplHelper
<
css::container::XEnumeration,
css::lang::XServiceInfo
>
{
-protected:
ContentHash& rContents;
ContentHash::const_iterator aIterator;
public:
diff --git a/package/source/zippackage/ZipPackageSink.hxx b/package/source/zippackage/ZipPackageSink.hxx
index e7e4cdbef192..d0ba9a6bedae 100644
--- a/package/source/zippackage/ZipPackageSink.hxx
+++ b/package/source/zippackage/ZipPackageSink.hxx
@@ -22,9 +22,8 @@
#include <com/sun/star/io/XActiveDataSink.hpp>
#include <cppuhelper/implbase.hxx>
-class ZipPackageSink : public ::cppu::WeakImplHelper< css::io::XActiveDataSink >
+class ZipPackageSink final : public ::cppu::WeakImplHelper< css::io::XActiveDataSink >
{
-protected:
css::uno::Reference < css::io::XInputStream > xStream;
public:
ZipPackageSink();
diff --git a/package/source/zippackage/wrapstreamforshare.hxx b/package/source/zippackage/wrapstreamforshare.hxx
index 649284a69bc7..238483b769f7 100644
--- a/package/source/zippackage/wrapstreamforshare.hxx
+++ b/package/source/zippackage/wrapstreamforshare.hxx
@@ -26,10 +26,9 @@
#include <cppuhelper/implbase.hxx>
#include <rtl/ref.hxx>
-class WrapStreamForShare : public cppu::WeakImplHelper < css::io::XInputStream
+class WrapStreamForShare final : public cppu::WeakImplHelper < css::io::XInputStream
, css::io::XSeekable >
{
-protected:
rtl::Reference< comphelper::RefCountedMutex > m_xMutex;
css::uno::Reference < css::io::XInputStream > m_xInStream;
css::uno::Reference < css::io::XSeekable > m_xSeekable;