diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-07 16:07:31 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-08 08:45:51 +0200 |
| commit | 09978dd1fc18ce1ae707bc9e4ea1d2745ff07b61 (patch) | |
| tree | 7d532a53e81dbbf7b070e9edb223c2935b61e783 /package | |
| parent | 7764ae70b04058a64a3999529e98d1115ba59d1c (diff) | |
clang-tidy bugprone-unused-return-value
In
OStorage::openEncryptedStream
the lines were marked with a TODO until the TODO comment was removed in
commit 8083b46285fefc4af751e1b00d20b40bea196ea8
Date: Tue Jun 16 16:15:54 2009 +0000
CWS-TOOLING: integrate CWS fwk103
Since no-one has "fixed" this intended functionality by now,
I just removed it.
The lines in unoidl/ were introduced by
commit 12353c73868d26690aa4ac008ef5e9f2db8bc12c
Date: Fri Mar 1 23:23:50 2013 +0100
WIP: Experimental new binary type.rdb format
I assume that not throwing these was just an oversight.
Change-Id: I26fbcce267f2cc1154a30b8259176f59611dfbd8
Reviewed-on: https://gerrit.libreoffice.org/60161
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'package')
| -rw-r--r-- | package/source/xstor/xstorage.cxx | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/package/source/xstor/xstorage.cxx b/package/source/xstor/xstorage.cxx index 3488e5726150..adc4a3a2d661 100644 --- a/package/source/xstor/xstorage.cxx +++ b/package/source/xstor/xstorage.cxx @@ -3142,9 +3142,6 @@ uno::Reference< io::XStream > SAL_CALL OStorage::openEncryptedStream( throw lang::DisposedException( THROW_WHERE ); } - if ( m_pData->m_nStorageType != embed::StorageFormats::PACKAGE ) - packages::NoEncryptionException(); - if ( ( nOpenMode & embed::ElementModes::WRITE ) && m_pData->m_bReadOnlyWrap ) throw io::IOException( THROW_WHERE ); // TODO: access denied @@ -3231,9 +3228,6 @@ uno::Reference< io::XStream > SAL_CALL OStorage::cloneEncryptedStream( throw lang::DisposedException( THROW_WHERE ); } - if ( m_pData->m_nStorageType != embed::StorageFormats::PACKAGE ) - packages::NoEncryptionException(); - if ( !aEncryptionData.getLength() ) throw lang::IllegalArgumentException( THROW_WHERE, uno::Reference< uno::XInterface >(), 2 ); |