diff options
| author | Michael Stahl <michael.stahl@allotropia.de> | 2022-05-22 14:50:55 +0200 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2022-05-25 11:47:02 +0200 |
| commit | bc076c09f3693ee3790f294bf9be4827d6f9c4a6 (patch) | |
| tree | 5693ae8929ba4d19216594549c829856f99a5f38 /postprocess | |
| parent | e2f3bc3a98cd65183b5d0580c0fb742240fc376a (diff) | |
starmath: fix real use-after-free detected by GCC 12
In file included from starmath/inc/mathml/iterator.hxx:12,
from starmath/source/mathml/iterator.cxx:10:
In member function ‘SmMlElement* SmMlElement::getParentElement()’,
inlined from ‘void mathml::SmMlIteratorBottomToTop(SmMlElement*, runType, void*) [with runType = void (*)(SmMlElement*, void*)]’ at starmath/inc/mathml/iterator.hxx:43:39,
inlined from ‘void mathml::SmMlIteratorFree(SmMlElement*)’ at starmath/source/mathml/iterator.cxx:57:28:
starmath/inc/mathml/element.hxx:263:46: error: pointer ‘pCurrent’ used after ‘void operator delete(void*, std::size_t)’ [-Werror=use-after-free]
263 | SmMlElement* getParentElement() { return m_aParentElement; };
| ^~~~~~~~~~~~~~~~
In function ‘void mathml::deleteElement(SmMlElement*, void*)’,
inlined from ‘void mathml::deleteElement(SmMlElement*, void*)’ at starmath/source/mathml/iterator.cxx:19:20,
inlined from ‘void mathml::SmMlIteratorBottomToTop(SmMlElement*, runType, void*) [with runType = void (*)(SmMlElement*, void*)]’ at starmath/inc/mathml/iterator.hxx:65:21,
inlined from ‘void mathml::SmMlIteratorFree(SmMlElement*)’ at starmath/source/mathml/iterator.cxx:57:28:
starmath/source/mathml/iterator.cxx:19:77: note: call to ‘void operator delete(void*, std::size_t)’ here
19 | static inline void deleteElement(SmMlElement* aSmMlElement, void*) { delete aSmMlElement; }
| ^~~~~~~~~~~~
Change-Id: I09acfe3f7e90bd7f919cfba161f72bdd7a8da70a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134742
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 32c43ee75c094ffe3c34f7a713aa252479515ad0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134775
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'postprocess')
0 files changed, 0 insertions, 0 deletions