summaryrefslogtreecommitdiff
path: root/pyuno
diff options
context:
space:
mode:
authorMichael Stahl <Michael.Stahl@cib.de>2020-01-09 12:41:06 +0100
committerThorsten Behrens <Thorsten.Behrens@CIB.de>2020-01-15 09:00:37 +0100
commitc82311303bd26bffb74159b2d1294630830a615a (patch)
tree2743f7482b282b7fec0c0fe492b6d78fa9b75492 /pyuno
parentd8dc16940b71acb0f4d3eda0a716dd4c37f00d37 (diff)
pyuno: remove racy debug check
The use-after-free is easier to trigger than expected; i don't see how it's possible to check this without a race. Change-Id: I4afb7066d1bf6b34f4f56aa0f51be0643ae40a66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86481 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 777ae8101e23a31bdf806c1d09f0c849e47bb8ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86486 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Diffstat (limited to 'pyuno')
-rw-r--r--pyuno/source/module/pyuno_runtime.cxx7
1 files changed, 0 insertions, 7 deletions
diff --git a/pyuno/source/module/pyuno_runtime.cxx b/pyuno/source/module/pyuno_runtime.cxx
index e0987cd63cd7..6cee574c77f5 100644
--- a/pyuno/source/module/pyuno_runtime.cxx
+++ b/pyuno/source/module/pyuno_runtime.cxx
@@ -978,13 +978,6 @@ PyThreadAttach::PyThreadAttach( PyInterpreterState *interp)
{
// note: *may* be called recursively, with PyThreadDetach between - in
// that case, don't create *new* PyThreadState but reuse!
-#ifndef NDEBUG
-#if PY_MAJOR_VERSION == 3 && PY_MINOR_VERSION >= 7
- PyThreadState const*const current = _PyThreadState_UncheckedGet();
- // dereference isn't safe but let's hope it's tolerable for debugging purpose
- assert((current == nullptr || current->thread_id != PyThread_get_thread_ident()) && "recursive PyThreadAttach");
-#endif
-#endif
tstate = PyGILState_GetThisThreadState(); // from TLS, possibly detached
if (!tstate)
{