java: make fields final where possible

found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec

8 files changed, 19 insertions, 19 deletions

diff --git a/qadevOOo/runner/convwatch/BorderRemover.java b/qadevOOo/runner/convwatch/BorderRemover.java
index af7ee46a99bc..dbd933b3ad35 100644
--- a/qadevOOo/runner/convwatch/BorderRemover.java
+++ b/qadevOOo/runner/convwatch/BorderRemover.java
@@ -26,10 +26,10 @@ import java.lang.reflect.Method;
 
 class Rect
 {
-    private int x;
-    private int y;
-    private int w;
-    private int h;
+    private final int x;
+    private final int y;
+    private final int w;
+    private final int h;
 
     public Rect(int _x, int _y, int _w, int _h)
         {
diff --git a/qadevOOo/runner/convwatch/DBHelper.java b/qadevOOo/runner/convwatch/DBHelper.java
index 03128eafa0ba..dc76af3ad9d2 100644
--- a/qadevOOo/runner/convwatch/DBHelper.java
+++ b/qadevOOo/runner/convwatch/DBHelper.java
@@ -49,8 +49,8 @@ class ShareConnection
 
     class MySQLThread extends Thread
     {
-        private Connection m_aCon = null;
-        private String m_sSQL;
+        private final Connection m_aCon;
+        private final String m_sSQL;
         public MySQLThread(Connection _aCon, String _sSQL)
             {
                 m_aCon = _aCon;
diff --git a/qadevOOo/runner/convwatch/DirectoryHelper.java b/qadevOOo/runner/convwatch/DirectoryHelper.java
index 26cd831a7042..9d322c52fb5e 100644
--- a/qadevOOo/runner/convwatch/DirectoryHelper.java
+++ b/qadevOOo/runner/convwatch/DirectoryHelper.java
@@ -27,7 +27,7 @@ import java.util.ArrayList;
  */
 public class DirectoryHelper
 {
-    private ArrayList<String> m_aFileList = new ArrayList<String>();
+    private final ArrayList<String> m_aFileList = new ArrayList<String>();
     private boolean m_bRecursiveIsAllowed = true;
 
     private void setRecursiveIsAllowed(boolean _bValue)
diff --git a/qadevOOo/runner/convwatch/GraphicalTestArguments.java b/qadevOOo/runner/convwatch/GraphicalTestArguments.java
index e4dd7c0b6028..d5cc3c4f5800 100644
--- a/qadevOOo/runner/convwatch/GraphicalTestArguments.java
+++ b/qadevOOo/runner/convwatch/GraphicalTestArguments.java
@@ -81,15 +81,15 @@ public class GraphicalTestArguments
 
     private boolean m_bIncludeSubdirectories;
 
-    private TestParameters m_aCurrentParams;
+    private final TestParameters m_aCurrentParams;
 
-    private int m_nMaxPages = 0;                           // default is 0 (print all pages)
-    private String m_sOnlyPage = "";                       // default is "", there is no page which we want to print only.
+    private final int m_nMaxPages;                           // default is 0 (print all pages)
+    private final String m_sOnlyPage;                       // default is "", there is no page which we want to print only.
 
     private int m_nResolutionInDPI = 0;
 
     private boolean m_bStoreFile = true;
-    private boolean m_bResuseOffice = false;
+    private final boolean m_bResuseOffice;
 
 
 
diff --git a/qadevOOo/runner/convwatch/ImageHelper.java b/qadevOOo/runner/convwatch/ImageHelper.java
index 2644223e2ebb..5723c3fc85fb 100644
--- a/qadevOOo/runner/convwatch/ImageHelper.java
+++ b/qadevOOo/runner/convwatch/ImageHelper.java
@@ -26,9 +26,9 @@ import java.lang.reflect.Method;
 
 class ImageHelper
 {
-    private Image m_aImage;
-    private int[] m_aPixels;
-    private int m_w = 0;
+    private final Image m_aImage;
+    private final int[] m_aPixels;
+    private final int m_w;
 
 
     private ImageHelper(Image _aImage)
diff --git a/qadevOOo/runner/convwatch/IniFile.java b/qadevOOo/runner/convwatch/IniFile.java
index 8e1747bf1308..08e9629883ad 100644
--- a/qadevOOo/runner/convwatch/IniFile.java
+++ b/qadevOOo/runner/convwatch/IniFile.java
@@ -32,9 +32,9 @@ class IniFile
      * internal representation of the ini file content.
      * Problem, if ini file changed why other write something difference, we don't realise this.
      */
-    private String m_sFilename;
-    private ArrayList<String> m_aList;
-    private boolean m_bListContainUnsavedChanges = false;
+    private final String m_sFilename;
+    private final ArrayList<String> m_aList;
+    private final boolean m_bListContainUnsavedChanges = false;
 
     /**
        open a ini file by its name
diff --git a/qadevOOo/runner/convwatch/PRNCompare.java b/qadevOOo/runner/convwatch/PRNCompare.java
index bc542752cc2b..1dac4c8eed97 100644
--- a/qadevOOo/runner/convwatch/PRNCompare.java
+++ b/qadevOOo/runner/convwatch/PRNCompare.java
@@ -30,7 +30,7 @@ import java.util.ArrayList;
 
 public class PRNCompare
 {
-    private String fs;
+    private final String fs;
 
     public PRNCompare()
         {
diff --git a/qadevOOo/runner/convwatch/TriState.java b/qadevOOo/runner/convwatch/TriState.java
index c72e06c2b913..ec9dfd194336 100644
--- a/qadevOOo/runner/convwatch/TriState.java
+++ b/qadevOOo/runner/convwatch/TriState.java
@@ -24,7 +24,7 @@ public class TriState
     public static final TriState FALSE = new TriState(0);
     public static final TriState UNSET = new TriState(-1);
 
-    private int m_nValue;
+    private final int m_nValue;
 
     /**
        Allocates a <code>TriState</code> object representing the