summaryrefslogtreecommitdiff
path: root/qadevOOo/runner/graphical
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2014-08-13 10:19:51 +0200
committerNoel Grandin <noel@peralex.com>2014-08-20 10:35:53 +0200
commit60f152caeee38579433a31dd3a98e91dc3d23ff6 (patch)
tree15ba69f938e09bb173ca7de2e1b21b62e740ea40 /qadevOOo/runner/graphical
parent2922a967a1da5f9c0a07b5390906307d0ae6fe48 (diff)
java: avoid unnecessary comparisons in boolean expressions
i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
Diffstat (limited to 'qadevOOo/runner/graphical')
-rw-r--r--qadevOOo/runner/graphical/DirectoryHelper.java2
-rw-r--r--qadevOOo/runner/graphical/FileHelper.java2
-rw-r--r--qadevOOo/runner/graphical/IniFile.java2
-rw-r--r--qadevOOo/runner/graphical/MSOfficePostscriptCreator.java8
-rw-r--r--qadevOOo/runner/graphical/OpenOfficePostscriptCreator.java4
-rw-r--r--qadevOOo/runner/graphical/ParameterHelper.java2
6 files changed, 10 insertions, 10 deletions
diff --git a/qadevOOo/runner/graphical/DirectoryHelper.java b/qadevOOo/runner/graphical/DirectoryHelper.java
index 2acb91154ae8..6ba7e6cdfdd6 100644
--- a/qadevOOo/runner/graphical/DirectoryHelper.java
+++ b/qadevOOo/runner/graphical/DirectoryHelper.java
@@ -99,7 +99,7 @@ public class DirectoryHelper
{
if ( aDirEntries[ i ].isDirectory() )
{
- if (m_bRecursiveIsAllowed == true)
+ if (m_bRecursiveIsAllowed)
{
// Recursive call for the new directory
traverse_impl( aDirEntries[ i ].getAbsolutePath(), _aFileFilter );
diff --git a/qadevOOo/runner/graphical/FileHelper.java b/qadevOOo/runner/graphical/FileHelper.java
index 78551e6f446b..ac4780021234 100644
--- a/qadevOOo/runner/graphical/FileHelper.java
+++ b/qadevOOo/runner/graphical/FileHelper.java
@@ -263,7 +263,7 @@ public class FileHelper
File aFile = new File(sName);
if (aFile.exists())
{
- if (m_bDebugTextShown == false)
+ if (!m_bDebugTextShown)
{
GlobalLogWriter.println("Found file: " + sName);
GlobalLogWriter.println("Activate debug mode.");
diff --git a/qadevOOo/runner/graphical/IniFile.java b/qadevOOo/runner/graphical/IniFile.java
index 2e2da218580e..c94cfb8b4fa4 100644
--- a/qadevOOo/runner/graphical/IniFile.java
+++ b/qadevOOo/runner/graphical/IniFile.java
@@ -359,7 +359,7 @@ public class IniFile implements Enumeration<String>
// TODO: make private
private void store()
{
- if (m_bListContainUnsavedChanges == false)
+ if (!m_bListContainUnsavedChanges)
{
// nothing has changed, so no need to store
return;
diff --git a/qadevOOo/runner/graphical/MSOfficePostscriptCreator.java b/qadevOOo/runner/graphical/MSOfficePostscriptCreator.java
index 1d3081af6794..aeebf6927588 100644
--- a/qadevOOo/runner/graphical/MSOfficePostscriptCreator.java
+++ b/qadevOOo/runner/graphical/MSOfficePostscriptCreator.java
@@ -211,7 +211,7 @@ public class MSOfficePostscriptCreator implements IOffice
throw new WrongSuffixException("No Mircosoft Office document format found.");
}
- if (aStartCommand.isEmpty() == false)
+ if (!aStartCommand.isEmpty())
{
String sPrinterName = m_sPrinterName;
if (sPrinterName == null)
@@ -290,7 +290,7 @@ public class MSOfficePostscriptCreator implements IOffice
String sPrintViaWord = "printViaWord.pl";
ArrayList<String> aList = searchLocalFile(sPrintViaWord);
- if (aList.isEmpty() == false)
+ if (!aList.isEmpty())
{
return aList;
}
@@ -421,7 +421,7 @@ public class MSOfficePostscriptCreator implements IOffice
String sPrintViaExcel = "printViaExcel.pl";
ArrayList<String> aList = searchLocalFile(sPrintViaExcel);
- if (aList.isEmpty() == false)
+ if (!aList.isEmpty())
{
return aList;
}
@@ -519,7 +519,7 @@ public class MSOfficePostscriptCreator implements IOffice
String sPrintViaPowerPoint = "printViaPowerPoint.pl";
ArrayList<String> aList = searchLocalFile(sPrintViaPowerPoint);
- if (aList.isEmpty() == false)
+ if (!aList.isEmpty())
{
return aList;
}
diff --git a/qadevOOo/runner/graphical/OpenOfficePostscriptCreator.java b/qadevOOo/runner/graphical/OpenOfficePostscriptCreator.java
index bca3b38efb15..7dc60e8cac71 100644
--- a/qadevOOo/runner/graphical/OpenOfficePostscriptCreator.java
+++ b/qadevOOo/runner/graphical/OpenOfficePostscriptCreator.java
@@ -490,7 +490,7 @@ public class OpenOfficePostscriptCreator implements IOffice
// generate pages string
- if (_aGTA.printAllPages() == false)
+ if (!_aGTA.printAllPages())
{
String sPages = "";
if (_aGTA.getMaxPages() > 0)
@@ -561,7 +561,7 @@ public class OpenOfficePostscriptCreator implements IOffice
bBack = false;
}
- if (bFailed == true)
+ if (bFailed)
{
GlobalLogWriter.println("convwatch.OfficePrint: FAILED");
}
diff --git a/qadevOOo/runner/graphical/ParameterHelper.java b/qadevOOo/runner/graphical/ParameterHelper.java
index 418c06a6b3d1..042b2ea8b137 100644
--- a/qadevOOo/runner/graphical/ParameterHelper.java
+++ b/qadevOOo/runner/graphical/ParameterHelper.java
@@ -357,7 +357,7 @@ public class ParameterHelper
{
// boolean bCreateSmallPictures = true;
boolean bNoSmallPictures = m_aCurrentParams.getBool( PropertyName.NO_SMALL_PICTURES);
- if (bNoSmallPictures == true)
+ if (bNoSmallPictures)
{
return false;
}