diff options
author | Noel Grandin <noel@peralex.com> | 2013-04-17 15:31:23 +0200 |
---|---|---|
committer | Fridrich Strba <fridrich@documentfoundation.org> | 2013-04-22 14:38:25 +0000 |
commit | 37eee65fbf1ee7ef5c86731594e33b056b6612d2 (patch) | |
tree | 4748b319d8c72af0a8477f9324c2c79362bcf636 /qadevOOo/runner/lib/TestCase.java | |
parent | 30426feff508439f79b2737cba94637d66ee7691 (diff) |
Java cleanup - static fields that should not be static
Somebody appears to have been confused about the purpose of static
in Java.
These are instance fields and should therefore not be static.
Also reduce the visibility of some methods and fields.
Change-Id: I0b5875b6cbd91ee89823e2058b87c1087dc5c92e
Reviewed-on: https://gerrit.libreoffice.org/3555
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Diffstat (limited to 'qadevOOo/runner/lib/TestCase.java')
-rw-r--r-- | qadevOOo/runner/lib/TestCase.java | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/qadevOOo/runner/lib/TestCase.java b/qadevOOo/runner/lib/TestCase.java index 0477ebef7c8c..a4895f13c4ce 100644 --- a/qadevOOo/runner/lib/TestCase.java +++ b/qadevOOo/runner/lib/TestCase.java @@ -19,8 +19,8 @@ package lib; import java.io.PrintWriter; - import lib.TestParameters; + /** * <code>TestCase</code> represent a factory for <code>TestEnvironment</code>s * creation and disposing for a given implementation object. The @@ -49,9 +49,7 @@ public abstract class TestCase { /** * Specifies the PrintWriter to log information. */ - public PrintWriter log; - - //public static TestCase tCase; + protected PrintWriter log; /** * Sets the log to write information during testing. @@ -66,7 +64,7 @@ public abstract class TestCase { * * @param tParam test parameters. */ - public void initializeTestCase( TestParameters tParam ) { + public final void initializeTestCase( TestParameters tParam ) { initialize( tParam, log ); } @@ -89,7 +87,7 @@ public abstract class TestCase { * * @param tParam test parameters */ - public void cleanupTestCase( TestParameters tParam ) { + public final void cleanupTestCase( TestParameters tParam ) { cleanup( tParam, log ); } |