diff options
author | Noel Grandin <noel@peralex.com> | 2015-06-09 08:52:12 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2015-06-09 11:34:31 +0200 |
commit | 2a0dda3dfb37f0cb69842f7d569c253d82f53713 (patch) | |
tree | 7a762c2fa22651cefb68021250a3fad8811e0f06 /qadevOOo/tests/java/mod/_sc/ScRecentFunctionsObj.java | |
parent | 60f8dd78fa3f19e8bed867f7f5926fcf9a8d8e67 (diff) |
remove some unnecessary exception wrapping in the Java tests
Modify createTestEnvironment so that it throws Exception. This
is appropriate for unit testing.
The wrapping adds no value and the calling method already has
a catch(Exception) to handle anything.
Change-Id: I430a414f63d2cbfc3b65ecfde0285509265e5192
Diffstat (limited to 'qadevOOo/tests/java/mod/_sc/ScRecentFunctionsObj.java')
-rw-r--r-- | qadevOOo/tests/java/mod/_sc/ScRecentFunctionsObj.java | 25 |
1 files changed, 10 insertions, 15 deletions
diff --git a/qadevOOo/tests/java/mod/_sc/ScRecentFunctionsObj.java b/qadevOOo/tests/java/mod/_sc/ScRecentFunctionsObj.java index b104297711d8..01567c353220 100644 --- a/qadevOOo/tests/java/mod/_sc/ScRecentFunctionsObj.java +++ b/qadevOOo/tests/java/mod/_sc/ScRecentFunctionsObj.java @@ -87,7 +87,7 @@ public class ScRecentFunctionsObj extends TestCase { */ @Override public synchronized TestEnvironment createTestEnvironment( - TestParameters Param, PrintWriter log ) throws StatusException { + TestParameters Param, PrintWriter log ) throws Exception { XInterface oObj = null; XInterface allFunctions = null; @@ -96,20 +96,15 @@ public class ScRecentFunctionsObj extends TestCase { // first we write what we are intend to do to log file log.println( "Creating a test environment" ); - try { - log.println("Getting test object ") ; - XMultiServiceFactory oDocMSF = Param.getMSF(); - oObj = (XInterface)oDocMSF.createInstance( - "com.sun.star.sheet.RecentFunctions"); - allFunctions = (XInterface)oDocMSF.createInstance( - "com.sun.star.sheet.FunctionDescriptions"); - - log.println("Creating object - " + - ((oObj == null) ? "FAILED" : "OK")); - } catch (com.sun.star.uno.Exception e) { - e.printStackTrace(log) ; - throw new StatusException("Couldn't create instance", e); - } + log.println("Getting test object ") ; + XMultiServiceFactory oDocMSF = Param.getMSF(); + oObj = (XInterface)oDocMSF.createInstance( + "com.sun.star.sheet.RecentFunctions"); + allFunctions = (XInterface)oDocMSF.createInstance( + "com.sun.star.sheet.FunctionDescriptions"); + + log.println("Creating object - " + + ((oObj == null) ? "FAILED" : "OK")); TestEnvironment tEnv = new TestEnvironment( oObj ); |