LinkUpdateMode property values must be in the range 0--2 or 0--3

...avoid setting bad values from generic qadevOOo property set tests, and throw
an IllegalArgumentException if bad values do get set.  Found via
-fsanitize=enum.  The TODO about ScLkUpdMode vs. LinkUpdateModes mismatch looks
worrying.

Change-Id: Ibc01845e7e3179dc693fe8c59c1f1ffad5282420

2 files changed, 9 insertions, 3 deletions

diff --git a/qadevOOo/runner/lib/MultiPropertyTest.java b/qadevOOo/runner/lib/MultiPropertyTest.java
index b314ccf8626b..918d5e6f372e 100644
--- a/qadevOOo/runner/lib/MultiPropertyTest.java
+++ b/qadevOOo/runner/lib/MultiPropertyTest.java
@@ -454,7 +454,7 @@ public class MultiPropertyTest extends MultiMethodTest
         protected Object getNewValue(String propName, Object oldValue)
                 throws java.lang.IllegalArgumentException
         {
-            return ValueChanger.changePValue(oldValue);
+            return ValueChanger.changePValue(oldValue, propName);
         }
 
         /**
diff --git a/qadevOOo/runner/util/ValueChanger.java b/qadevOOo/runner/util/ValueChanger.java
index 197de43c81d6..05b52329e0bb 100644
--- a/qadevOOo/runner/util/ValueChanger.java
+++ b/qadevOOo/runner/util/ValueChanger.java
@@ -58,9 +58,15 @@ public class ValueChanger {
             newValue = Long.valueOf(oldlong + 15);
         } else if (oldValue instanceof Short) {
             short n = ((Short) oldValue).shortValue();
-            // css.form.component.{CheckBox,RadioButton} DefaultState properties
-            // must have values in the range 0--2:
             if ("DefaultState".equals(name) && n == 2) {
+                // css.form.component.{CheckBox,RadioButton} DefaultState
+                // properties must have values in the range 0--2:
+                --n;
+            } else if ("LinkUpdateMode".equals(name) && n >= 2) {
+                // css.document.Settings LinkUpdateMode property must have
+                // values in the css.document.LinkUpdateModes range (0--3),
+                // while css.sheet.XGlobalSheetSettings LinkUpdateMode property
+                // must have values in the range 0--2:
                 --n;
             } else {
                 ++n;