diff options
author | Noel Grandin <noel@peralex.com> | 2014-08-08 11:14:08 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2014-08-12 12:16:37 +0200 |
commit | e701b3f732fa7f70cb273183e9ae8dbfd840f5e4 (patch) | |
tree | 8bcf687f10ccd70be0882360d2155378993cef26 /qadevOOo | |
parent | cc4d76145f7b92992b885cdc58b4534e8c024ac5 (diff) |
java: reduce scope, make constants private
found by UCDetector
Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
Diffstat (limited to 'qadevOOo')
-rw-r--r-- | qadevOOo/runner/convwatch/HTMLOutputter.java | 22 | ||||
-rw-r--r-- | qadevOOo/runner/convwatch/StatusHelper.java | 2 | ||||
-rw-r--r-- | qadevOOo/runner/graphical/HTMLResult.java | 8 | ||||
-rw-r--r-- | qadevOOo/runner/graphical/PerformanceContainer.java | 2 | ||||
-rw-r--r-- | qadevOOo/runner/util/DBTools.java | 16 |
5 files changed, 25 insertions, 25 deletions
diff --git a/qadevOOo/runner/convwatch/HTMLOutputter.java b/qadevOOo/runner/convwatch/HTMLOutputter.java index b749169f851a..2dea50fec6e0 100644 --- a/qadevOOo/runner/convwatch/HTMLOutputter.java +++ b/qadevOOo/runner/convwatch/HTMLOutputter.java @@ -77,9 +77,9 @@ public class HTMLOutputter } } - final static String TEST_TABLETITLE = "Test"; - final static String VISUAL_STATUS_TABLETITLE = "Visual status"; - final static String VISUAL_STATUS_MESSAGE_TABLETITLE = "Message"; + private final static String TEST_TABLETITLE = "Test"; + private final static String VISUAL_STATUS_TABLETITLE = "Visual status"; + private final static String VISUAL_STATUS_MESSAGE_TABLETITLE = "Message"; public void indexSection(String _sOfficeInfo) { @@ -196,16 +196,16 @@ public class HTMLOutputter return a.toString(); } - final static String FIRSTGFX_TABLETITLE = "Original print file as jpeg"; - final static String SECONDGFX_TABLETITLE = "New print file as jpeg"; - final static String DIFFER_TABLETITLE = "Difference file"; - final static String STATUS_TABLETITLE = "Status"; - final static String PIXELDIFF_TABLETITLE = "Pixel difference in %"; + private final static String FIRSTGFX_TABLETITLE = "Original print file as jpeg"; + private final static String SECONDGFX_TABLETITLE = "New print file as jpeg"; + private final static String DIFFER_TABLETITLE = "Difference file"; + private final static String STATUS_TABLETITLE = "Status"; + private final static String PIXELDIFF_TABLETITLE = "Pixel difference in %"; - final static String PIXELDIFF_BM_TABLETITLE = "P.diff. in % after remove border"; - final static String DIFFER_BM_TABLETITLE = "Diff file (RB)"; + private final static String PIXELDIFF_BM_TABLETITLE = "P.diff. in % after remove border"; + private final static String DIFFER_BM_TABLETITLE = "Diff file (RB)"; - final static String OK_TABLETITLE = "OK?"; + private final static String OK_TABLETITLE = "OK?"; public void checkSection(String _sDocumentName) { try diff --git a/qadevOOo/runner/convwatch/StatusHelper.java b/qadevOOo/runner/convwatch/StatusHelper.java index 46a8ff38f1cf..bb494508128f 100644 --- a/qadevOOo/runner/convwatch/StatusHelper.java +++ b/qadevOOo/runner/convwatch/StatusHelper.java @@ -20,7 +20,7 @@ package convwatch; public class StatusHelper { - final static public int DIFF_NOT_REALLY_INITIALISED = 1; + final static private int DIFF_NOT_REALLY_INITIALISED = 1; final static public int DIFF_NO_DIFFERENCES = 2; final static public int DIFF_DIFFERENCES_FOUND = 3; final static public int DIFF_AFTER_MOVE_DONE_NO_PROBLEMS = 4; diff --git a/qadevOOo/runner/graphical/HTMLResult.java b/qadevOOo/runner/graphical/HTMLResult.java index e170ec68ee62..6d6ecb1b6335 100644 --- a/qadevOOo/runner/graphical/HTMLResult.java +++ b/qadevOOo/runner/graphical/HTMLResult.java @@ -86,10 +86,10 @@ public class HTMLResult flush(); } - final static String TEST_TABLETITLE = "Document"; - final static String VISUAL_STATUS_TABLETITLE = "Visual status"; - final static String VISUAL_STATUS_MESSAGE_TABLETITLE = "Message"; - final static String FIRSTGFX_TABLETITLE = "Original print file as jpeg"; + private final static String TEST_TABLETITLE = "Document"; + private final static String VISUAL_STATUS_TABLETITLE = "Visual status"; + private final static String VISUAL_STATUS_MESSAGE_TABLETITLE = "Message"; + private final static String FIRSTGFX_TABLETITLE = "Original print file as jpeg"; public void indexSection(String _sOfficeInfo) { diff --git a/qadevOOo/runner/graphical/PerformanceContainer.java b/qadevOOo/runner/graphical/PerformanceContainer.java index f4b4b4e5b426..32eaac791cf0 100644 --- a/qadevOOo/runner/graphical/PerformanceContainer.java +++ b/qadevOOo/runner/graphical/PerformanceContainer.java @@ -69,7 +69,7 @@ public class PerformanceContainer /* extends *//* implements */ { final static int StoreAsPDF = 4; final static int OfficeStop = 5; final static int AllTime = 6; - final static int LAST_VALUE = 7; // THIS MUST BE ALWAYS THE LAST AND THE BIGGEST VALUE! + private final static int LAST_VALUE = 7; // THIS MUST BE ALWAYS THE LAST AND THE BIGGEST VALUE! private long m_nTime[]; private String m_sMSOfficeVersion; diff --git a/qadevOOo/runner/util/DBTools.java b/qadevOOo/runner/util/DBTools.java index 377b6eaa8d56..251406276cbf 100644 --- a/qadevOOo/runner/util/DBTools.java +++ b/qadevOOo/runner/util/DBTools.java @@ -64,19 +64,19 @@ public class DBTools { // constants for TestDB table column indexes public final static int TST_STRING = 1 ; public final static int TST_INT = 2 ; - public final static int TST_DOUBLE = 5 ; - public final static int TST_DATE = 6 ; - public final static int TST_BOOLEAN = 10 ; - public final static int TST_CHARACTER_STREAM = 11 ; - public final static int TST_BINARY_STREAM = 12 ; + private final static int TST_DOUBLE = 5 ; + private final static int TST_DATE = 6 ; + private final static int TST_BOOLEAN = 10 ; + private final static int TST_CHARACTER_STREAM = 11 ; + private final static int TST_BINARY_STREAM = 12 ; // constants for TestDB columns names public final static String TST_STRING_F = "_TEXT" ; public final static String TST_INT_F = "_INT" ; public final static String TST_DOUBLE_F = "_DOUBLE" ; public final static String TST_DATE_F = "_DATE" ; - public final static String TST_BOOLEAN_F = "_BOOL" ; - public final static String TST_CHARACTER_STREAM_F = "_MEMO1" ; + private final static String TST_BOOLEAN_F = "_BOOL" ; + private final static String TST_CHARACTER_STREAM_F = "_MEMO1" ; public final static String TST_BINARY_STREAM_F = "_MEMO2" ; /** @@ -98,7 +98,7 @@ public class DBTools { * Array of lengths of streams for each row in of the * <code>TST_TABLE_VALUES</code> constants. */ - public final static int[] TST_STREAM_LENGTHS = {0, 0, 0} ; + private final static int[] TST_STREAM_LENGTHS = {0, 0, 0} ; /** * It's just a structure with some useful methods for representing |