loplugin:finalclasses in package..sfx2

Change-Id: I2908abc13f16b0011fcb326e8405080cc30df74a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86684
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 15 insertions, 19 deletions

diff --git a/reportdesign/inc/PropertyForward.hxx b/reportdesign/inc/PropertyForward.hxx
index c86858d87720..4f467c2a0fe0 100644
--- a/reportdesign/inc/PropertyForward.hxx
+++ b/reportdesign/inc/PropertyForward.hxx
@@ -39,7 +39,7 @@ namespace rptui
      * Identical properties will be set at the other propertyset.
      * \ingroup reportdesign_source_ui_misc
      */
-    class REPORTDESIGN_DLLPUBLIC OPropertyMediator : public ::cppu::BaseMutex
+    class REPORTDESIGN_DLLPUBLIC OPropertyMediator final : public ::cppu::BaseMutex
                             ,public OPropertyForward_Base
     {
         TPropertyNamePair                                     m_aNameMap;
@@ -50,7 +50,7 @@ namespace rptui
         bool                                                  m_bInChange;
         OPropertyMediator(OPropertyMediator const &) = delete;
         void operator =(OPropertyMediator const &) = delete;
-    protected:
+
         virtual ~OPropertyMediator() override;
 
         /** this function is called upon disposing the component
diff --git a/reportdesign/inc/ReportDefinition.hxx b/reportdesign/inc/ReportDefinition.hxx
index 9c8c25033e21..49dd3b4ac0fa 100644
--- a/reportdesign/inc/ReportDefinition.hxx
+++ b/reportdesign/inc/ReportDefinition.hxx
@@ -83,16 +83,14 @@ namespace reportdesign
      * \ingroup reportdesign_api
      *
      */
-    class REPORTDESIGN_DLLPUBLIC OReportDefinition  :public ::cppu::BaseMutex
+    class REPORTDESIGN_DLLPUBLIC OReportDefinition  final :public ::cppu::BaseMutex
                                                     ,public ReportDefinitionBase
                                                     ,public ReportDefinitionPropertySet
                                                     ,public ::comphelper::IEmbeddedHelper
     {
-    private:
         std::shared_ptr<OReportComponentProperties>                             m_aProps;
         std::shared_ptr<OReportDefinitionImpl>                                  m_pImpl;
 
-    private:
         OReportDefinition(const OReportDefinition&) = delete;
         OReportDefinition& operator=(const OReportDefinition&) = delete;
 
@@ -165,7 +163,6 @@ namespace reportdesign
             const css::uno::Sequence< css::beans::PropertyValue >& _rArguments
         );
 
-    protected:
         virtual ~OReportDefinition() override;
 
         /** this function is called upon disposing the component
@@ -186,7 +183,7 @@ namespace reportdesign
 
         css::uno::Reference< css::uno::XComponentContext > getContext();
 
-    protected:
+    private:
         /** abstract SdrModel provider */
         virtual SdrModel& getSdrModelFromUnoModel() const override;
 
diff --git a/reportdesign/inc/RptModel.hxx b/reportdesign/inc/RptModel.hxx
index 4c44f5ebe92d..260e40f4c978 100644
--- a/reportdesign/inc/RptModel.hxx
+++ b/reportdesign/inc/RptModel.hxx
@@ -38,7 +38,7 @@ namespace rptui
 class OReportPage;
 class OXUndoEnvironment;
 
-class REPORTDESIGN_DLLPUBLIC OReportModel : public SdrModel
+class REPORTDESIGN_DLLPUBLIC OReportModel final : public SdrModel
 {
     friend class OReportPage;
 
diff --git a/reportdesign/inc/RptObject.hxx b/reportdesign/inc/RptObject.hxx
index fdaf799f7285..1b3092155ca5 100644
--- a/reportdesign/inc/RptObject.hxx
+++ b/reportdesign/inc/RptObject.hxx
@@ -45,7 +45,7 @@ typedef ::std::multimap< sal_Int16, OUString > IndexToNameMap;
     };
 
     class OUnoObject;
-    class REPORTDESIGN_DLLPUBLIC DlgEdHint: public SfxHint
+    class REPORTDESIGN_DLLPUBLIC DlgEdHint final : public SfxHint
     {
     private:
         DlgEdHintKind const eHintKind;
diff --git a/reportdesign/inc/RptPage.hxx b/reportdesign/inc/RptPage.hxx
index abfa883f93eb..d8ff7fc9d176 100644
--- a/reportdesign/inc/RptPage.hxx
+++ b/reportdesign/inc/RptPage.hxx
@@ -32,7 +32,7 @@ namespace rptui
 
 class OReportModel;
 
-class REPORTDESIGN_DLLPUBLIC OReportPage : public SdrPage
+class REPORTDESIGN_DLLPUBLIC OReportPage final : public SdrPage
 {
     OReportPage& operator=(const OReportPage&) = delete;
     OReportPage(const OReportPage&) = delete;
@@ -48,7 +48,6 @@ class REPORTDESIGN_DLLPUBLIC OReportPage : public SdrPage
 
     virtual ~OReportPage() override;
 
-protected:
     virtual css::uno::Reference< css::uno::XInterface > createUnoPage() override;
 public:
 
diff --git a/reportdesign/inc/UndoActions.hxx b/reportdesign/inc/UndoActions.hxx
index cac660fc520c..78909ac7cda8 100644
--- a/reportdesign/inc/UndoActions.hxx
+++ b/reportdesign/inc/UndoActions.hxx
@@ -191,7 +191,7 @@ namespace rptui
 
     // OUndoReportSectionAction
 
-    class OUndoReportSectionAction : public OUndoContainerAction
+    class OUndoReportSectionAction final : public OUndoContainerAction
     {
         OReportHelper                               m_aReportHelper;
         ::std::function<css::uno::Reference< css::report::XSection >(OReportHelper *)> m_pMemberFunction;
@@ -203,14 +203,14 @@ namespace rptui
                             ,const css::uno::Reference< css::uno::XInterface>& xElem
                             ,const char* pCommentId);
 
-    protected:
+    private:
         virtual void    implReInsert( ) override;
         virtual void    implReRemove( ) override;
     };
 
 
     // OUndoGroupSectionAction
-    class OUndoGroupSectionAction : public OUndoContainerAction
+    class OUndoGroupSectionAction final : public OUndoContainerAction
     {
         OGroupHelper                                m_aGroupHelper;
         ::std::function<css::uno::Reference< css::report::XSection >(OGroupHelper *)> m_pMemberFunction;
@@ -222,7 +222,7 @@ namespace rptui
                             ,const css::uno::Reference< css::uno::XInterface>& xElem
                             ,const char* pCommentId);
 
-    protected:
+    private:
         virtual void    implReInsert( ) override;
         virtual void    implReRemove( ) override;
     };
@@ -255,11 +255,11 @@ namespace rptui
 
     // OUndoPropertyReportSectionAction
 
-    class OUndoPropertyReportSectionAction : public ORptUndoPropertyAction
+    class OUndoPropertyReportSectionAction final : public ORptUndoPropertyAction
     {
         OReportHelper                               m_aReportHelper;
         ::std::function<css::uno::Reference< css::report::XSection >(OReportHelper *)> m_pMemberFunction;
-    protected:
+
         virtual css::uno::Reference< css::beans::XPropertySet> getObject() override;
     public:
         OUndoPropertyReportSectionAction(SdrModel& rMod
@@ -272,11 +272,11 @@ namespace rptui
 
     // OUndoPropertyGroupSectionAction
 
-    class OUndoPropertyGroupSectionAction : public ORptUndoPropertyAction
+    class OUndoPropertyGroupSectionAction final : public ORptUndoPropertyAction
     {
         OGroupHelper                                m_aGroupHelper;
         ::std::function<css::uno::Reference< css::report::XSection >(OGroupHelper *)> m_pMemberFunction;
-    protected:
+
         virtual css::uno::Reference< css::beans::XPropertySet> getObject() override;
     public:
         OUndoPropertyGroupSectionAction(SdrModel& rMod