clang-tidy modernize-pass-by-value in reportdesign

Change-Id: I2c005a2f66139237cb1ebf09812f31fb08f53c90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136397
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

44 files changed, 111 insertions, 88 deletions

diff --git a/reportdesign/inc/RptObject.hxx b/reportdesign/inc/RptObject.hxx
index 2c89dc6d49c8..2e53c1f7f29b 100644
--- a/reportdesign/inc/RptObject.hxx
+++ b/reportdesign/inc/RptObject.hxx
@@ -71,7 +71,7 @@ protected:
     bool        m_bIsListening;
 
     OObjectBase(const css::uno::Reference< css::report::XReportComponent>& _xComponent);
-    OObjectBase(const OUString& _sComponentName);
+    OObjectBase(OUString _sComponentName);
 
     virtual ~OObjectBase();
 
diff --git a/reportdesign/inc/RptPage.hxx b/reportdesign/inc/RptPage.hxx
index 637687ad9a04..1b5a5c332cfc 100644
--- a/reportdesign/inc/RptPage.hxx
+++ b/reportdesign/inc/RptPage.hxx
@@ -52,7 +52,7 @@ class REPORTDESIGN_DLLPUBLIC OReportPage final : public SdrPage
 public:
 
     OReportPage( OReportModel& rModel
-                ,const css::uno::Reference< css::report::XSection >& _xSection );
+                ,css::uno::Reference< css::report::XSection > _xSection );
 
     virtual rtl::Reference<SdrPage> CloneSdrPage(SdrModel& rTargetModel) const override;
 
diff --git a/reportdesign/inc/UndoActions.hxx b/reportdesign/inc/UndoActions.hxx
index 7b1fb2005380..bf0b2107e142 100644
--- a/reportdesign/inc/UndoActions.hxx
+++ b/reportdesign/inc/UndoActions.hxx
@@ -29,6 +29,7 @@
 #include <svx/svdundo.hxx>
 
 #include <functional>
+#include <utility>
 
 namespace dbaui
 {
@@ -50,8 +51,8 @@ namespace rptui
         OGroupHelper(const OGroupHelper&) = delete;
         OGroupHelper& operator=(const OGroupHelper&) = delete;
     public:
-        OGroupHelper(const css::uno::Reference< css::report::XGroup >& _xGroup)
-            :m_xGroup(_xGroup)
+        OGroupHelper(css::uno::Reference< css::report::XGroup > _xGroup)
+            :m_xGroup(std::move(_xGroup))
         {
         }
         css::uno::Reference< css::report::XSection >   getHeader() { return m_xGroup->getHeader(); }
@@ -71,8 +72,8 @@ namespace rptui
     {
         css::uno::Reference< css::report::XReportDefinition > m_xReport;
     public:
-        OReportHelper(const css::uno::Reference< css::report::XReportDefinition >& _xReport)
-            :m_xReport(_xReport)
+        OReportHelper(css::uno::Reference< css::report::XReportDefinition > _xReport)
+            :m_xReport(std::move(_xReport))
         {
         }
         css::uno::Reference< css::report::XSection > getReportHeader() { return m_xReport->getReportHeader(); }
@@ -167,7 +168,7 @@ namespace rptui
     public:
         OUndoContainerAction(SdrModel& rMod
                             ,Action _eAction
-                            ,const css::uno::Reference< css::container::XIndexContainer >& rContainer
+                            ,css::uno::Reference< css::container::XIndexContainer > xContainer
                             ,const css::uno::Reference< css::uno::XInterface>& xElem
                             ,TranslateId pCommentId);
         virtual ~OUndoContainerAction() override;
diff --git a/reportdesign/source/core/api/Functions.cxx b/reportdesign/source/core/api/Functions.cxx
index 820d3c0eaba3..c2124e9378e3 100644
--- a/reportdesign/source/core/api/Functions.cxx
+++ b/reportdesign/source/core/api/Functions.cxx
@@ -23,16 +23,17 @@
 #include <com/sun/star/lang/IndexOutOfBoundsException.hpp>
 #include <com/sun/star/lang/NoSupportException.hpp>
 #include <o3tl/safeint.hxx>
+#include <utility>
 
 namespace reportdesign
 {
 
     using namespace com::sun::star;
 
-OFunctions::OFunctions(const uno::Reference< report::XFunctionsSupplier >& _xParent,const uno::Reference< uno::XComponentContext >& context)
+OFunctions::OFunctions(const uno::Reference< report::XFunctionsSupplier >& _xParent,uno::Reference< uno::XComponentContext > context)
 :FunctionsBase(m_aMutex)
 ,m_aContainerListeners(m_aMutex)
-,m_xContext(context)
+,m_xContext(std::move(context))
 ,m_xParent(_xParent)
 {
 }
diff --git a/reportdesign/source/core/api/Groups.cxx b/reportdesign/source/core/api/Groups.cxx
index 780c6093bec4..a2ce3dfdc2fb 100644
--- a/reportdesign/source/core/api/Groups.cxx
+++ b/reportdesign/source/core/api/Groups.cxx
@@ -23,16 +23,17 @@
 #include <o3tl/safeint.hxx>
 #include <core_resource.hxx>
 #include <strings.hrc>
+#include <utility>
 
 namespace reportdesign
 {
 
     using namespace com::sun::star;
 
-OGroups::OGroups(const uno::Reference< report::XReportDefinition >& _xParent,const uno::Reference< uno::XComponentContext >& context)
+OGroups::OGroups(const uno::Reference< report::XReportDefinition >& _xParent,uno::Reference< uno::XComponentContext > context)
 :GroupsBase(m_aMutex)
 ,m_aContainerListeners(m_aMutex)
-,m_xContext(context)
+,m_xContext(std::move(context))
 ,m_xParent(_xParent)
 {
 }
diff --git a/reportdesign/source/core/api/Shape.cxx b/reportdesign/source/core/api/Shape.cxx
index 413f02e1b765..028118f199b8 100644
--- a/reportdesign/source/core/api/Shape.cxx
+++ b/reportdesign/source/core/api/Shape.cxx
@@ -28,6 +28,7 @@
 #include <Tools.hxx>
 #include <FormatCondition.hxx>
 #include <ReportHelperImpl.hxx>
+#include <utility>
 
 namespace reportdesign
 {
@@ -58,13 +59,13 @@ OShape::OShape(uno::Reference< uno::XComponentContext > const & _xContext)
 OShape::OShape(uno::Reference< uno::XComponentContext > const & _xContext
                ,const uno::Reference< lang::XMultiServiceFactory>& _xFactory
                ,uno::Reference< drawing::XShape >& _xShape
-               ,const OUString& _sServiceName)
+               ,OUString _sServiceName)
 :ShapeBase(m_aMutex)
 ,ShapePropertySet(_xContext,IMPLEMENTS_PROPERTY_SET,lcl_getShapeOptionals())
 ,m_aProps(m_aMutex,static_cast< container::XContainer*>( this ),_xContext)
 ,m_nZOrder(0)
 ,m_bOpaque(false)
-,m_sServiceName(_sServiceName)
+,m_sServiceName(std::move(_sServiceName))
 {
     m_aProps.aComponent.m_sName  = RptResId(RID_STR_SHAPE);
     m_aProps.aComponent.m_xFactory = _xFactory;
diff --git a/reportdesign/source/core/inc/Functions.hxx b/reportdesign/source/core/inc/Functions.hxx
index 94a54beeb02d..13d08ab4a69f 100644
--- a/reportdesign/source/core/inc/Functions.hxx
+++ b/reportdesign/source/core/inc/Functions.hxx
@@ -59,7 +59,7 @@ namespace reportdesign
         virtual void SAL_CALL disposing() override;
     public:
         explicit OFunctions( const css::uno::Reference< css::report::XFunctionsSupplier >& _xParent
-                ,const css::uno::Reference< css::uno::XComponentContext >& context);
+                ,css::uno::Reference< css::uno::XComponentContext > context);
 
     // XFunctions
         // Methods
diff --git a/reportdesign/source/core/inc/Groups.hxx b/reportdesign/source/core/inc/Groups.hxx
index 9897abd3af76..c8d93189b2e9 100644
--- a/reportdesign/source/core/inc/Groups.hxx
+++ b/reportdesign/source/core/inc/Groups.hxx
@@ -58,7 +58,7 @@ namespace reportdesign
         virtual void SAL_CALL disposing() override;
     public:
         OGroups( const css::uno::Reference< css::report::XReportDefinition >& _xParent
-                ,const css::uno::Reference< css::uno::XComponentContext >& context);
+                ,css::uno::Reference< css::uno::XComponentContext > context);
 
     // XGroups
         // Attributes
diff --git a/reportdesign/source/core/inc/ReportComponent.hxx b/reportdesign/source/core/inc/ReportComponent.hxx
index b6f9660402a4..e07ff98c17ca 100644
--- a/reportdesign/source/core/inc/ReportComponent.hxx
+++ b/reportdesign/source/core/inc/ReportComponent.hxx
@@ -30,6 +30,7 @@
 #include <com/sun/star/report/XReportComponent.hpp>
 #include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <cppuhelper/weakref.hxx>
+#include <utility>
 
 namespace reportdesign
 {
@@ -58,8 +59,8 @@ namespace reportdesign
         bool m_bAutoGrow;
 
         OReportComponentProperties(
-                css::uno::Reference<css::uno::XComponentContext> const& xContext)
-            : m_xContext(xContext)
+                css::uno::Reference<css::uno::XComponentContext> xContext)
+            : m_xContext(std::move(xContext))
             , m_nHeight(0)
             , m_nWidth(0)
             , m_nPosX(0)
diff --git a/reportdesign/source/core/inc/Shape.hxx b/reportdesign/source/core/inc/Shape.hxx
index 73f6c63f685f..ea87004b8704 100644
--- a/reportdesign/source/core/inc/Shape.hxx
+++ b/reportdesign/source/core/inc/Shape.hxx
@@ -113,7 +113,7 @@ namespace reportdesign
         explicit OShape(css::uno::Reference< css::uno::XComponentContext > const & _xContext
                         ,const css::uno::Reference< css::lang::XMultiServiceFactory > & _xFactory
                         ,css::uno::Reference< css::drawing::XShape >& _xShape
-                        ,const OUString& _sServiceName);
+                        ,OUString _sServiceName);
 
         DECLARE_XINTERFACE( )
         // css::lang::XServiceInfo
diff --git a/reportdesign/source/core/sdr/RptObject.cxx b/reportdesign/source/core/sdr/RptObject.cxx
index 1972e892eb27..4c90a556e810 100644
--- a/reportdesign/source/core/sdr/RptObject.cxx
+++ b/reportdesign/source/core/sdr/RptObject.cxx
@@ -47,6 +47,7 @@
 #include <tools/diagnose_ex.h>
 #include <PropertyForward.hxx>
 #include <UndoEnv.hxx>
+#include <utility>
 
 namespace rptui
 {
@@ -311,8 +312,8 @@ OObjectBase::OObjectBase(const uno::Reference< report::XReportComponent>& _xComp
     m_xReportComponent = _xComponent;
 }
 
-OObjectBase::OObjectBase(const OUString& _sComponentName)
-:m_sComponentName(_sComponentName)
+OObjectBase::OObjectBase(OUString _sComponentName)
+:m_sComponentName(std::move(_sComponentName))
 ,m_bIsListening(false)
 {
 }
diff --git a/reportdesign/source/core/sdr/RptPage.cxx b/reportdesign/source/core/sdr/RptPage.cxx
index 1ad1cb8e11b0..135d2e1ec21b 100644
--- a/reportdesign/source/core/sdr/RptPage.cxx
+++ b/reportdesign/source/core/sdr/RptPage.cxx
@@ -21,6 +21,7 @@
 #include <Section.hxx>
 #include <RptObject.hxx>
 #include <ReportDrawPage.hxx>
+#include <utility>
 
 namespace rptui
 {
@@ -28,10 +29,10 @@ using namespace ::com::sun::star;
 
 OReportPage::OReportPage(
     OReportModel& _rModel,
-    const uno::Reference< report::XSection >& _xSection)
+    uno::Reference< report::XSection > _xSection)
 :   SdrPage(_rModel, false/*bMasterPage*/)
     ,rModel(_rModel)
-    ,m_xSection(_xSection)
+    ,m_xSection(std::move(_xSection))
     ,m_bSpecialInsertMode(false)
 {
 }
diff --git a/reportdesign/source/core/sdr/UndoActions.cxx b/reportdesign/source/core/sdr/UndoActions.cxx
index 78d59e5410f8..edd70cb77c66 100644
--- a/reportdesign/source/core/sdr/UndoActions.cxx
+++ b/reportdesign/source/core/sdr/UndoActions.cxx
@@ -89,12 +89,12 @@ void OCommentUndoAction::Redo()
 
 OUndoContainerAction::OUndoContainerAction(SdrModel& _rMod
                                              ,Action _eAction
-                                             ,const uno::Reference< container::XIndexContainer >& rContainer
+                                             ,uno::Reference< container::XIndexContainer > xContainer
                                              ,const Reference< XInterface > & xElem
                                              ,TranslateId pCommentId)
                       :OCommentUndoAction(_rMod, pCommentId)
                       ,m_xElement(xElem)
-                      ,m_xContainer(rContainer)
+                      ,m_xContainer(std::move(xContainer))
                          ,m_eAction( _eAction )
 {
     // normalize
diff --git a/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx b/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
index b8b064cc670d..9c80fdefb34d 100644
--- a/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
+++ b/reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx
@@ -26,6 +26,7 @@
 #include <comphelper/sequenceashashmap.hxx>
 #include <comphelper/documentconstants.hxx>
 #include <cppuhelper/supportsservice.hxx>
+#include <utility>
 #include <xmloff/attrlist.hxx>
 #include <xmloff/xmltoken.hxx>
 #include <xmloff/xmlement.hxx>
@@ -68,8 +69,8 @@ static void lcl_correctCellAddress(const OUString & _sName, const uno::Reference
     }
 }
 
-ExportDocumentHandler::ExportDocumentHandler(uno::Reference< uno::XComponentContext > const & context) :
-    m_xContext(context)
+ExportDocumentHandler::ExportDocumentHandler(uno::Reference< uno::XComponentContext > context) :
+    m_xContext(std::move(context))
     ,m_nColumnCount(0)
     ,m_bTableRowsStarted(false)
     ,m_bFirstRowExported(false)
diff --git a/reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx b/reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx
index 9e7afe347da2..c6b34af02e22 100644
--- a/reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx
+++ b/reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx
@@ -43,7 +43,7 @@ typedef ::cppu::WeakAggImplHelper3< css::xml::sax::XDocumentHandler
 class ExportDocumentHandler : public ExportDocumentHandler_BASE
 {
 public:
-    explicit ExportDocumentHandler(css::uno::Reference< css::uno::XComponentContext > const & context);
+    explicit ExportDocumentHandler(css::uno::Reference< css::uno::XComponentContext > context);
 
 private:
     // XServiceInfo
diff --git a/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx b/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
index edb4dcaaaad2..8e0dc1f3f00f 100644
--- a/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
+++ b/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
@@ -29,6 +29,7 @@
 #include <comphelper/sequenceashashmap.hxx>
 #include <comphelper/namedvaluecollection.hxx>
 #include <cppuhelper/supportsservice.hxx>
+#include <utility>
 #include <xmloff/attrlist.hxx>
 #include <xmloff/xmltoken.hxx>
 #include <xmloff/xmlement.hxx>
@@ -47,9 +48,9 @@ namespace rptxml
 using namespace ::com::sun::star;
 using namespace ::xmloff::token;
 
-ImportDocumentHandler::ImportDocumentHandler(uno::Reference< uno::XComponentContext > const & context)
+ImportDocumentHandler::ImportDocumentHandler(uno::Reference< uno::XComponentContext > context)
     :m_bImportedChart( false )
-    ,m_xContext(context)
+    ,m_xContext(std::move(context))
 {
 }
 
diff --git a/reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx b/reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx
index aadea441ca62..ed1d6af92c8f 100644
--- a/reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx
+++ b/reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx
@@ -43,7 +43,7 @@ typedef ::cppu::WeakAggImplHelper3< css::xml::sax::XDocumentHandler
 class ImportDocumentHandler : public ImportDocumentHandler_BASE
 {
 public:
-    explicit ImportDocumentHandler(css::uno::Reference< css::uno::XComponentContext > const & context);
+    explicit ImportDocumentHandler(css::uno::Reference< css::uno::XComponentContext > context);
 
 private:
     // XServiceInfo
diff --git a/reportdesign/source/filter/xml/xmlSection.cxx b/reportdesign/source/filter/xml/xmlSection.cxx
index 957c3a2ca974..ec035106aaf4 100644
--- a/reportdesign/source/filter/xml/xmlSection.cxx
+++ b/reportdesign/source/filter/xml/xmlSection.cxx
@@ -18,6 +18,7 @@
  */
 #include "xmlSection.hxx"
 #include "xmlfilter.hxx"
+#include <utility>
 #include <xmloff/xmltoken.hxx>
 #include <xmloff/xmlnamespace.hxx>
 #include <xmloff/xmluconv.hxx>
@@ -45,10 +46,10 @@ namespace rptxml
 
 OXMLSection::OXMLSection( ORptFilter& rImport,
                 const uno::Reference< xml::sax::XFastAttributeList > & _xAttrList
-                ,const uno::Reference< report::XSection >& _xSection
+                ,uno::Reference< report::XSection > _xSection
                 ,bool _bPageHeader)
 :SvXMLImportContext( rImport )
-,m_xSection(_xSection)
+,m_xSection(std::move(_xSection))
 {
 
     if (!m_xSection.is())
diff --git a/reportdesign/source/filter/xml/xmlSection.hxx b/reportdesign/source/filter/xml/xmlSection.hxx
index c1e25cd837f8..22a3b091e37e 100644
--- a/reportdesign/source/filter/xml/xmlSection.hxx
+++ b/reportdesign/source/filter/xml/xmlSection.hxx
@@ -37,7 +37,7 @@ namespace rptxml
 
         OXMLSection( ORptFilter& rImport
                     ,const css::uno::Reference< css::xml::sax::XFastAttributeList > & xAttrList
-                    ,const css::uno::Reference< css::report::XSection >& _xSection
+                    ,css::uno::Reference< css::report::XSection > _xSection
                     ,bool _bPageHeader = true);
         virtual ~OXMLSection() override;
 
diff --git a/reportdesign/source/filter/xml/xmlTable.cxx b/reportdesign/source/filter/xml/xmlTable.cxx
index 34075b46d97f..3512bba5e1aa 100644
--- a/reportdesign/source/filter/xml/xmlTable.cxx
+++ b/reportdesign/source/filter/xml/xmlTable.cxx
@@ -19,6 +19,7 @@
 #include "xmlTable.hxx"
 #include "xmlfilter.hxx"
 #include <o3tl/safeint.hxx>
+#include <utility>
 #include <xmloff/xmltoken.hxx>
 #include <xmloff/xmlnamespace.hxx>
 #include <xmloff/xmlstyle.hxx>
@@ -59,10 +60,10 @@ namespace rptxml
 
 OXMLTable::OXMLTable( ORptFilter& rImport
                 ,const Reference< XFastAttributeList > & _xAttrList
-                ,const uno::Reference< report::XSection >& _xSection
+                ,uno::Reference< report::XSection > _xSection
                 )
 :SvXMLImportContext( rImport )
-,m_xSection(_xSection)
+,m_xSection(std::move(_xSection))
 ,m_nColSpan(1)
 ,m_nRowSpan(0)
 ,m_nRowIndex(0)
diff --git a/reportdesign/source/filter/xml/xmlTable.hxx b/reportdesign/source/filter/xml/xmlTable.hxx
index 508ad5087166..c674bf14dd47 100644
--- a/reportdesign/source/filter/xml/xmlTable.hxx
+++ b/reportdesign/source/filter/xml/xmlTable.hxx
@@ -58,7 +58,7 @@ namespace rptxml
 
         OXMLTable( ORptFilter& rImport
                     ,const css::uno::Reference< css::xml::sax::XFastAttributeList > & xAttrList
-                    ,const css::uno::Reference< css::report::XSection >& _xSection
+                    ,css::uno::Reference< css::report::XSection > _xSection
                     );
         virtual ~OXMLTable() override;
 
diff --git a/reportdesign/source/ui/dlg/AddField.cxx b/reportdesign/source/ui/dlg/AddField.cxx
index 6bf3cd1f0759..15914a05c790 100644
--- a/reportdesign/source/ui/dlg/AddField.cxx
+++ b/reportdesign/source/ui/dlg/AddField.cxx
@@ -21,6 +21,7 @@
 #include <com/sun/star/sdb/CommandType.hpp>
 #include <com/sun/star/sdb/XDocumentDataSource.hpp>
 
+#include <utility>
 #include <vcl/svapp.hxx>
 
 #include <tools/diagnose_ex.h>
@@ -59,11 +60,11 @@ IMPL_LINK(OAddFieldWindow, DragBeginHdl, bool&, rUnsetDragIcon, bool)
     return false;
 }
 
-OAddFieldWindow::OAddFieldWindow(weld::Window* pParent, const uno::Reference< beans::XPropertySet >& xRowSet)
+OAddFieldWindow::OAddFieldWindow(weld::Window* pParent, uno::Reference< beans::XPropertySet > xRowSet)
     : GenericDialogController(pParent, "modules/dbreport/ui/floatingfield.ui", "FloatingField")
     , ::comphelper::OPropertyChangeListener(m_aMutex)
     , ::comphelper::OContainerListener(m_aMutex)
-    , m_xRowSet(xRowSet)
+    , m_xRowSet(std::move(xRowSet))
     , m_xActions(m_xBuilder->weld_toolbar("toolbox"))
     , m_xListBox(m_xBuilder->weld_tree_view("treeview"))
     , m_xHelpText(m_xBuilder->weld_label("helptext"))
diff --git a/reportdesign/source/ui/dlg/DateTime.cxx b/reportdesign/source/ui/dlg/DateTime.cxx
index 01cc62d1e2a5..90c57927cdd4 100644
--- a/reportdesign/source/ui/dlg/DateTime.cxx
+++ b/reportdesign/source/ui/dlg/DateTime.cxx
@@ -22,6 +22,7 @@
 #include <connectivity/dbconversion.hxx>
 #include <unotools/syslocale.hxx>
 #include <i18nlangtag/languagetag.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <strings.hxx>
 #include <ReportController.hxx>
@@ -36,12 +37,12 @@ using namespace ::comphelper;
 
 
 
-ODateTimeDialog::ODateTimeDialog(weld::Window* _pParent, const uno::Reference< report::XSection >& _xHoldAlive,
+ODateTimeDialog::ODateTimeDialog(weld::Window* _pParent, uno::Reference< report::XSection > _xHoldAlive,
                                  OReportController* _pController)
     : GenericDialogController(_pParent, "modules/dbreport/ui/datetimedialog.ui", "DateTimeDialog")
 
     , m_pController(_pController)
-    , m_xHoldAlive(_xHoldAlive)
+    , m_xHoldAlive(std::move(_xHoldAlive))
     , m_xDate(m_xBuilder->weld_check_button("date"))
     , m_xFTDateFormat(m_xBuilder->weld_label("datelistbox_label"))
     , m_xDateListBox(m_xBuilder->weld_combo_box("datelistbox"))
diff --git a/reportdesign/source/ui/dlg/Formula.cxx b/reportdesign/source/ui/dlg/Formula.cxx
index a0b866031631..b3ce1bbfcfcb 100644
--- a/reportdesign/source/ui/dlg/Formula.cxx
+++ b/reportdesign/source/ui/dlg/Formula.cxx
@@ -29,6 +29,7 @@
 
 #include <Formula.hxx>
 #include <AddField.hxx>
+#include <utility>
 #include <helpids.h>
 
 
@@ -45,12 +46,12 @@ FormulaDialog::FormulaDialog(weld::Window* pParent
                              , const uno::Reference<lang::XMultiServiceFactory>& _xServiceFactory
                              , const std::shared_ptr< IFunctionManager >&  _pFunctionMgr
                              , const OUString& _sFormula
-                             , const css::uno::Reference < css::beans::XPropertySet >& _xRowSet
+                             , css::uno::Reference < css::beans::XPropertySet > _xRowSet
                              , svl::SharedStringPool& rStrPool )
     : FormulaModalDialog( pParent, _pFunctionMgr.get(),this)
     ,m_aFunctionManager(_pFunctionMgr)
     ,m_xFormulaData(new FormEditData())
-    ,m_xRowSet(_xRowSet)
+    ,m_xRowSet(std::move(_xRowSet))
     ,m_pEdit(nullptr)
     ,m_sFormula("=")
     ,m_nStart(0)
diff --git a/reportdesign/source/ui/dlg/Navigator.cxx b/reportdesign/source/ui/dlg/Navigator.cxx
index d6769dec98ff..bdc2a646905b 100644
--- a/reportdesign/source/ui/dlg/Navigator.cxx
+++ b/reportdesign/source/ui/dlg/Navigator.cxx
@@ -38,6 +38,7 @@
 #include <comphelper/containermultiplexer.hxx>
 #include <cppuhelper/basemutex.hxx>
 #include <comphelper/SelectionMultiplex.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
 #include <vcl/commandevent.hxx>
@@ -115,7 +116,7 @@ class NavigatorTree : public ::cppu::BaseMutex
         ::rtl::Reference< comphelper::OContainerListenerAdapter>    m_pContainerListener;
         NavigatorTree*                                              m_pTree;
     public:
-        UserData(NavigatorTree* pTree, const uno::Reference<uno::XInterface>& xContent);
+        UserData(NavigatorTree* pTree, uno::Reference<uno::XInterface> xContent);
         virtual ~UserData() override;
 
         const uno::Reference< uno::XInterface >& getContent() const { return m_xContent; }
@@ -677,10 +678,10 @@ void NavigatorTree::removeEntry(const weld::TreeIter& rEntry, bool bRemove)
         m_xTreeView->remove(rEntry);
 }
 
-NavigatorTree::UserData::UserData(NavigatorTree* pTree,const uno::Reference<uno::XInterface>& xContent)
+NavigatorTree::UserData::UserData(NavigatorTree* pTree,uno::Reference<uno::XInterface> xContent)
     : OPropertyChangeListener(m_aMutex)
     , OContainerListener(m_aMutex)
-    , m_xContent(xContent)
+    , m_xContent(std::move(xContent))
     , m_pTree(pTree)
 {
     uno::Reference<beans::XPropertySet> xProp(m_xContent,uno::UNO_QUERY);
diff --git a/reportdesign/source/ui/dlg/PageNumber.cxx b/reportdesign/source/ui/dlg/PageNumber.cxx
index 2d18077ab569..312d0772712b 100644
--- a/reportdesign/source/ui/dlg/PageNumber.cxx
+++ b/reportdesign/source/ui/dlg/PageNumber.cxx
@@ -23,6 +23,7 @@
 #include <strings.hxx>
 #include <ReportController.hxx>
 #include <comphelper/propertysequence.hxx>
+#include <utility>
 
 namespace rptui
 {
@@ -32,11 +33,11 @@ using namespace ::comphelper;
 
 
 OPageNumberDialog::OPageNumberDialog(weld::Window* pParent,
-                                     const uno::Reference< report::XReportDefinition >& _xHoldAlive,
+                                     uno::Reference< report::XReportDefinition > _xHoldAlive,
                                      OReportController* _pController)
     : GenericDialogController(pParent, "modules/dbreport/ui/pagenumberdialog.ui", "PageNumberDialog")
     , m_pController(_pController)
-    , m_xHoldAlive(_xHoldAlive)
+    , m_xHoldAlive(std::move(_xHoldAlive))
     , m_xPageN(m_xBuilder->weld_radio_button("pagen"))
     , m_xPageNofM(m_xBuilder->weld_radio_button("pagenofm"))
     , m_xTopPage(m_xBuilder->weld_radio_button("toppage"))
diff --git a/reportdesign/source/ui/inc/AddField.hxx b/reportdesign/source/ui/inc/AddField.hxx
index 5a388d49ab29..be33db5799ca 100644
--- a/reportdesign/source/ui/inc/AddField.hxx
+++ b/reportdesign/source/ui/inc/AddField.hxx
@@ -78,7 +78,7 @@ class  OAddFieldWindow : public weld::GenericDialogController
     void operator =(const OAddFieldWindow&) = delete;
 public:
     OAddFieldWindow(weld::Window* pParent,
-                    const css::uno::Reference< css::beans::XPropertySet >& xRowSet);
+                    css::uno::Reference< css::beans::XPropertySet >  xRowSet);
 
     virtual ~OAddFieldWindow() override;
 
diff --git a/reportdesign/source/ui/inc/ColorListener.hxx b/reportdesign/source/ui/inc/ColorListener.hxx
index 0f8a89acad9e..7249fb851ce0 100644
--- a/reportdesign/source/ui/inc/ColorListener.hxx
+++ b/reportdesign/source/ui/inc/ColorListener.hxx
@@ -44,7 +44,7 @@ namespace rptui
     protected:
         virtual void DataChanged( const DataChangedEvent& rDCEvt ) override;
     public:
-        OColorListener(vcl::Window* _pParent,const OUString& _sColorEntry);
+        OColorListener(vcl::Window* _pParent,OUString _sColorEntry);
         virtual ~OColorListener() override;
         virtual void dispose() override;
 
diff --git a/reportdesign/source/ui/inc/ColumnInfo.hxx b/reportdesign/source/ui/inc/ColumnInfo.hxx
index 65062f9dc136..58495e2c063e 100644
--- a/reportdesign/source/ui/inc/ColumnInfo.hxx
+++ b/reportdesign/source/ui/inc/ColumnInfo.hxx
@@ -20,6 +20,7 @@
 #define INCLUDED_REPORTDESIGN_SOURCE_UI_INC_COLUMNINFO_HXX
 
 #include <rtl/ustring.hxx>
+#include <utility>
 
 namespace rptui
 {
@@ -27,13 +28,13 @@ namespace rptui
     {
         OUString sColumnName;
         OUString sLabel;
-        ColumnInfo(const OUString& i_sColumnName,const OUString& i_sLabel)
-            : sColumnName(i_sColumnName)
-            , sLabel(i_sLabel)
+        ColumnInfo(OUString i_sColumnName,OUString i_sLabel)
+            : sColumnName(std::move(i_sColumnName))
+            , sLabel(std::move(i_sLabel))
         {
         }
-        ColumnInfo(const OUString& i_sColumnName)
-            : sColumnName(i_sColumnName)
+        ColumnInfo(OUString i_sColumnName)
+            : sColumnName(std::move(i_sColumnName))
         {
         }
     };
diff --git a/reportdesign/source/ui/inc/DataProviderHandler.hxx b/reportdesign/source/ui/inc/DataProviderHandler.hxx
index 05dd693a9e80..1af9a1ed2181 100644
--- a/reportdesign/source/ui/inc/DataProviderHandler.hxx
+++ b/reportdesign/source/ui/inc/DataProviderHandler.hxx
@@ -48,7 +48,7 @@ namespace rptui
         public DataProviderHandler_Base
     {
     public:
-        explicit DataProviderHandler(css::uno::Reference< css::uno::XComponentContext > const & context);
+        explicit DataProviderHandler(css::uno::Reference< css::uno::XComponentContext > context);
     private:
 
         // XServiceInfo
diff --git a/reportdesign/source/ui/inc/DateTime.hxx b/reportdesign/source/ui/inc/DateTime.hxx
index df9fbfe87c4a..95bc0428b14b 100644
--- a/reportdesign/source/ui/inc/DateTime.hxx
+++ b/reportdesign/source/ui/inc/DateTime.hxx
@@ -69,7 +69,7 @@ class ODateTimeDialog : public weld::GenericDialogController
     void InsertEntry(sal_Int16 _nNumberFormatId);
 public:
     ODateTimeDialog(weld::Window* pParent,
-                     const css::uno::Reference< css::report::XSection>& _xHoldAlive,
+                     css::uno::Reference< css::report::XSection> _xHoldAlive,
                      ::rptui::OReportController* _pController);
     virtual short run() override;
 };
diff --git a/reportdesign/source/ui/inc/Formula.hxx b/reportdesign/source/ui/inc/Formula.hxx
index 8ec93075b5b0..9271d68e5a15 100644
--- a/reportdesign/source/ui/inc/Formula.hxx
+++ b/reportdesign/source/ui/inc/Formula.hxx
@@ -64,7 +64,7 @@ public:
         , const css::uno::Reference< css::lang::XMultiServiceFactory>& _xServiceFactory
         , const std::shared_ptr< formula::IFunctionManager >& _pFunctionMgr
         , const OUString& _sFormula
-        , const css::uno::Reference < css::beans::XPropertySet >& _xRowSet
+        , css::uno::Reference < css::beans::XPropertySet > _xRowSet
         , svl::SharedStringPool& rStrPool );
 
     virtual ~FormulaDialog() override;
diff --git a/reportdesign/source/ui/inc/FunctionHelper.hxx b/reportdesign/source/ui/inc/FunctionHelper.hxx
index 8eea9632b65f..2ce34368783e 100644
--- a/reportdesign/source/ui/inc/FunctionHelper.hxx
+++ b/reportdesign/source/ui/inc/FunctionHelper.hxx
@@ -43,7 +43,7 @@ class FunctionManager : public formula::IFunctionManager
     mutable ::std::vector< TCategoriesMap::iterator > m_aCategoryIndex;
     mutable TFunctionsMap   m_aFunctions;
 public:
-            FunctionManager(const css::uno::Reference< css::report::meta::XFunctionManager>& _xMgr);
+            FunctionManager(css::uno::Reference< css::report::meta::XFunctionManager> _xMgr);
     virtual ~FunctionManager();
     virtual sal_uInt32                              getCount() const override;
     virtual const formula::IFunctionCategory*       getCategory(sal_uInt32 nPos) const override;
@@ -59,7 +59,7 @@ class FunctionDescription : public formula::IFunctionDescription
     css::uno::Reference< css::report::meta::XFunctionDescription> m_xFunctionDescription;
     const formula::IFunctionCategory* m_pFunctionCategory;
 public:
-    FunctionDescription(const formula::IFunctionCategory* _pFunctionCategory,const css::uno::Reference< css::report::meta::XFunctionDescription>& _xFunctionDescription);
+    FunctionDescription(const formula::IFunctionCategory* _pFunctionCategory,css::uno::Reference< css::report::meta::XFunctionDescription> _xFunctionDescription);
     virtual ~FunctionDescription(){}
 
     virtual OUString getFunctionName() const override ;
diff --git a/reportdesign/source/ui/inc/PageNumber.hxx b/reportdesign/source/ui/inc/PageNumber.hxx
index eefa10c8b809..ce39f2bfac83 100644
--- a/reportdesign/source/ui/inc/PageNumber.hxx
+++ b/reportdesign/source/ui/inc/PageNumber.hxx
@@ -46,7 +46,7 @@ class OPageNumberDialog : public weld::GenericDialogController
     void operator =(const OPageNumberDialog&) = delete;
 public:
     OPageNumberDialog(weld::Window* pParent,
-                      const css::uno::Reference< css::report::XReportDefinition>& _xHoldAlive,
+                      css::uno::Reference< css::report::XReportDefinition> _xHoldAlive,
                       ::rptui::OReportController* _pController);
     virtual ~OPageNumberDialog() override;
     virtual short run() override;
diff --git a/reportdesign/source/ui/inc/ReportComponentHandler.hxx b/reportdesign/source/ui/inc/ReportComponentHandler.hxx
index fdf4ad0e6226..d8ac2b36e715 100644
--- a/reportdesign/source/ui/inc/ReportComponentHandler.hxx
+++ b/reportdesign/source/ui/inc/ReportComponentHandler.hxx
@@ -42,7 +42,7 @@ namespace rptui
         public ReportComponentHandler_Base
     {
     public:
-        explicit ReportComponentHandler(css::uno::Reference< css::uno::XComponentContext > const & context);
+        explicit ReportComponentHandler(css::uno::Reference< css::uno::XComponentContext > context);
 
         // XServiceInfo
         virtual OUString SAL_CALL getImplementationName(  ) override;
diff --git a/reportdesign/source/ui/inc/ReportSection.hxx b/reportdesign/source/ui/inc/ReportSection.hxx
index 03bb57199bac..94dd403d1b59 100644
--- a/reportdesign/source/ui/inc/ReportSection.hxx
+++ b/reportdesign/source/ui/inc/ReportSection.hxx
@@ -76,7 +76,7 @@ namespace rptui
         // OPropertyChangeListener
         virtual void    _propertyChanged(const css::beans::PropertyChangeEvent& _rEvent) override;
     public:
-        OReportSection(OSectionWindow* _pParent,const css::uno::Reference< css::report::XSection >& _xSection);
+        OReportSection(OSectionWindow* _pParent,css::uno::Reference< css::report::XSection > _xSection);
         virtual ~OReportSection() override;
         virtual void dispose() override;
 
diff --git a/reportdesign/source/ui/inc/RptUndo.hxx b/reportdesign/source/ui/inc/RptUndo.hxx
index cef45a59d996..d8b3fbc08ab2 100644
--- a/reportdesign/source/ui/inc/RptUndo.hxx
+++ b/reportdesign/source/ui/inc/RptUndo.hxx
@@ -124,8 +124,8 @@ namespace rptui
         OGroupUndo(OReportModel& rMod
                     ,TranslateId pCommentID
                     ,Action _eAction
-                    ,const css::uno::Reference< css::report::XGroup>& _xGroup
-                    ,const css::uno::Reference< css::report::XReportDefinition >& _xReportDefinition);
+                    ,css::uno::Reference< css::report::XGroup> _xGroup
+                    ,css::uno::Reference< css::report::XReportDefinition > _xReportDefinition);
         virtual void        Undo() override;
         virtual void        Redo() override;
     };
diff --git a/reportdesign/source/ui/inspection/DataProviderHandler.cxx b/reportdesign/source/ui/inspection/DataProviderHandler.cxx
index 9e789db4c5da..10c216dcddf6 100644
--- a/reportdesign/source/ui/inspection/DataProviderHandler.cxx
+++ b/reportdesign/source/ui/inspection/DataProviderHandler.cxx
@@ -48,15 +48,16 @@
 #include <helpids.h>
 #include <strings.hrc>
 #include <PropertyForward.hxx>
+#include <utility>
 
 namespace rptui
 {
 
 using namespace ::com::sun::star;
 
-DataProviderHandler::DataProviderHandler(uno::Reference< uno::XComponentContext > const & context)
+DataProviderHandler::DataProviderHandler(uno::Reference< uno::XComponentContext > context)
     :DataProviderHandler_Base(m_aMutex)
-    ,m_xContext(context)
+    ,m_xContext(std::move(context))
 {
     try
     {
diff --git a/reportdesign/source/ui/inspection/ReportComponentHandler.cxx b/reportdesign/source/ui/inspection/ReportComponentHandler.cxx
index 28b33acc4133..7f84aeb5b11c 100644
--- a/reportdesign/source/ui/inspection/ReportComponentHandler.cxx
+++ b/reportdesign/source/ui/inspection/ReportComponentHandler.cxx
@@ -24,6 +24,7 @@
 #include <com/sun/star/form/inspection/FormComponentPropertyHandler.hpp>
 #include <com/sun/star/container/XNameContainer.hpp>
 #include <metadata.hxx>
+#include <utility>
 
 
 namespace rptui
@@ -31,9 +32,9 @@ namespace rptui
 
 using namespace ::com::sun::star;
 
-ReportComponentHandler::ReportComponentHandler(uno::Reference< uno::XComponentContext > const & context)
+ReportComponentHandler::ReportComponentHandler(uno::Reference< uno::XComponentContext > context)
     :ReportComponentHandler_Base(m_aMutex)
-    ,m_xContext(context)
+    ,m_xContext(std::move(context))
 {
     try
     {
diff --git a/reportdesign/source/ui/inspection/metadata.cxx b/reportdesign/source/ui/inspection/metadata.cxx
index 59bbdb21d7d7..7698ea94fca3 100644
--- a/reportdesign/source/ui/inspection/metadata.cxx
+++ b/reportdesign/source/ui/inspection/metadata.cxx
@@ -25,6 +25,7 @@
 
 #include <algorithm>
 #include <string_view>
+#include <utility>
 
 namespace rptui
 {
@@ -45,19 +46,19 @@ namespace rptui
         PropUIFlags     nUIFlags;
 
         OPropertyInfoImpl(
-                        const OUString&        rName,
+                        OUString               aName,
                         sal_Int32              _nId,
-                        const OUString&        aTranslation,
-                        const OString&         _sHelpId,
+                        OUString               aTranslation,
+                        OString                _sHelpId,
                         PropUIFlags            _nUIFlags);
     };
 
 
-    OPropertyInfoImpl::OPropertyInfoImpl(const OUString& _rName, sal_Int32 _nId,
-                                   const OUString& aString, const OString& sHid, PropUIFlags _nUIFlags)
-       :sName(_rName)
-       ,sTranslation(aString)
-       ,sHelpId(sHid)
+    OPropertyInfoImpl::OPropertyInfoImpl(OUString _aName, sal_Int32 _nId,
+                                   OUString aString, OString sHid, PropUIFlags _nUIFlags)
+       :sName(std::move(_aName))
+       ,sTranslation(std::move(aString))
+       ,sHelpId(std::move(sHid))
        ,nId(_nId)
        ,nUIFlags(_nUIFlags)
     {
diff --git a/reportdesign/source/ui/misc/ColorListener.cxx b/reportdesign/source/ui/misc/ColorListener.cxx
index 48fa67902927..ab8c920c65c1 100644
--- a/reportdesign/source/ui/misc/ColorListener.cxx
+++ b/reportdesign/source/ui/misc/ColorListener.cxx
@@ -18,6 +18,7 @@
  */
 #include <ColorListener.hxx>
 #include <svl/hint.hxx>
+#include <utility>
 #include <vcl/settings.hxx>
 #include <vcl/event.hxx>
 
@@ -27,9 +28,9 @@
 namespace rptui
 {
 
-OColorListener::OColorListener(vcl::Window* _pParent ,const OUString& _sColorEntry)
+OColorListener::OColorListener(vcl::Window* _pParent ,OUString _sColorEntry)
 : Window(_pParent)
-,m_sColorEntry(_sColorEntry)
+,m_sColorEntry(std::move(_sColorEntry))
 ,m_nColor(COL_LIGHTBLUE)
 ,m_bCollapsed(false)
 ,m_bMarked(false)
diff --git a/reportdesign/source/ui/misc/FunctionHelper.cxx b/reportdesign/source/ui/misc/FunctionHelper.cxx
index 5475671781f9..f8ef011422c6 100644
--- a/reportdesign/source/ui/misc/FunctionHelper.cxx
+++ b/reportdesign/source/ui/misc/FunctionHelper.cxx
@@ -20,6 +20,7 @@
 #include <FunctionHelper.hxx>
 
 #include <o3tl/safeint.hxx>
+#include <utility>
 #include <tools/diagnose_ex.h>
 #include <formula/funcvarargs.h>
 
@@ -29,8 +30,8 @@ namespace rptui
 
     using namespace ::com::sun::star;
 
-FunctionManager::FunctionManager(const uno::Reference< report::meta::XFunctionManager>& _xMgr)
-: m_xMgr(_xMgr)
+FunctionManager::FunctionManager(uno::Reference< report::meta::XFunctionManager> _xMgr)
+: m_xMgr(std::move(_xMgr))
 {
 }
 FunctionManager::~FunctionManager()
@@ -132,8 +133,8 @@ OUString FunctionCategory::getName() const
     return m_xCategory->getName();
 }
 
-FunctionDescription::FunctionDescription(const formula::IFunctionCategory* _pFunctionCategory,const uno::Reference< report::meta::XFunctionDescription>& _xFunctionDescription)
-: m_xFunctionDescription(_xFunctionDescription)
+FunctionDescription::FunctionDescription(const formula::IFunctionCategory* _pFunctionCategory, uno::Reference< report::meta::XFunctionDescription> _xFunctionDescription)
+: m_xFunctionDescription(std::move(_xFunctionDescription))
 , m_pFunctionCategory(_pFunctionCategory)
 {
     m_aParameter = m_xFunctionDescription->getArguments();
diff --git a/reportdesign/source/ui/misc/RptUndo.cxx b/reportdesign/source/ui/misc/RptUndo.cxx
index 60d0927d640f..f55c4ba88260 100644
--- a/reportdesign/source/ui/misc/RptUndo.cxx
+++ b/reportdesign/source/ui/misc/RptUndo.cxx
@@ -315,11 +315,11 @@ void OGroupSectionUndo::implReRemove( )
 OGroupUndo::OGroupUndo(OReportModel& _rMod
                        ,TranslateId pCommentID
                        ,Action  _eAction
-                       ,const uno::Reference< report::XGroup>& _xGroup
-                       ,const uno::Reference< report::XReportDefinition >& _xReportDefinition)
+                       ,uno::Reference< report::XGroup> _xGroup
+                       ,uno::Reference< report::XReportDefinition > _xReportDefinition)
 : OCommentUndoAction(_rMod,pCommentID)
-,m_xGroup(_xGroup)
-,m_xReportDefinition(_xReportDefinition)
+,m_xGroup(std::move(_xGroup))
+,m_xReportDefinition(std::move(_xReportDefinition))
 ,m_eAction(_eAction)
 {
     m_nLastPosition = getPositionInIndexAccess(m_xReportDefinition->getGroups(),m_xGroup);
diff --git a/reportdesign/source/ui/report/ReportSection.cxx b/reportdesign/source/ui/report/ReportSection.cxx
index 95d063c1d9e2..ebbbad48c2e9 100644
--- a/reportdesign/source/ui/report/ReportSection.cxx
+++ b/reportdesign/source/ui/report/ReportSection.cxx
@@ -50,6 +50,7 @@
 #include <dlgedclip.hxx>
 #include <rptui_slotid.hrc>
 
+#include <utility>
 #include <vcl/commandevent.hxx>
 #include <o3tl/safeint.hxx>
 
@@ -69,14 +70,14 @@ static Color lcl_getOverlappedControlColor(/*const uno::Reference <lang::XMultiS
     return aConfig.GetColorValue(CFG_REPORTDESIGNER, DBOVERLAPPEDCONTROL).getColor();
 }
 
-OReportSection::OReportSection(OSectionWindow* _pParent,const uno::Reference< report::XSection >& _xSection)
+OReportSection::OReportSection(OSectionWindow* _pParent,uno::Reference< report::XSection > _xSection)
     : Window(_pParent,WB_DIALOGCONTROL)
     , ::comphelper::OPropertyChangeListener(m_aMutex)
     , DropTargetHelper(this)
     , m_pPage(nullptr)
     , m_pView(nullptr)
     , m_pParent(_pParent)
-    , m_xSection(_xSection)
+    , m_xSection(std::move(_xSection))
     , m_nPaintEntranceCount(0)
     , m_eMode(DlgEdMode::Select)
 {