loplugin:passstuffbyref in reportdesign

Change-Id: I6e024c3043e1fa9f618e96088581ade3c3a00c3c

15 files changed, 26 insertions, 26 deletions

diff --git a/reportdesign/inc/RptObject.hxx b/reportdesign/inc/RptObject.hxx
index f2ddca7fcced..6552ac81169f 100644
--- a/reportdesign/inc/RptObject.hxx
+++ b/reportdesign/inc/RptObject.hxx
@@ -109,10 +109,10 @@ public:
 
     bool        supportsService( const OUString& _sServiceName ) const;
 
-    css::uno::Reference< css::report::XReportComponent> getReportComponent() const { return m_xReportComponent;}
+    const css::uno::Reference< css::report::XReportComponent>& getReportComponent() const { return m_xReportComponent;}
     virtual css::uno::Reference< css::beans::XPropertySet> getAwtComponent();
     css::uno::Reference< css::report::XSection> getSection() const;
-    inline const OUString getServiceName() const { return m_sComponentName; }
+    const OUString& getServiceName() const { return m_sComponentName; }
 
     /** releases the reference to our UNO shape (m_xKeepShapeAlive)
     */
diff --git a/reportdesign/inc/RptPage.hxx b/reportdesign/inc/RptPage.hxx
index 5307ba3b6317..352a95ba0a92 100644
--- a/reportdesign/inc/RptPage.hxx
+++ b/reportdesign/inc/RptPage.hxx
@@ -83,7 +83,7 @@ public:
     */
     void insertObject(const css::uno::Reference< css::report::XReportComponent >& _xObject);
 
-    css::uno::Reference< css::report::XSection > getSection() const { return m_xSection;}
+    const css::uno::Reference< css::report::XSection >& getSection() const { return m_xSection;}
 };
 }
 #endif // INCLUDED_REPORTDESIGN_INC_RPTPAGE_HXX
diff --git a/reportdesign/inc/UndoActions.hxx b/reportdesign/inc/UndoActions.hxx
index 89e667d2f31a..b9728febec95 100644
--- a/reportdesign/inc/UndoActions.hxx
+++ b/reportdesign/inc/UndoActions.hxx
@@ -70,7 +70,7 @@ namespace rptui
         }
         inline css::uno::Reference< css::report::XSection >   getHeader() { return m_xGroup->getHeader(); }
         inline css::uno::Reference< css::report::XSection >   getFooter() { return m_xGroup->getFooter(); }
-        inline css::uno::Reference< css::report::XGroup >     getGroup() { return m_xGroup; }
+        const css::uno::Reference< css::report::XGroup >&     getGroup() { return m_xGroup; }
 
         inline bool getHeaderOn() { return m_xGroup->getHeaderOn(); }
         inline bool getFooterOn() { return m_xGroup->getFooterOn(); }
diff --git a/reportdesign/source/core/inc/Group.hxx b/reportdesign/source/core/inc/Group.hxx
index 5beb160c4e57..e637f22f612a 100644
--- a/reportdesign/source/core/inc/Group.hxx
+++ b/reportdesign/source/core/inc/Group.hxx
@@ -160,7 +160,7 @@ namespace reportdesign
             cppu::WeakComponentImplHelperBase::removeEventListener(aListener);
         }
 
-        css::uno::Reference< css::uno::XComponentContext > getContext(){ return m_xContext; }
+        const css::uno::Reference< css::uno::XComponentContext >& getContext(){ return m_xContext; }
     };
 
 } // namespace reportdesign
diff --git a/reportdesign/source/filter/xml/xmlExport.hxx b/reportdesign/source/filter/xml/xmlExport.hxx
index c2942d7f225d..534fabe636e0 100644
--- a/reportdesign/source/filter/xml/xmlExport.hxx
+++ b/reportdesign/source/filter/xml/xmlExport.hxx
@@ -167,9 +167,9 @@ public:
     // XExporter
     virtual void SAL_CALL setSourceDocument( const css::uno::Reference< css::lang::XComponent >& xDoc ) throw(css::lang::IllegalArgumentException, css::uno::RuntimeException, std::exception) override;
 
-    inline Reference<XReportDefinition> getReportDefinition() const { return m_xReportDefinition; }
+    const Reference<XReportDefinition>& getReportDefinition() const { return m_xReportDefinition; }
 
-    rtl::Reference < XMLPropertySetMapper > GetCellStylePropertyMapper() const { return m_xCellStylesPropertySetMapper;}
+    const rtl::Reference < XMLPropertySetMapper >& GetCellStylePropertyMapper() const { return m_xCellStylesPropertySetMapper;}
 };
 
 /** Exports only settings
diff --git a/reportdesign/source/filter/xml/xmlTable.hxx b/reportdesign/source/filter/xml/xmlTable.hxx
index 596148d05d95..4139d96ff877 100644
--- a/reportdesign/source/filter/xml/xmlTable.hxx
+++ b/reportdesign/source/filter/xml/xmlTable.hxx
@@ -79,7 +79,7 @@ namespace rptxml
 
         void addCell(const css::uno::Reference< css::report::XReportComponent>& _xElement);
 
-        inline css::uno::Reference< css::report::XSection > getSection() const { return m_xSection; }
+        const css::uno::Reference< css::report::XSection >& getSection() const { return m_xSection; }
     };
 
 } // namespace rptxml
diff --git a/reportdesign/source/filter/xml/xmlfilter.cxx b/reportdesign/source/filter/xml/xmlfilter.cxx
index 5b7c20501b4c..57a2c22ec7ae 100644
--- a/reportdesign/source/filter/xml/xmlfilter.cxx
+++ b/reportdesign/source/filter/xml/xmlfilter.cxx
@@ -961,7 +961,7 @@ void ORptFilter::FinishStyles()
         GetStyles()->FinishStyles( true );
 }
 
-OUString ORptFilter::convertFormula(const OUString& _sFormula)
+const OUString& ORptFilter::convertFormula(const OUString& _sFormula)
 {
     return _sFormula;
 }
diff --git a/reportdesign/source/filter/xml/xmlfilter.hxx b/reportdesign/source/filter/xml/xmlfilter.hxx
index 24a47dd8bba4..4ab619bfb79b 100644
--- a/reportdesign/source/filter/xml/xmlfilter.hxx
+++ b/reportdesign/source/filter/xml/xmlfilter.hxx
@@ -120,7 +120,7 @@ public:
     static css::uno::Reference< css::uno::XInterface > SAL_CALL
     create(css::uno::Reference< css::uno::XComponentContext > const & xContext);
 
-    inline Reference<XReportDefinition> getReportDefinition() const {
+    const Reference<XReportDefinition>& getReportDefinition() const {
         return m_xReportDefinition;
     }
     void FinishStyles();
@@ -144,16 +144,16 @@ public:
     const SvXMLTokenMap& GetColumnTokenMap() const;
     const SvXMLTokenMap& GetCellElemTokenMap() const;
 
-    inline rtl::Reference < XMLPropertySetMapper > GetCellStylesPropertySetMapper()      const   {
+    const rtl::Reference< XMLPropertySetMapper >& GetCellStylesPropertySetMapper()      const   {
         return m_xCellStylesPropertySetMapper;
     }
-    inline rtl::Reference < XMLPropertySetMapper > GetColumnStylesPropertySetMapper()    const   {
+    const rtl::Reference< XMLPropertySetMapper >& GetColumnStylesPropertySetMapper()    const   {
         return m_xColumnStylesPropertySetMapper;
     }
-    inline rtl::Reference < XMLPropertySetMapper > GetRowStylesPropertySetMapper()       const   {
+    const rtl::Reference< XMLPropertySetMapper >& GetRowStylesPropertySetMapper()       const   {
         return m_xRowStylesPropertySetMapper;
     }
-    static OUString convertFormula(const OUString& _sFormula);
+    static const OUString& convertFormula(const OUString& _sFormula);
     /** inserts a new function
     *
     * \param _xFunction
diff --git a/reportdesign/source/ui/dlg/Navigator.cxx b/reportdesign/source/ui/dlg/Navigator.cxx
index d491ae70773f..d95062cfd8c5 100644
--- a/reportdesign/source/ui/dlg/Navigator.cxx
+++ b/reportdesign/source/ui/dlg/Navigator.cxx
@@ -125,7 +125,7 @@ class NavigatorTree :   public ::cppu::BaseMutex
         UserData(NavigatorTree* _pTree,const uno::Reference<uno::XInterface>& _xContent);
         virtual ~UserData();
 
-        inline uno::Reference< uno::XInterface > getContent() const { return m_xContent; }
+        const uno::Reference< uno::XInterface >& getContent() const { return m_xContent; }
         inline void setContent(const uno::Reference< uno::XInterface >& _xContent) { m_xContent = _xContent; }
 
     protected:
diff --git a/reportdesign/source/ui/inc/DesignView.hxx b/reportdesign/source/ui/inc/DesignView.hxx
index 106dde515dd0..00334fc58c70 100644
--- a/reportdesign/source/ui/inc/DesignView.hxx
+++ b/reportdesign/source/ui/inc/DesignView.hxx
@@ -164,8 +164,8 @@ namespace rptui
                                     ,const OUString& _sColorEntry
                                     ,sal_uInt16 _nPosition = USHRT_MAX);
 
-        inline Size     getGridSizeCoarse() const { return m_aGridSizeCoarse; }
-        inline Size     getGridSizeFine() const { return m_aGridSizeFine; }
+        const Size&     getGridSizeCoarse() const { return m_aGridSizeCoarse; }
+        const Size&     getGridSizeFine() const { return m_aGridSizeFine; }
         inline bool     isGridSnap() const { return m_bGridSnap; }
         void            setGridSnap(bool bOn);
         void            setDragStripes(bool bOn);
diff --git a/reportdesign/source/ui/inc/GeometryHandler.hxx b/reportdesign/source/ui/inc/GeometryHandler.hxx
index 9d84ae9b34a0..da73d235e4a0 100644
--- a/reportdesign/source/ui/inc/GeometryHandler.hxx
+++ b/reportdesign/source/ui/inc/GeometryHandler.hxx
@@ -51,7 +51,7 @@ namespace rptui
         bool                                          m_bPreEvaluated;
         bool                                          m_bDeepTraversing;
 
-        inline OUString getName() const { return m_sName; }
+        const OUString& getName() const { return m_sName; }
     } ;
 
     class OPropertyInfoService;
diff --git a/reportdesign/source/ui/inc/ReportController.hxx b/reportdesign/source/ui/inc/ReportController.hxx
index 8df96aa6e920..3342b75cab07 100644
--- a/reportdesign/source/ui/inc/ReportController.hxx
+++ b/reportdesign/source/ui/inc/ReportController.hxx
@@ -392,7 +392,7 @@ namespace rptui
         /** gives access to the report definition
         * \return the report definition object, may be <NULL/>
         */
-        inline css::uno::Reference< css::report::XReportDefinition> getReportDefinition() const { return m_xReportDefinition; }
+        const css::uno::Reference< css::report::XReportDefinition>& getReportDefinition() const { return m_xReportDefinition; }
 
         // css::frame::XController
         virtual css::uno::Reference< css::frame::XModel >  SAL_CALL getModel() throw( css::uno::RuntimeException, std::exception ) override;
@@ -435,15 +435,15 @@ namespace rptui
 
         /** returns the number formatter
         */
-        css::uno::Reference< css::util::XNumberFormatter >    getReportNumberFormatter() const { return m_xFormatter;}
+        const css::uno::Reference< css::util::XNumberFormatter >& getReportNumberFormatter() const { return m_xFormatter;}
 
         /** return the SdrModel of the real model
         *
         * \return
         */
-        std::shared_ptr<rptui::OReportModel> getSdrModel() const { return m_aReportModel;}
+        const std::shared_ptr<rptui::OReportModel>& getSdrModel() const { return m_aReportModel;}
 
-        inline css::uno::Reference< css::uno::XComponentContext >  getContext() const { return m_xContext; }
+        const css::uno::Reference< css::uno::XComponentContext >&  getContext() const { return m_xContext; }
         inline sal_Int16   getZoomValue() const     { return m_nZoomValue; }
         inline void         resetZoomType()         { m_eZoomType = SvxZoomType::PERCENT; }
 
diff --git a/reportdesign/source/ui/inc/ReportSection.hxx b/reportdesign/source/ui/inc/ReportSection.hxx
index 3cc2db97fffb..22f4289434d6 100644
--- a/reportdesign/source/ui/inc/ReportSection.hxx
+++ b/reportdesign/source/ui/inc/ReportSection.hxx
@@ -116,7 +116,7 @@ namespace rptui
         inline OSectionWindow*      getSectionWindow() const { return m_pParent; }
         inline OSectionView&        getSectionView() const { return *m_pView; }
         inline OReportPage*         getPage() const { return m_pPage; }
-        inline css::uno::Reference< css::report::XSection > getSection() const { return m_xSection; }
+        const css::uno::Reference< css::report::XSection >& getSection() const { return m_xSection; }
 
         DlgEdMode       GetMode() const { return m_eMode; }
         void            SetMode( DlgEdMode m_eMode );
diff --git a/reportdesign/source/ui/inc/ScrollHelper.hxx b/reportdesign/source/ui/inc/ScrollHelper.hxx
index c63dc5724a1f..3e1a63d3d2f1 100644
--- a/reportdesign/source/ui/inc/ScrollHelper.hxx
+++ b/reportdesign/source/ui/inc/ScrollHelper.hxx
@@ -81,7 +81,7 @@ namespace rptui
 
         inline Point            getThumbPos() const { return Point(m_aHScroll->GetThumbPos(),m_aVScroll->GetThumbPos())/*m_aScrollOffset*/; }
         void                    setTotalSize(sal_Int32 _nWidth, sal_Int32 _nHeight);
-        inline Size             getTotalSize() const { return m_aTotalPixelSize; }
+        const Size&             getTotalSize() const { return m_aTotalPixelSize; }
         inline ScrollBar&       GetHScroll() { return *m_aHScroll.get(); }
         inline ScrollBar&       GetVScroll() { return *m_aVScroll.get(); }
 
diff --git a/reportdesign/source/ui/inc/ViewsWindow.hxx b/reportdesign/source/ui/inc/ViewsWindow.hxx
index 982715bc59fd..d97a5be109d3 100644
--- a/reportdesign/source/ui/inc/ViewsWindow.hxx
+++ b/reportdesign/source/ui/inc/ViewsWindow.hxx
@@ -183,7 +183,7 @@ namespace rptui
         inline bool     empty() const { return m_aSections.empty(); }
         void            SetMode( DlgEdMode m_eMode );
         void            SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType = OUString());
-        OUString   GetInsertObjString() const { return m_sShapeType;}
+        const OUString& GetInsertObjString() const { return m_sShapeType;}
         /** copies the current selection in this section
         */
         void Copy();
@@ -257,7 +257,7 @@ namespace rptui
         *
         * \return \member m_sShapeType
         */
-        inline OUString getShapeType() const { return m_sShapeType; }
+        const OUString& getShapeType() const { return m_sShapeType; }
 
         /** returns the current position in the list
         */