summaryrefslogtreecommitdiff
path: root/reportdesign
diff options
context:
space:
mode:
authorNoel Grandin <noelgrandin@gmail.com>2016-03-29 10:25:17 +0200
committerNoel Grandin <noel@peralex.com>2016-03-31 11:30:36 +0200
commit6439005484bdf6754b910b1ce025b3fb33b6623f (patch)
tree1a00f48ae11d3da3d928f2d3d68b3e299216328c /reportdesign
parent1aa4df615fa5599d05e9dd5e925b5852676185fa (diff)
use SAL_N_ELEMENTS more widely
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
Diffstat (limited to 'reportdesign')
-rw-r--r--reportdesign/source/core/api/FixedLine.cxx2
-rw-r--r--reportdesign/source/core/api/FixedText.cxx3
-rw-r--r--reportdesign/source/core/api/FormattedField.cxx2
-rw-r--r--reportdesign/source/core/api/ImageControl.cxx2
-rw-r--r--reportdesign/source/core/api/ReportDefinition.cxx4
-rw-r--r--reportdesign/source/core/api/Section.cxx12
-rw-r--r--reportdesign/source/core/api/Shape.cxx4
-rw-r--r--reportdesign/source/ui/inspection/DefaultInspection.cxx4
-rw-r--r--reportdesign/source/ui/misc/UITools.cxx2
-rw-r--r--reportdesign/source/ui/report/ReportController.cxx4
-rw-r--r--reportdesign/source/ui/report/propbrw.cxx2
11 files changed, 21 insertions, 20 deletions
diff --git a/reportdesign/source/core/api/FixedLine.cxx b/reportdesign/source/core/api/FixedLine.cxx
index 3adbba16ddda..a8102db79718 100644
--- a/reportdesign/source/core/api/FixedLine.cxx
+++ b/reportdesign/source/core/api/FixedLine.cxx
@@ -124,7 +124,7 @@ uno::Sequence< OUString > lcl_getLineOptionals()
};
- return uno::Sequence< OUString >(pProps,sizeof(pProps)/sizeof(pProps[0]));
+ return uno::Sequence< OUString >(pProps,SAL_N_ELEMENTS(pProps));
}
OFixedLine::OFixedLine(uno::Reference< uno::XComponentContext > const & _xContext)
diff --git a/reportdesign/source/core/api/FixedText.cxx b/reportdesign/source/core/api/FixedText.cxx
index a58030bb346c..0a11eaed06c6 100644
--- a/reportdesign/source/core/api/FixedText.cxx
+++ b/reportdesign/source/core/api/FixedText.cxx
@@ -36,10 +36,11 @@ namespace reportdesign
using namespace com::sun::star;
using namespace comphelper;
+
uno::Sequence< OUString > lcl_getFixedTextOptionals()
{
OUString pProps[] = { OUString(PROPERTY_DATAFIELD),OUString(PROPERTY_MASTERFIELDS),OUString(PROPERTY_DETAILFIELDS) };
- return uno::Sequence< OUString >(pProps,sizeof(pProps)/sizeof(pProps[0]));
+ return uno::Sequence< OUString >(pProps,SAL_N_ELEMENTS(pProps));
}
OFixedText::OFixedText(uno::Reference< uno::XComponentContext > const & _xContext)
diff --git a/reportdesign/source/core/api/FormattedField.cxx b/reportdesign/source/core/api/FormattedField.cxx
index da050bd73dac..61905623ed5c 100644
--- a/reportdesign/source/core/api/FormattedField.cxx
+++ b/reportdesign/source/core/api/FormattedField.cxx
@@ -46,7 +46,7 @@ uno::Reference< uno::XInterface > OFormattedField::create(uno::Reference< uno::X
uno::Sequence< OUString > lcl_getFormattedFieldOptionals()
{
OUString pProps[] = { OUString(PROPERTY_MASTERFIELDS),OUString(PROPERTY_DETAILFIELDS) };
- return uno::Sequence< OUString >(pProps,sizeof(pProps)/sizeof(pProps[0]));
+ return uno::Sequence< OUString >(pProps,SAL_N_ELEMENTS(pProps));
}
OFormattedField::OFormattedField(uno::Reference< uno::XComponentContext > const & _xContext)
diff --git a/reportdesign/source/core/api/ImageControl.cxx b/reportdesign/source/core/api/ImageControl.cxx
index faf823eabafa..ad9645733ce9 100644
--- a/reportdesign/source/core/api/ImageControl.cxx
+++ b/reportdesign/source/core/api/ImageControl.cxx
@@ -109,7 +109,7 @@ uno::Sequence< OUString > lcl_getImageOptionals()
, OUString(PROPERTY_CHARLOCALECOMPLEX)
};
- return uno::Sequence< OUString >(pProps,sizeof(pProps)/sizeof(pProps[0]));
+ return uno::Sequence< OUString >(pProps,SAL_N_ELEMENTS(pProps));
}
diff --git a/reportdesign/source/core/api/ReportDefinition.cxx b/reportdesign/source/core/api/ReportDefinition.cxx
index 4babedf66051..db18d3f4b4cf 100644
--- a/reportdesign/source/core/api/ReportDefinition.cxx
+++ b/reportdesign/source/core/api/ReportDefinition.cxx
@@ -1686,7 +1686,7 @@ void SAL_CALL OReportDefinition::load( const uno::Sequence< beans::PropertyValue
aArguments.get_ensureType( "ReadOnly", bReadOnly );
nFirstOpenMode = bReadOnly ? 1 : 0;
}
- const size_t nLastOpenMode = sizeof( nOpenModes ) / sizeof( nOpenModes[0] ) - 1;
+ const size_t nLastOpenMode = SAL_N_ELEMENTS( nOpenModes ) - 1;
for ( size_t i=nFirstOpenMode; i <= nLastOpenMode; ++i )
{
uno::Sequence< uno::Any > aStorageCreationArgs(2);
@@ -2249,7 +2249,7 @@ uno::Sequence< OUString > SAL_CALL OReportDefinition::getAvailableServiceNames()
OUString("com.sun.star.drawing.MarkerTable")
};
- static const sal_uInt16 nSvxComponentServiceNameListCount = sizeof(aSvxComponentServiceNameList) / sizeof ( aSvxComponentServiceNameList[0] );
+ static const sal_uInt16 nSvxComponentServiceNameListCount = SAL_N_ELEMENTS(aSvxComponentServiceNameList);
uno::Sequence< OUString > aSeq( nSvxComponentServiceNameListCount );
OUString* pStrings = aSeq.getArray();
diff --git a/reportdesign/source/core/api/Section.cxx b/reportdesign/source/core/api/Section.cxx
index f203f890fe4b..1b5199d3009d 100644
--- a/reportdesign/source/core/api/Section.cxx
+++ b/reportdesign/source/core/api/Section.cxx
@@ -48,12 +48,12 @@ namespace reportdesign
uno::Sequence< OUString> lcl_getGroupAbsent()
{
- OUString pProps[] = {
+ const OUString pProps[] = {
OUString(PROPERTY_CANGROW)
,OUString(PROPERTY_CANSHRINK)
};
- return uno::Sequence< OUString >(pProps,sizeof(pProps)/sizeof(pProps[0]));
+ return uno::Sequence< OUString >(pProps,SAL_N_ELEMENTS(pProps));
}
@@ -61,7 +61,7 @@ uno::Sequence< OUString> lcl_getAbsent(bool _bPageSection)
{
if ( _bPageSection )
{
- OUString pProps[] = {
+ const OUString pProps[] = {
OUString(PROPERTY_FORCENEWPAGE)
,OUString(PROPERTY_NEWROWORCOL)
,OUString(PROPERTY_KEEPTOGETHER)
@@ -69,16 +69,16 @@ uno::Sequence< OUString> lcl_getAbsent(bool _bPageSection)
,OUString(PROPERTY_CANSHRINK)
,OUString(PROPERTY_REPEATSECTION)
};
- return uno::Sequence< OUString >(pProps,sizeof(pProps)/sizeof(pProps[0]));
+ return uno::Sequence< OUString >(pProps,SAL_N_ELEMENTS(pProps));
}
- OUString pProps[] = {
+ const OUString pProps[] = {
OUString(PROPERTY_CANGROW)
,OUString(PROPERTY_CANSHRINK)
,OUString(PROPERTY_REPEATSECTION)
};
- return uno::Sequence< OUString >(pProps,sizeof(pProps)/sizeof(pProps[0]));
+ return uno::Sequence< OUString >(pProps,SAL_N_ELEMENTS(pProps));
}
uno::Reference<report::XSection> OSection::createOSection(
diff --git a/reportdesign/source/core/api/Shape.cxx b/reportdesign/source/core/api/Shape.cxx
index e02132b5f8c5..3ee21c955646 100644
--- a/reportdesign/source/core/api/Shape.cxx
+++ b/reportdesign/source/core/api/Shape.cxx
@@ -43,12 +43,12 @@ namespace reportdesign
using namespace comphelper;
uno::Sequence< OUString > lcl_getShapeOptionals()
{
- OUString pProps[] = {
+ const OUString pProps[] = {
OUString(PROPERTY_DATAFIELD)
,OUString(PROPERTY_CONTROLBACKGROUND)
,OUString(PROPERTY_CONTROLBACKGROUNDTRANSPARENT)
};
- return uno::Sequence< OUString >(pProps,sizeof(pProps)/sizeof(pProps[0]));
+ return uno::Sequence< OUString >(pProps,SAL_N_ELEMENTS(pProps));
}
diff --git a/reportdesign/source/ui/inspection/DefaultInspection.cxx b/reportdesign/source/ui/inspection/DefaultInspection.cxx
index 766660acf4e1..cd68746685b1 100644
--- a/reportdesign/source/ui/inspection/DefaultInspection.cxx
+++ b/reportdesign/source/ui/inspection/DefaultInspection.cxx
@@ -116,7 +116,7 @@ namespace rptui
};
- const size_t nFactories = sizeof( aFactories ) / sizeof( aFactories[ 0 ] );
+ const size_t nFactories = SAL_N_ELEMENTS( aFactories );
Sequence< Any > aReturn( nFactories );
Any* pReturn = aReturn.getArray();
for ( size_t i = 0; i < nFactories; ++i )
@@ -214,7 +214,7 @@ namespace rptui
{ "Data", RID_STR_PROPPAGE_DATA, HID_RPT_PROPDLG_TAB_DATA },
};
- const size_t nCategories = sizeof( aCategories ) / sizeof( aCategories[0] );
+ const size_t nCategories = SAL_N_ELEMENTS( aCategories );
Sequence< PropertyCategoryDescriptor > aReturn( nCategories );
PropertyCategoryDescriptor* pReturn = aReturn.getArray();
for ( size_t i=0; i<nCategories; ++i, ++pReturn )
diff --git a/reportdesign/source/ui/misc/UITools.cxx b/reportdesign/source/ui/misc/UITools.cxx
index 007892cee423..4ab8226d84c8 100644
--- a/reportdesign/source/ui/misc/UITools.cxx
+++ b/reportdesign/source/ui/misc/UITools.cxx
@@ -693,7 +693,7 @@ bool openCharDialog( const uno::Reference<report::XReportControlFormat >& _rxRep
};
- OSL_ASSERT((sizeof(pDefaults)/sizeof(pDefaults[0])) == (sizeof(aItemInfos)/sizeof(aItemInfos[0])));
+ OSL_ASSERT( SAL_N_ELEMENTS(pDefaults) == SAL_N_ELEMENTS(aItemInfos) );
static const sal_uInt16 pRanges[] =
{
diff --git a/reportdesign/source/ui/report/ReportController.cxx b/reportdesign/source/ui/report/ReportController.cxx
index 8b42e4017233..5d36d3236b12 100644
--- a/reportdesign/source/ui/report/ReportController.cxx
+++ b/reportdesign/source/ui/report/ReportController.cxx
@@ -3689,7 +3689,7 @@ void OReportController::listen(const bool _bAdd)
const beans::Property* pIter = aSeq.getConstArray();
const beans::Property* pEnd = pIter + aSeq.getLength();
const OUString* pPropsBegin = &aProps[0];
- const OUString* pPropsEnd = pPropsBegin + (sizeof(aProps)/sizeof(aProps[0])) - 3;
+ const OUString* pPropsEnd = pPropsBegin + SAL_N_ELEMENTS(aProps) - 3;
for(;pIter != pEnd;++pIter)
{
if ( ::std::find(pPropsBegin,pPropsEnd,pIter->Name) == pPropsEnd )
@@ -4075,7 +4075,7 @@ css::uno::Sequence< OUString > SAL_CALL OReportController::getSupportedModes( )
{
static const OUString s_sModes[] = { OUString("remote"),
OUString("normal") };
- return uno::Sequence< OUString> (&s_sModes[0],sizeof(s_sModes)/sizeof(s_sModes[0]));
+ return uno::Sequence< OUString> (&s_sModes[0],SAL_N_ELEMENTS(s_sModes));
}
sal_Bool SAL_CALL OReportController::supportsMode( const OUString& aMode ) throw (css::uno::RuntimeException, std::exception)
{
diff --git a/reportdesign/source/ui/report/propbrw.cxx b/reportdesign/source/ui/report/propbrw.cxx
index 64461637c975..c6d3297908af 100644
--- a/reportdesign/source/ui/report/propbrw.cxx
+++ b/reportdesign/source/ui/report/propbrw.cxx
@@ -122,7 +122,7 @@ PropBrw::PropBrw(const Reference< XComponentContext >& _xORB, vcl::Window* pPare
::cppu::ContextEntry_Init( OUString( "ActiveConnection" ), makeAny( m_pDesignView->getController().getConnection() ) ),
};
m_xInspectorContext.set(
- ::cppu::createComponentContext( aHandlerContextInfo, sizeof( aHandlerContextInfo ) / sizeof( aHandlerContextInfo[0] ),
+ ::cppu::createComponentContext( aHandlerContextInfo, SAL_N_ELEMENTS( aHandlerContextInfo ),
m_xORB ) );
// create a property browser controller
bool bEnableHelpSection = lcl_shouldEnableHelpSection( m_xORB );