loplugin:passstuffbyref improved return in sd,various

Change-Id: I4b6ea89ae2072f4389a696ea3c96d8f7a5731e7a
Reviewed-on: https://gerrit.libreoffice.org/47246
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 10 insertions, 10 deletions

diff --git a/reportdesign/inc/reportformula.hxx b/reportdesign/inc/reportformula.hxx
index 7d10243aee86..5e5976a075b9 100644
--- a/reportdesign/inc/reportformula.hxx
+++ b/reportdesign/inc/reportformula.hxx
@@ -77,7 +77,7 @@ namespace rptui
         const OUString& getUndecoratedContent() const { return m_sUndecoratedContent; }
 
         /// convenience alias for <code>getUndecoratedContent</code>, which asserts (in a non-product build) when used on an expression
-        inline OUString  getFieldName() const;
+        inline OUString const & getFieldName() const;
 
         /**
             @returns "=" + getFieldName()
@@ -85,7 +85,7 @@ namespace rptui
         OUString getEqualUndecoratedContent() const;
 
         /// convenience alias for <code>getUndecoratedContent</code>, which asserts (in a non-product build) when used on a field
-        inline OUString  getExpression() const;
+        inline OUString const & getExpression() const;
 
         /** returns a bracketed field name of the formula denotes a field reference,
             or the undecorated expression if the formula denotes an expression.
@@ -100,14 +100,14 @@ namespace rptui
     };
 
 
-    inline OUString ReportFormula::getFieldName() const
+    inline OUString const & ReportFormula::getFieldName() const
     {
         OSL_PRECOND( getType() == Field, "ReportFormula::getFieldName: not bound to a field!" );
         return getUndecoratedContent();
     }
 
 
-    inline OUString ReportFormula::getExpression() const
+    inline OUString const & ReportFormula::getExpression() const
     {
         OSL_PRECOND( getType() == Expression, "ReportFormula::getExpression: not bound to an expression!" );
         return getUndecoratedContent();
diff --git a/reportdesign/source/ui/inc/DesignView.hxx b/reportdesign/source/ui/inc/DesignView.hxx
index 898821be753d..07e01d0d2b79 100644
--- a/reportdesign/source/ui/inc/DesignView.hxx
+++ b/reportdesign/source/ui/inc/DesignView.hxx
@@ -107,7 +107,7 @@ namespace rptui
         void            SetMode( DlgEdMode m_eMode );
         void            SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType = OUString());
         sal_uInt16          GetInsertObj() const { return m_eActObj;}
-        OUString   GetInsertObjString() const;
+        OUString const &    GetInsertObjString() const;
         DlgEdMode       GetMode() const { return m_eMode; }
 
         /** cuts the current selection in this section
diff --git a/reportdesign/source/ui/inc/ReportWindow.hxx b/reportdesign/source/ui/inc/ReportWindow.hxx
index dc00f4c3f91e..a474ca258e8d 100644
--- a/reportdesign/source/ui/inc/ReportWindow.hxx
+++ b/reportdesign/source/ui/inc/ReportWindow.hxx
@@ -77,7 +77,7 @@ namespace rptui
 
         void            SetMode( DlgEdMode m_eMode );
         void            SetInsertObj( sal_uInt16 eObj, const OUString& _sShapeType);
-        OUString        GetInsertObjString() const;
+        OUString const & GetInsertObjString() const;
         void            setGridSnap(bool bOn);
         void            setDragStripes(bool bOn);
 
diff --git a/reportdesign/source/ui/inc/ScrollHelper.hxx b/reportdesign/source/ui/inc/ScrollHelper.hxx
index 6ddcf52247ed..14dbb87130a2 100644
--- a/reportdesign/source/ui/inc/ScrollHelper.hxx
+++ b/reportdesign/source/ui/inc/ScrollHelper.hxx
@@ -88,7 +88,7 @@ namespace rptui
         // forwards
         void                    SetMode( DlgEdMode _eMode );
         void                    SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType);
-        OUString                GetInsertObjString() const;
+        OUString const &        GetInsertObjString() const;
         void                    setGridSnap(bool bOn);
         void                    setDragStripes(bool bOn);
         /** copies the current selection in this section
diff --git a/reportdesign/source/ui/report/DesignView.cxx b/reportdesign/source/ui/report/DesignView.cxx
index cf550e6de4ad..1170439603ee 100644
--- a/reportdesign/source/ui/report/DesignView.cxx
+++ b/reportdesign/source/ui/report/DesignView.cxx
@@ -294,7 +294,7 @@ void ODesignView::SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType )
     m_aScrollWindow->SetInsertObj( eObj,_sShapeType );
 }
 
-OUString ODesignView::GetInsertObjString() const
+OUString const & ODesignView::GetInsertObjString() const
 {
     return m_aScrollWindow->GetInsertObjString();
 }
diff --git a/reportdesign/source/ui/report/ReportWindow.cxx b/reportdesign/source/ui/report/ReportWindow.cxx
index 97f88c0189d2..e6ddb124219d 100644
--- a/reportdesign/source/ui/report/ReportWindow.cxx
+++ b/reportdesign/source/ui/report/ReportWindow.cxx
@@ -102,7 +102,7 @@ void OReportWindow::SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeType )
     m_aViewsWindow->SetInsertObj( eObj,_sShapeType);
 }
 
-OUString OReportWindow::GetInsertObjString() const
+OUString const & OReportWindow::GetInsertObjString() const
 {
     return m_aViewsWindow->GetInsertObjString();
 }
diff --git a/reportdesign/source/ui/report/ScrollHelper.cxx b/reportdesign/source/ui/report/ScrollHelper.cxx
index 9d054ea15467..ce6b589f72c3 100644
--- a/reportdesign/source/ui/report/ScrollHelper.cxx
+++ b/reportdesign/source/ui/report/ScrollHelper.cxx
@@ -224,7 +224,7 @@ void OScrollWindowHelper::SetInsertObj( sal_uInt16 eObj,const OUString& _sShapeT
     m_aReportWindow->SetInsertObj(eObj,_sShapeType);
 }
 
-OUString OScrollWindowHelper::GetInsertObjString() const
+OUString const & OScrollWindowHelper::GetInsertObjString() const
 {
     return m_aReportWindow->GetInsertObjString();
 }