diff options
| author | Noel Grandin <noel@peralex.com> | 2014-05-05 08:00:36 +0200 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2014-05-08 09:19:25 +0000 |
| commit | ff1a7a59434f5f793d4044aad615bcf78148e963 (patch) | |
| tree | 9f64199265f4bace340fad6abc400b642c5e2612 /reportdesign | |
| parent | 10314b5d8b653864c92d392cbb774438633b2fe1 (diff) | |
RFC: add IsValueChangedFromSaved to VCL button and listbox
Add a method
bool IsValueChangedFromSaved()
to the various Button and Listbox classes.
Use it to simplify code like
if ( maBoldAppFont.GetSavedValue() !=
TriState(maBoldAppFont.IsChecked()) )
to
if ( maBoldAppFont.IsValueChangedFromSaved() )
Change-Id: I26b291d0980237497063ee301d63a49c7d2bc227
Reviewed-on: https://gerrit.libreoffice.org/9250
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'reportdesign')
| -rw-r--r-- | reportdesign/source/ui/dlg/GroupsSorting.cxx | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/reportdesign/source/ui/dlg/GroupsSorting.cxx b/reportdesign/source/ui/dlg/GroupsSorting.cxx index cc18b17353a8..441658bd1ff9 100644 --- a/reportdesign/source/ui/dlg/GroupsSorting.cxx +++ b/reportdesign/source/ui/dlg/GroupsSorting.cxx @@ -1071,23 +1071,23 @@ void OGroupsSortingDialog::SaveData( sal_Int32 _nRow) return; uno::Reference< report::XGroup> xGroup = getGroup(nGroupPos); - if ( m_aHeaderLst.GetSavedValue() != m_aHeaderLst.GetSelectEntryPos() ) + if ( m_aHeaderLst.IsValueChangedFromSaved() ) xGroup->setHeaderOn( m_aHeaderLst.GetSelectEntryPos() == 0 ); - if ( m_aFooterLst.GetSavedValue() != m_aFooterLst.GetSelectEntryPos() ) + if ( m_aFooterLst.IsValueChangedFromSaved() ) xGroup->setFooterOn( m_aFooterLst.GetSelectEntryPos() == 0 ); - if ( m_aKeepTogetherLst.GetSavedValue() != m_aKeepTogetherLst.GetSelectEntryPos() ) + if ( m_aKeepTogetherLst.IsValueChangedFromSaved() ) xGroup->setKeepTogether( m_aKeepTogetherLst.GetSelectEntryPos() ); - if ( m_aGroupOnLst.GetSavedValue() != m_aGroupOnLst.GetSelectEntryPos() ) + if ( m_aGroupOnLst.IsValueChangedFromSaved() ) { sal_Int16 nGroupOn = static_cast<sal_Int16>(reinterpret_cast<sal_IntPtr>(m_aGroupOnLst.GetEntryData(m_aGroupOnLst.GetSelectEntryPos()))); xGroup->setGroupOn( nGroupOn ); } - if ( m_aGroupIntervalEd.GetSavedValue().toInt32() != m_aGroupIntervalEd.GetValue() ) + if ( m_aGroupIntervalEd.IsValueChangedFromSaved() ) { xGroup->setGroupInterval( static_cast<sal_Int32>(m_aGroupIntervalEd.GetValue()) ); m_aGroupIntervalEd.SaveValue(); } - if ( m_aOrderLst.GetSavedValue() != m_aOrderLst.GetSelectEntryPos() ) + if ( m_aOrderLst.IsValueChangedFromSaved() ) xGroup->setSortAscending( m_aOrderLst.GetSelectEntryPos() == 0 ); ListBox* pControls[] = { &m_aHeaderLst,&m_aFooterLst,&m_aGroupOnLst,&m_aKeepTogetherLst,&m_aOrderLst}; @@ -1196,13 +1196,13 @@ IMPL_LINK( OGroupsSortingDialog, OnFormatAction, ToolBox*, /*NOTINTERESTEDIN*/ ) IMPL_LINK( OGroupsSortingDialog, LBChangeHdl, ListBox*, pListBox ) { - if ( pListBox->GetSavedValue() != pListBox->GetSelectEntryPos() ) + if ( pListBox->IsValueChangedFromSaved() ) { sal_Int32 nRow = m_pFieldExpression->GetCurRow(); sal_Int32 nGroupPos = m_pFieldExpression->getGroupPosition(nRow); if ( pListBox != &m_aHeaderLst && pListBox != &m_aFooterLst) { - if ( pListBox->GetSavedValue() != pListBox->GetSelectEntryPos() ) + if ( pListBox->IsValueChangedFromSaved() ) SaveData(nRow); if ( pListBox == &m_aGroupOnLst ) m_aGroupIntervalEd.Enable( pListBox->GetSelectEntryPos() != 0 ); |