diff options
| author | Jochen Nitschke <j.nitschke+logerrit@ok.de> | 2017-09-10 18:08:52 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-09-10 21:04:58 +0200 |
| commit | 2cd664b3d618e6085be8b44ee86eada6cd5f8789 (patch) | |
| tree | 34c44118584e6d6a14d6d0c7c84df8852801d2a2 /reportdesign | |
| parent | a965e98848948253279caf6ea90049df9daaf864 (diff) | |
cppcheck: knownConditionTrueFalse 'bRet' is always false
regression of commit 528632660b72b105345945c13c5b68060d94a91b
Date: Thu Feb 9 08:52:13 2017 +0200
convert ErrCode to strong typedef
Change-Id: I5ce2b7d38c8d71ec40cc8de7c13e8aec637476b7
Reviewed-on: https://gerrit.libreoffice.org/42139
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'reportdesign')
| -rw-r--r-- | reportdesign/source/filter/xml/xmlfilter.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/reportdesign/source/filter/xml/xmlfilter.cxx b/reportdesign/source/filter/xml/xmlfilter.cxx index 0398bb51fe91..219593595726 100644 --- a/reportdesign/source/filter/xml/xmlfilter.cxx +++ b/reportdesign/source/filter/xml/xmlfilter.cxx @@ -559,8 +559,7 @@ bool ORptFilter::implImport( const Sequence< PropertyValue >& rDescriptor ) } - bRet = false; - nRet = ERRCODE_NONE; + bRet = nRet == ERRCODE_NONE; if ( bRet ) { |