diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-01-16 11:11:32 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-01-16 10:52:19 +0100 |
| commit | 8041a9b1fd26b64494ecb4c23022f39bd168a24f (patch) | |
| tree | 2ad86004de35a56859919b18f551b1dd92806eac /reportdesign | |
| parent | ef5812deb142d043e58965bf8f4829b50acffcee (diff) | |
return nullptr from Create*Context methods in nullptr subclasses
the calling class handles this nicely, and also tells us when we are not
handling some part of the XML file
Change-Id: Ic51a42b9d2dec96243e7f83b528d7455d4bc0504
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86906
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'reportdesign')
| -rw-r--r-- | reportdesign/source/filter/xml/xmlfilter.cxx | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/reportdesign/source/filter/xml/xmlfilter.cxx b/reportdesign/source/filter/xml/xmlfilter.cxx index 917dd5209411..69d4251fc337 100644 --- a/reportdesign/source/filter/xml/xmlfilter.cxx +++ b/reportdesign/source/filter/xml/xmlfilter.cxx @@ -727,7 +727,7 @@ public: SvXMLImportContext* ORptFilter::CreateDocumentContext( sal_uInt16 nPrefix, const OUString& rLocalName, - const uno::Reference< xml::sax::XAttributeList >& xAttrList ) + const uno::Reference< xml::sax::XAttributeList >& /*xAttrList*/ ) { SvXMLImportContext *pContext = nullptr; @@ -744,13 +744,8 @@ SvXMLImportContext* ORptFilter::CreateDocumentContext( sal_uInt16 nPrefix, case XML_TOK_DOC_CONTENT: pContext = new RptXMLDocumentContentContext(*this, nPrefix, rLocalName); break; - default: - break; } - if ( !pContext ) - pContext = SvXMLImport::CreateDocumentContext( nPrefix, rLocalName, xAttrList ); - return pContext; } |