diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2021-12-09 10:15:05 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2021-12-10 08:14:24 +0100 |
| commit | db3a61cd958f4a70417929cf8e1fa9bfd0bfe5a3 (patch) | |
| tree | 20c4ceba87df6b65e218a670ae22e35d7a1da30f /reportdesign | |
| parent | 5b0707f66e2c49a11f3a23e3ec9940b26d881165 (diff) | |
Generally determine Rdb content from gb_*_set_componentfile calls
...instead of by listing the content somewhat redundantly in the Rdb_*.mk
files, to avoid duplication of logic for components that are only built
conditionally (and thus should only be included conditionally in the
corresponding Rdb). To achieve that, add an "rdb" parameter to
gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros
that internally call gb_ComponentTarget_ComponentTarget), which is used to make
the appropriate gb_Rdb_add_component call internally from within
gb_ComponentTarget_ComponentTarget. (As a special case,
gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that
has already been done by the corresponding gb_Library_set_componentfile call, so
allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to
support that special case.)
Most Rdb_*.mk files are thus mostly empty now. One exception is
i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as
needed during the build in CustomTarget_i18npool/localedata.
1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built
components" had already tried to do something similar (in addition to other
things) under a new --enable-services-rdb-from-build option. However, that
approach had four drawbacks that this approach here addresses (and which thus
partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b):
1 Rdb_services shall not contain the component files of all libraries that are
built. While that commit filtered out the component files that go into
Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files
that go into others like Rdb_postgresql-sdbc
(connectivity/Rdb_postgresql-sdbc.mk).
2 The code added by that commit to Makefile.gbuild codified the knowledge that
there is an Rdb_services, which is brittle.
3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge
(for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle.
4 Introducing an --enable-services-rdb-from-build option needlessly provided
two different ways how the content of Rdb_services is assembled.
The changes done here would leave --enable-services-rdb-from-build as a
misnomer, as it no longer controls how Rdb_services is assembled. I thus
renamed it to --enable-customtarget-components, as that is apparently what it
still does now.
Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'reportdesign')
| -rw-r--r-- | reportdesign/Library_rpt.mk | 2 | ||||
| -rw-r--r-- | reportdesign/Library_rptui.mk | 2 | ||||
| -rw-r--r-- | reportdesign/Library_rptxml.mk | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/reportdesign/Library_rpt.mk b/reportdesign/Library_rpt.mk index c3f63a678881..f785485bc4fa 100644 --- a/reportdesign/Library_rpt.mk +++ b/reportdesign/Library_rpt.mk @@ -52,7 +52,7 @@ $(eval $(call gb_Library_use_libraries,rpt,\ vcl \ )) -$(eval $(call gb_Library_set_componentfile,rpt,reportdesign/util/rpt)) +$(eval $(call gb_Library_set_componentfile,rpt,reportdesign/util/rpt,services)) $(eval $(call gb_Library_add_exception_objects,rpt,\ reportdesign/source/core/api/FixedLine \ diff --git a/reportdesign/Library_rptui.mk b/reportdesign/Library_rptui.mk index ea98fb830b50..c64e57994c07 100644 --- a/reportdesign/Library_rptui.mk +++ b/reportdesign/Library_rptui.mk @@ -48,7 +48,7 @@ $(eval $(call gb_Library_use_libraries,rptui,\ vcl \ )) -$(eval $(call gb_Library_set_componentfile,rptui,reportdesign/util/rptui)) +$(eval $(call gb_Library_set_componentfile,rptui,reportdesign/util/rptui,services)) $(eval $(call gb_Library_add_exception_objects,rptui,\ reportdesign/source/ui/dlg/AddField \ diff --git a/reportdesign/Library_rptxml.mk b/reportdesign/Library_rptxml.mk index 5a1707c2af4c..c7ac8309814b 100644 --- a/reportdesign/Library_rptxml.mk +++ b/reportdesign/Library_rptxml.mk @@ -46,7 +46,7 @@ $(eval $(call gb_Library_use_libraries,rptxml,\ xo \ )) -$(eval $(call gb_Library_set_componentfile,rptxml,reportdesign/util/rptxml)) +$(eval $(call gb_Library_set_componentfile,rptxml,reportdesign/util/rptxml,services)) $(eval $(call gb_Library_add_exception_objects,rptxml,\ reportdesign/source/filter/xml/dbloader2 \ |