diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2021-08-15 17:35:58 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-08-16 12:07:15 +0200 |
| commit | eec42f0dbcc79a4c9f456ce97fa1066b8031ea28 (patch) | |
| tree | f089f757270293bd94dfac881c62520af76975e0 /reportdesign | |
| parent | a6ca6215a5ec82e833ebfcd2ebd4455cb504fd8e (diff) | |
pass OutlinerParaObject around by value
since it uses o3tl::cow_wrapper, so it is really just a wrapper
around a pointer, no point in allocating it on the heap
Remove assert in SdrText::SetOutlinerParaObject, which was
bogus anyhow, because it was comparing pointers, not deep equality.
And since we are now being more efficient and avoiding
copying of the internal data in OutlinerParaObject, we hit
this assert.
Change-Id: I6dbfaab5ee2ca05b2001baf63110041e469df9c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120510
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'reportdesign')
| -rw-r--r-- | reportdesign/source/core/sdr/ReportDrawPage.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/reportdesign/source/core/sdr/ReportDrawPage.cxx b/reportdesign/source/core/sdr/ReportDrawPage.cxx index 0c1e15cebb13..1823c3c07527 100644 --- a/reportdesign/source/core/sdr/ReportDrawPage.cxx +++ b/reportdesign/source/core/sdr/ReportDrawPage.cxx @@ -113,7 +113,7 @@ uno::Reference< drawing::XShape > OReportDrawPage::CreateShape( SdrObject *pObj * The empty OLE object gets a new IPObj **************************************************/ pObj->SetEmptyPresObj(false); - rOle2Obj.SetOutlinerParaObject(nullptr); + rOle2Obj.SetOutlinerParaObject(std::nullopt); rOle2Obj.SetObjRef(xObj); rOle2Obj.SetPersistName(sName); rOle2Obj.SetName(sName); |