OK for boolean() to take true bool argument

...instead of sal_Bool; this would cause C4800 performance warnings with MSVC,
but we disable them anyway.

Also, added unit tests that are actually executed.

Change-Id: Ib405132565918be72d93b3fc24180edcb6e565c7

2 files changed, 4 insertions, 4 deletions

diff --git a/sal/inc/rtl/string.hxx b/sal/inc/rtl/string.hxx
index 9ed01e5824cb..a239768df777 100644
--- a/sal/inc/rtl/string.hxx
+++ b/sal/inc/rtl/string.hxx
@@ -1504,11 +1504,11 @@ public:
       If the sal_Bool is false, the string "false" is returned.
       This function can't be used for language specific conversion.
 
-      @param    b   a sal_Bool.
+      @param    b   a bool.
       @return   a string with the string representation of the argument.
       @since LibreOffice 4.1
     */
-    static OString boolean( sal_Bool b ) SAL_THROW(())
+    static OString boolean( bool b ) SAL_THROW(())
     {
         sal_Char aBuf[RTL_STR_MAX_VALUEOFBOOLEAN];
         rtl_String* pNewData = 0;
diff --git a/sal/inc/rtl/ustring.hxx b/sal/inc/rtl/ustring.hxx
index 7cdbb4e22d90..25ed82b2b83d 100644
--- a/sal/inc/rtl/ustring.hxx
+++ b/sal/inc/rtl/ustring.hxx
@@ -2155,11 +2155,11 @@ public:
       If the sal_Bool is false, the string "false" is returned.
       This function can't be used for language specific conversion.
 
-      @param    b   a sal_Bool.
+      @param    b   a bool.
       @return   a string with the string representation of the argument.
       @since LibreOffice 4.1
     */
-    static OUString boolean( sal_Bool b ) SAL_THROW(())
+    static OUString boolean( bool b ) SAL_THROW(())
     {
         sal_Unicode aBuf[RTL_USTR_MAX_VALUEOFBOOLEAN];
         rtl_uString* pNewData = 0;