osl_get_system_random_data should return bool

Change-Id: I29535d3562fe1b8d05b8df1d6c9ab83e4ead0f74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163227
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2 files changed, 6 insertions, 6 deletions

diff --git a/sal/osl/unx/random.cxx b/sal/osl/unx/random.cxx
index e8379f8f0bf7..fbb2d7dedb90 100644
--- a/sal/osl/unx/random.cxx
+++ b/sal/osl/unx/random.cxx
@@ -14,7 +14,7 @@
 #include <fcntl.h>
 #include <unistd.h>
 
-int osl_get_system_random_data(char* buffer, size_t desired_len)
+bool osl_get_system_random_data(char* buffer, size_t desired_len)
 {
     int fd;
 
diff --git a/sal/osl/w32/random.cxx b/sal/osl/w32/random.cxx
index a2c364da2ebb..27ee14fdd6d4 100644
--- a/sal/osl/w32/random.cxx
+++ b/sal/osl/w32/random.cxx
@@ -14,7 +14,7 @@
 
 #include <oslrandom.h>
 
-int osl_get_system_random_data(char* buffer, size_t desired_len)
+bool osl_get_system_random_data(char* buffer, size_t desired_len)
 {
     unsigned int val;
 
@@ -29,7 +29,7 @@ int osl_get_system_random_data(char* buffer, size_t desired_len)
         }
         if (rand_s(&val))
         {
-            return 0;
+            return false;
         }
         memcpy(buffer, &val, len);
         buffer += len;
@@ -40,7 +40,7 @@ int osl_get_system_random_data(char* buffer, size_t desired_len)
     {
         if (rand_s(reinterpret_cast<unsigned int*>(buffer)))
         {
-            return 0;
+            return false;
         }
         else
         {
@@ -53,11 +53,11 @@ int osl_get_system_random_data(char* buffer, size_t desired_len)
     {
         if (rand_s(&val))
         {
-            return 0;
+            return false;
         }
         memcpy(buffer, &val, desired_len);
     }
-    return 1;
+    return true;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */