diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-01-31 14:46:38 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-02-01 12:15:22 +0000 |
commit | 2489000d3fd66319a8355fd4e37cfdfda47296d0 (patch) | |
tree | caad79e7b5bec3863604b20190b682c0d73d2b25 /sal/qa/rtl/process/rtl_Process.cxx | |
parent | 595848c85acc2609fcc48a40c7a9f216a2722cd8 (diff) |
loplugin:useuniqueptr extend to check local vars
just the simple and obvious case for now, of a local var being allocated
and deleted inside a single local block, and the delete happening at the
end of the block
Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625
Reviewed-on: https://gerrit.libreoffice.org/33749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sal/qa/rtl/process/rtl_Process.cxx')
-rw-r--r-- | sal/qa/rtl/process/rtl_Process.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sal/qa/rtl/process/rtl_Process.cxx b/sal/qa/rtl/process/rtl_Process.cxx index 7101bade2fc7..5901529af6e9 100644 --- a/sal/qa/rtl/process/rtl_Process.cxx +++ b/sal/qa/rtl/process/rtl_Process.cxx @@ -119,11 +119,11 @@ public: // "osl_joinProcess returned with failure", // osl_Process_E_None == osl_error // ); - oslProcessInfo* pInfo = new oslProcessInfo; + std::unique_ptr<oslProcessInfo> pInfo( new oslProcessInfo ); //please pay attention to initial the Size to sizeof(oslProcessInfo), or else //you will get unknown error when call osl_getProcessInfo pInfo->Size = sizeof(oslProcessInfo); - osl_error = osl_getProcessInfo( hProcess, osl_Process_EXITCODE, pInfo ); + osl_error = osl_getProcessInfo( hProcess, osl_Process_EXITCODE, pInfo.get() ); CPPUNIT_ASSERT_EQUAL_MESSAGE ( "osl_getProcessInfo returned with failure", @@ -132,7 +132,6 @@ public: printf("the exit code is %" SAL_PRIuUINT32 ".\n", pInfo->Code ); CPPUNIT_ASSERT_EQUAL_MESSAGE("rtl_getAppCommandArg or rtl_getAppCommandArgCount error.", static_cast<oslProcessExitCode>(2), pInfo->Code); - delete pInfo; } CPPUNIT_TEST_SUITE(getAppCommandArg); |