diff options
author | Caolán McNamara <caolanm@redhat.com> | 2018-07-26 12:22:16 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2018-07-27 09:32:19 +0200 |
commit | ba1e1727c238210b022741a710486964f28bb065 (patch) | |
tree | 8b8a5afbc4a16eef7dc95b144937fa57cf6c9abd /sal/rtl | |
parent | 877dd9e9d1c1774817fa96f62adda98d5bce0ce8 (diff) |
Related: rhbz#1602589 add comments to coverity annotations
Change-Id: I88c941832a0d682ea4b6028c28edd48cf5df38f7
Reviewed-on: https://gerrit.libreoffice.org/58093
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sal/rtl')
-rw-r--r-- | sal/rtl/alloc_arena.cxx | 2 | ||||
-rw-r--r-- | sal/rtl/alloc_cache.cxx | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/sal/rtl/alloc_arena.cxx b/sal/rtl/alloc_arena.cxx index 1cd06615d1a3..39e694e017d8 100644 --- a/sal/rtl/alloc_arena.cxx +++ b/sal/rtl/alloc_arena.cxx @@ -258,7 +258,7 @@ void rtl_arena_hash_rescale( rtl_arena_segment_type * next = curr->m_fnext; rtl_arena_segment_type ** head; - // coverity[negative_shift] + // coverity[negative_shift] - bogus head = &(arena->m_hash_table[RTL_ARENA_HASH_INDEX(arena, curr->m_addr)]); curr->m_fnext = (*head); (*head) = curr; diff --git a/sal/rtl/alloc_cache.cxx b/sal/rtl/alloc_cache.cxx index 38449ccfb795..41886c7ac235 100644 --- a/sal/rtl/alloc_cache.cxx +++ b/sal/rtl/alloc_cache.cxx @@ -817,7 +817,7 @@ void rtl_cache_deactivate(rtl_cache_type * cache) /* cleanup cpu layer */ if ((mag = cache->m_cpu_curr)) { - // coverity[missing_lock] + // coverity[missing_lock] - locking is fine cache->m_cpu_curr = nullptr; rtl_cache_magazine_clear (cache, mag); rtl_cache_free (mag_cache, mag); @@ -825,7 +825,7 @@ void rtl_cache_deactivate(rtl_cache_type * cache) if ((mag = cache->m_cpu_prev)) { - // coverity[missing_lock] + // coverity[missing_lock] - locking is fine cache->m_cpu_prev = nullptr; rtl_cache_magazine_clear (cache, mag); rtl_cache_free (mag_cache, mag); @@ -1267,7 +1267,7 @@ static void rtl_cache_depot_wsupdate( RTL_MEMORY_LOCK_ACQUIRE(&(cache->m_depot_lock)); } } - // coverity[missing_unlock] + // coverity[missing_unlock] - locking is fine } /** |