Extend loplugin:external to warn about classes

...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend
loplugin:external to warn about enums".

Cases where free functions were moved into an unnamed namespace along with a
class, to not break ADL, are in:

filter/source/svg/svgexport.cxx
sc/source/filter/excel/xelink.cxx
sc/source/filter/excel/xilink.cxx
svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx

All other free functions mentioning moved classes appear to be harmless and not
give rise to (silent, even) ADL breakage.  (One remaining TODO in
compilerplugins/clang/external.cxx is that derived classes are not covered by
computeAffectedTypes, even though they could also be affected by ADL-breakage---
but don't seem to be in any acutal case across the code base.)

For friend declarations using elaborate type specifiers, like

class C1 {};
class C2 { friend class C1; };

* If C2 (but not C1) is moved into an unnamed namespace, the friend declaration
must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see
C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither
qualified nor a template-id and the declaration is a function or an
elaborated-type-specifier, the lookup to determine whether the entity has been
previously declared shall not consider any scopes outside the innermost
enclosing namespace.")

* If C1 (but not C2) is moved into an unnamed namespace, the friend declaration
must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882>
"elaborated-type-specifier friend not looked up in unnamed namespace".

Apart from that, to keep changes simple and mostly mechanical (which should help
avoid regressions), out-of-line definitions of class members have been left in
the enclosing (named) namespace.  But explicit specializations of class
templates had to be moved into the unnamed namespace to appease
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of
template from unnamed namespace using unqualified-id in enclosing namespace".

Also, accompanying declarations (of e.g. typedefs or static variables) that
could arguably be moved into the unnamed namespace too have been left alone.

And in some cases, mention of affected types in blacklists in other loplugins
needed to be adapted.

And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which
is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is
not moved into an unnamed namespace (because it is declared in
sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is.  GCC warns about
such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler
doesn’t give this warning for types defined in the main .C file, as those are
unlikely to have multiple definitions."
(<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>)  The
warned-about classes also don't have multiple definitions in the given test, so
disable the warning when including the .cxx.

Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4
Reviewed-on: https://gerrit.libreoffice.org/83239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

4 files changed, 20 insertions, 0 deletions

diff --git a/sal/textenc/convertisciidevangari.cxx b/sal/textenc/convertisciidevangari.cxx
index b8566ed6a51e..ae25d811df2d 100644
--- a/sal/textenc/convertisciidevangari.cxx
+++ b/sal/textenc/convertisciidevangari.cxx
@@ -22,6 +22,8 @@
 using namespace sal::detail::textenc;
 using namespace rtl::textenc;
 
+namespace {
+
 struct IsciiDevanagariToUnicode
 {
     sal_uInt8 m_cPrevChar;
@@ -57,6 +59,8 @@ struct UnicodeToIsciiDevanagari
         sal_uInt32 * pInfo, sal_Size * pSrcCvtChars);
 };
 
+}
+
 static const sal_Unicode IsciiDevanagariMap[256] =
 {
     0x0000,0x0001,0x0002,0x0003,0x0004,0x0005,0x0006,0x0007,
diff --git a/sal/textenc/tcvtutf7.cxx b/sal/textenc/tcvtutf7.cxx
index b09ccd47f1d8..1a1ca7603241 100644
--- a/sal/textenc/tcvtutf7.cxx
+++ b/sal/textenc/tcvtutf7.cxx
@@ -91,6 +91,8 @@ static unsigned char const aImplMustShiftTab[128] =
 
 /* ----------------------------------------------------------------------- */
 
+namespace {
+
 struct ImplUTF7ToUCContextData
 {
     bool                    mbShifted;
@@ -100,6 +102,8 @@ struct ImplUTF7ToUCContextData
     sal_uInt32              mnBufferBits;
 };
 
+}
+
 /* ----------------------------------------------------------------------- */
 
 void* ImplUTF7CreateUTF7TextToUnicodeContext()
@@ -410,6 +414,8 @@ sal_Size ImplUTF7ToUnicode( SAL_UNUSED_PARAMETER const void*, void* pContext,
 
 /* ======================================================================= */
 
+namespace {
+
 struct ImplUTF7FromUCContextData
 {
     bool                    mbShifted;
@@ -417,6 +423,8 @@ struct ImplUTF7FromUCContextData
     sal_uInt32              mnBufferBits;
 };
 
+}
+
 /* ----------------------------------------------------------------------- */
 
 void* ImplUTF7CreateUnicodeToTextContext()
diff --git a/sal/textenc/tcvtutf8.cxx b/sal/textenc/tcvtutf8.cxx
index 950d810e8b85..ca29156c418f 100644
--- a/sal/textenc/tcvtutf8.cxx
+++ b/sal/textenc/tcvtutf8.cxx
@@ -30,6 +30,8 @@
 #include "tenchelp.hxx"
 #include "unichars.hxx"
 
+namespace {
+
 struct ImplUtf8ToUnicodeContext
 {
     sal_uInt32 nUtf32;
@@ -43,6 +45,8 @@ struct ImplUnicodeToUtf8Context
     sal_Unicode nHighSurrogate; /* 0xFFFF: write BOM */
 };
 
+}
+
 void * ImplCreateUtf8ToUnicodeContext()
 {
     ImplUtf8ToUnicodeContext * p = new ImplUtf8ToUnicodeContext;
diff --git a/sal/textenc/tencinfo.cxx b/sal/textenc/tencinfo.cxx
index f541fcb20004..b69cf4c586fd 100644
--- a/sal/textenc/tencinfo.cxx
+++ b/sal/textenc/tencinfo.cxx
@@ -102,6 +102,8 @@ static bool Impl_matchString( const char* pCompStr, const char* pMatchStr )
 
 /* ======================================================================= */
 
+namespace {
+
 struct ImplStrCharsetDef
 {
     const char*             mpCharsetStr;
@@ -114,6 +116,8 @@ struct ImplStrFirstPartCharsetDef
     const ImplStrCharsetDef*    mpSecondPartTab;
 };
 
+}
+
 /* ======================================================================= */
 
 sal_Bool SAL_CALL rtl_getTextEncodingInfo( rtl_TextEncoding eTextEncoding, rtl_TextEncodingInfo* pEncInfo )