summaryrefslogtreecommitdiff
path: root/sal
diff options
context:
space:
mode:
authorLuboš Luňák <l.lunak@suse.cz>2012-03-08 00:20:05 +0100
committerLuboš Luňák <l.lunak@suse.cz>2012-03-12 13:35:56 +0100
commit8c5e68b0f649b1694531811b2fd5d32ab75a201e (patch)
treecebb522de55f674b30399957529abe7c80f2aaf1 /sal
parent715bdfdd8f994607f07bb577c727189a3a434607 (diff)
make the OUString unittest ctor contain garbage
this will make it easier to detect errors, rather than making it empty
Diffstat (limited to 'sal')
-rw-r--r--sal/inc/rtl/ustring.hxx6
-rw-r--r--sal/qa/rtl/strings/test_oustring_stringliterals.cxx2
2 files changed, 4 insertions, 4 deletions
diff --git a/sal/inc/rtl/ustring.hxx b/sal/inc/rtl/ustring.hxx
index bb22619b6c69..b6cd1e28eded 100644
--- a/sal/inc/rtl/ustring.hxx
+++ b/sal/inc/rtl/ustring.hxx
@@ -212,8 +212,8 @@ public:
#else
{
(void) value; // unused
- pData = 0; // for the unittest create an empty string
- rtl_uString_new( &pData );
+ pData = 0;
+ rtl_uString_newFromLiteral( &pData, "!!br0ken!!", 10 ); // set to garbage
}
#endif
@@ -226,7 +226,7 @@ public:
OUString( T )
{
pData = 0;
- rtl_uString_new( &pData );
+ rtl_uString_newFromLiteral( &pData, "!!br0ken!!", 10 ); // set to garbage
}
#endif
diff --git a/sal/qa/rtl/strings/test_oustring_stringliterals.cxx b/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
index 5a1d987edc62..2a7d38a45860 100644
--- a/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
+++ b/sal/qa/rtl/strings/test_oustring_stringliterals.cxx
@@ -48,7 +48,7 @@ private:
void testcall( const char str[] );
// invalid conversions will trigger templated OUString ctor that creates an empty string
// (see RTL_STRING_UNITTEST)
- bool validConversion( const rtl::OUString& str ) { return !str.isEmpty(); }
+ bool validConversion( const rtl::OUString& str ) { return str != "!!br0ken!!"; }
CPPUNIT_TEST_SUITE(StringLiterals);
CPPUNIT_TEST(checkCtors);