diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-11-22 09:33:32 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-11-23 06:59:31 +0100 |
| commit | 7a1c21e53fc4733a4bb52282ce0098fcc085ab0e (patch) | |
| tree | c1b90f74e1ce9e9f3a852f398890899459189cab /sal | |
| parent | c24c32bf71b8e64bd0d36e511f554e1f6c015842 (diff) | |
loplugin:simplifybool for negation of comparison operator
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sal')
| -rw-r--r-- | sal/osl/unx/pipe.cxx | 2 | ||||
| -rw-r--r-- | sal/rtl/digest.cxx | 18 | ||||
| -rw-r--r-- | sal/rtl/math.cxx | 2 |
3 files changed, 11 insertions, 11 deletions
diff --git a/sal/osl/unx/pipe.cxx b/sal/osl/unx/pipe.cxx index bbb47368eff9..e577e89608ba 100644 --- a/sal/osl/unx/pipe.cxx +++ b/sal/osl/unx/pipe.cxx @@ -441,7 +441,7 @@ oslPipe SAL_CALL osl_acceptPipe(oslPipe pPipe) /* set close-on-exec flag */ int flags; - if (!((flags = fcntl(s, F_GETFD, 0)) < 0)) + if ((flags = fcntl(s, F_GETFD, 0)) >= 0) { flags |= FD_CLOEXEC; if (fcntl(s, F_SETFD, flags) < 0) diff --git a/sal/rtl/digest.cxx b/sal/rtl/digest.cxx index e784c4d13de3..85d7357ef6fc 100644 --- a/sal/rtl/digest.cxx +++ b/sal/rtl/digest.cxx @@ -347,7 +347,7 @@ rtlDigestError SAL_CALL rtl_digest_updateMD2( if (!pImpl || !pData) return rtl_Digest_E_Argument; - if (!(pImpl->m_digest.m_algorithm == rtl_Digest_AlgorithmMD2)) + if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmMD2) return rtl_Digest_E_Algorithm; if (nDatLen == 0) @@ -406,7 +406,7 @@ rtlDigestError SAL_CALL rtl_digest_getMD2( if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmMD2) return rtl_Digest_E_Algorithm; - if (!(pImpl->m_digest.m_length <= nBufLen)) + if (pImpl->m_digest.m_length > nBufLen) return rtl_Digest_E_BufferSize; ctx = &(pImpl->m_context); @@ -686,7 +686,7 @@ rtlDigestError SAL_CALL rtl_digest_updateMD5( if (!pImpl || !pData) return rtl_Digest_E_Argument; - if (!(pImpl->m_digest.m_algorithm == rtl_Digest_AlgorithmMD5)) + if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmMD5) return rtl_Digest_E_Algorithm; if (nDatLen == 0) @@ -760,7 +760,7 @@ rtlDigestError SAL_CALL rtl_digest_getMD5( if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmMD5) return rtl_Digest_E_Algorithm; - if (!(pImpl->m_digest.m_length <= nBufLen)) + if (pImpl->m_digest.m_length > nBufLen) return rtl_Digest_E_BufferSize; ctx = &(pImpl->m_context); @@ -790,7 +790,7 @@ rtlDigestError SAL_CALL rtl_digest_rawMD5( if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmMD5) return rtl_Digest_E_Algorithm; - if (!(pImpl->m_digest.m_length <= nBufLen)) + if (pImpl->m_digest.m_length > nBufLen) return rtl_Digest_E_BufferSize; ctx = &(pImpl->m_context); @@ -1201,7 +1201,7 @@ rtlDigestError SAL_CALL rtl_digest_getSHA( if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmSHA) return rtl_Digest_E_Algorithm; - if (!(pImpl->m_digest.m_length <= nBufLen)) + if (pImpl->m_digest.m_length > nBufLen) return rtl_Digest_E_BufferSize; ctx = &(pImpl->m_context); @@ -1361,7 +1361,7 @@ rtlDigestError SAL_CALL rtl_digest_getSHA1 ( if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmSHA1) return rtl_Digest_E_Algorithm; - if (!(pImpl->m_digest.m_length <= nBufLen)) + if (pImpl->m_digest.m_length > nBufLen) return rtl_Digest_E_BufferSize; ctx = &(pImpl->m_context); @@ -1555,7 +1555,7 @@ rtlDigestError SAL_CALL rtl_digest_getHMAC_MD5( if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmHMAC_MD5) return rtl_Digest_E_Algorithm; - if (!(pImpl->m_digest.m_length <= nBufLen)) + if (pImpl->m_digest.m_length > nBufLen) return rtl_Digest_E_BufferSize; nBufLen = pImpl->m_digest.m_length; @@ -1751,7 +1751,7 @@ rtlDigestError SAL_CALL rtl_digest_getHMAC_SHA1( if (pImpl->m_digest.m_algorithm != rtl_Digest_AlgorithmHMAC_SHA1) return rtl_Digest_E_Algorithm; - if (!(pImpl->m_digest.m_length <= nBufLen)) + if (pImpl->m_digest.m_length > nBufLen) return rtl_Digest_E_BufferSize; nBufLen = pImpl->m_digest.m_length; diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx index 96c5843dcfea..a9b30a4dc498 100644 --- a/sal/rtl/math.cxx +++ b/sal/rtl/math.cxx @@ -170,7 +170,7 @@ bool isRepresentableInteger(double fAbsValue) // this here. double fInt; return (nInt <= kMaxInt && - (!((fInt = static_cast< double >(nInt)) < fAbsValue) && !(fInt > fAbsValue))); + (((fInt = static_cast< double >(nInt)) >= fAbsValue) && (fInt <= fAbsValue))); } return false; } |